* missing break? linux/drivers/video/riva/fbdev.c
@ 2001-09-14 4:26 andrew may
0 siblings, 0 replies; 2+ messages in thread
From: andrew may @ 2001-09-14 4:26 UTC (permalink / raw)
To: Kernel Mailing List; +Cc: Ani Joshi
I have noticed this in the 2.4.10-pre patches.
It looks like an obvious missing break on after rc =15;
diff -u --recursive --new-file v2.4.9/linux/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
--- v2.4.9/linux/drivers/video/riva/fbdev.c Wed Jul 25 17:10:24 2001
+++ linux/drivers/video/riva/fbdev.c Fri Sep 7 09:28:38 2001
@@ -260,7 +260,7 @@
#endif
#ifndef MODULE
-static const char *mode_option __initdata = NULL;
+static char *mode_option __initdata = NULL;
#else
static char *font = NULL;
#endif
@@ -1109,6 +1109,8 @@
break;
#endif
#ifdef FBCON_HAS_CFB16
+ case 15:
+ rc = 15; /* fix for 15 bpp depths on Riva 128 based cards */
case 16:
rc = 16; /* directcolor... 16 entries SW palette */
break; /* Mystique: truecolor, 16 entries SW palette, HW palette hardwired into 1:1 mapping */
@@ -1119,7 +1121,6 @@
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: missing break? linux/drivers/video/riva/fbdev.c
@ 2001-09-14 18:09 Petr Vandrovec
0 siblings, 0 replies; 2+ messages in thread
From: Petr Vandrovec @ 2001-09-14 18:09 UTC (permalink / raw)
To: andrew may; +Cc: Ani Joshi, linux-kernel
On 13 Sep 01 at 21:26, andrew may wrote:
> diff -u --recursive --new-file v2.4.9/linux/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
> --- v2.4.9/linux/drivers/video/riva/fbdev.c Wed Jul 25 17:10:24 2001
> +++ linux/drivers/video/riva/fbdev.c Fri Sep 7 09:28:38 2001
> @@ -1109,6 +1109,8 @@
> break;
> #endif
> #ifdef FBCON_HAS_CFB16
> + case 15:
> + rc = 15; /* fix for 15 bpp depths on Riva 128 based cards */
> case 16:
> rc = 16; /* directcolor... 16 entries SW palette */
> break; /* Mystique: truecolor, 16 entries SW palette, HW palette hardwired into 1:1 mapping */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I do not think that this comment should be in rivafb driver ;-) It
is completely unrelated to Riva hardware, it came from matroxfb.
Best regards,
Petr Vandrovec
vandrove@vc.cvut.cz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-09-14 16:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-14 4:26 missing break? linux/drivers/video/riva/fbdev.c andrew may
2001-09-14 18:09 Petr Vandrovec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).