From: Taral <taral@taral.net>
To: Robert Love <rml@tech9.net>
Cc: Andrew Morton <akpm@zip.com.au>,
Colin Phipps <cph@cph.demon.co.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] updated preempt-kernel
Date: Mon, 22 Oct 2001 10:36:57 -0500 [thread overview]
Message-ID: <20011022103657.B24814@taral.net> (raw)
In-Reply-To: <1003562833.862.65.camel@phantasy>, <1003562833.862.65.camel@phantasy> <20011021120539.A1197@cph.demon.co.uk> <3BD2E89C.78D757A2@zip.com.au> <1003688179.1085.17.camel@phantasy>
On Sun, Oct 21, 2001 at 02:16:18PM -0400, Robert Love wrote:
> Colin, can you try Andrew's patch and report back? This problem has
> been reported before -- its a tty bug that preempt (and SMP I wager)
> just aggravate. I have a patch that I know fixes it, but Andrew's is
> _much_ simpler. I will send you that if this fails. Please let me
> know.
This also looks a bit wrong:
> > + if (vt) {
> > + /*
> > + * If we raced with con_close(), `vt' may be null.
> > + * Hence this bandaid. - akpm
> > + */
> > + acquire_console_sem();
> > + set_cursor(vt->vc_num);
> > + release_console_sem();
> > + }
Maybe should be:
acquire_console_sem();
if (vt) set_cursor(vt->vc_num);
release_console_sem();
??
--
Taral <taral@taral.net>
This message is digitally signed. Please PGP encrypt mail to me.
"Any technology, no matter how primitive, is magic to those who don't
understand it." -- Florence Ambrose
next prev parent reply other threads:[~2001-10-22 15:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-20 7:27 [PATCH] updated preempt-kernel Robert Love
2001-10-20 12:44 ` elko
2001-10-22 20:43 ` elko
2001-10-22 23:11 ` Robert Love
2001-10-23 15:13 ` elko
2001-10-23 15:40 ` Andre's PDC20269 support patch? J.R. de Jong
2001-10-20 12:59 ` [PATCH] updated preempt-kernel Lorenzo Allegrucci
2001-10-20 17:02 ` Robert Love
2001-10-22 15:32 ` bill davidsen
2001-10-22 18:39 ` Mike Fedyk
2001-10-22 23:08 ` Robert Love
2001-10-21 11:05 ` Colin Phipps
2001-10-21 15:24 ` Andrew Morton
2001-10-21 18:16 ` Robert Love
2001-10-22 15:36 ` Taral [this message]
2001-10-21 18:23 ` Federico Sevilla III
2001-10-22 8:27 ` Jesper Juhl
2001-10-22 14:46 ` szonyi calin
2001-10-22 23:03 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011022103657.B24814@taral.net \
--to=taral@taral.net \
--cc=akpm@zip.com.au \
--cc=cph@cph.demon.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).