From: Oleg Drokin <green@namesys.com>
To: Stephan von Krawczynski <skraw@ithnet.com>
Cc: trond.myklebust@fys.uio.no, linux-kernel@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client)
Date: Mon, 11 Mar 2002 15:59:37 +0300 [thread overview]
Message-ID: <20020311155937.A1474@namesys.com> (raw)
In-Reply-To: <shswuwkujx5.fsf@charged.uio.no> <200203110018.BAA11921@webserver.ithnet.com> <15499.64058.442959.241470@charged.uio.no> <20020311091458.A24600@namesys.com> <20020311114654.2901890f.skraw@ithnet.com> <20020311135256.A856@namesys.com> <20020311141154.C856@namesys.com> <20020311134717.65fafb85.skraw@ithnet.com>
In-Reply-To: <20020311134717.65fafb85.skraw@ithnet.com>
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
Hello!
On Mon, Mar 11, 2002 at 01:47:17PM +0100, Stephan von Krawczynski wrote:
> What else can I try?
> I checked the setup with another client kernel 2.4.18, and guess what: it has
> the same problem. I have the impression that the problem is somewhere on the
> nfs server side - possibly around the umount case. Trond, Ken?
Just to be sure - have you tried 2.4.17 at the server?
2.4.18 have 2 patches included that were supposed to have another
stale filehandle problem resolved.
Our test have not shown any problems, but I am interested can you still
reproduce with these 2 patches reversed off the 2.4.18?
Also if you still can trigger, apply back only 1st hunk of G-... patch.
Bye,
Oleg
[-- Attachment #2: A-bigendian-lookup-fix.diff --]
[-- Type: text/plain, Size: 480 bytes --]
--- linux.orig/fs/reiserfs/inode.c Mon, 11 Feb 2002 12:21:42 -0500
+++ linux/fs/reiserfs/inode.c Mon, 18 Feb 2002 19:43:55 -0500
@@ -1207,7 +1211,8 @@
struct reiserfs_iget4_args *args;
args = opaque;
- return INODE_PKEY( inode ) -> k_dir_id == args -> objectid;
+ /* args is already in CPU order */
+ return le32_to_cpu(INODE_PKEY(inode)->k_dir_id) == args -> objectid;
}
struct inode * reiserfs_iget (struct super_block * s, const struct cpu_key * key)
[-- Attachment #3: G-nfs_stale_inode_access.diff --]
[-- Type: text/plain, Size: 1524 bytes --]
--- linux/fs/reiserfs/inode.c.o Fri Feb 1 14:08:22 2002
+++ linux/fs/reiserfs/inode.c Fri Feb 1 14:09:40 2002
@@ -1156,6 +1156,7 @@
/* a stale NFS handle can trigger this without it being an error */
pathrelse (&path_to_sd);
make_bad_inode(inode) ;
+ inode->i_nlink = 0;
return;
}
@@ -1188,6 +1189,27 @@
}
+/**
+ * reiserfs_find_actor() - "find actor" reiserfs supplies to iget4().
+ *
+ * @inode: inode from hash table to check
+ * @inode_no: inode number we are looking for
+ * @opaque: "cookie" passed to iget4(). This is &reiserfs_iget4_args.
+ *
+ * This function is called by iget4() to distinguish reiserfs inodes
+ * having the same inode numbers. Such inodes can only exist due to some
+ * error condition. One of them should be bad. Inodes with identical
+ * inode numbers (objectids) are distinguished by parent directory ids.
+ *
+ */
+static int reiserfs_find_actor( struct inode *inode,
+ unsigned long inode_no, void *opaque )
+{
+ struct reiserfs_iget4_args *args;
+
+ args = opaque;
+ return INODE_PKEY( inode ) -> k_dir_id == args -> objectid;
+}
struct inode * reiserfs_iget (struct super_block * s, const struct cpu_key * key)
{
@@ -1195,7 +1217,8 @@
struct reiserfs_iget4_args args ;
args.objectid = key->on_disk_key.k_dir_id ;
- inode = iget4 (s, key->on_disk_key.k_objectid, 0, (void *)(&args));
+ inode = iget4 (s, key->on_disk_key.k_objectid,
+ reiserfs_find_actor, (void *)(&args));
if (!inode)
return ERR_PTR(-ENOMEM) ;
next prev parent reply other threads:[~2002-03-11 13:00 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-09 12:19 BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client) Stephan von Krawczynski
2002-03-09 19:10 ` Alan Cox
2002-03-10 17:50 ` Stephan von Krawczynski
2002-03-10 22:39 ` Trond Myklebust
2002-03-11 0:18 ` Stephan von Krawczynski
2002-03-11 0:28 ` Trond Myklebust
2002-03-11 6:14 ` Oleg Drokin
2002-03-11 10:46 ` Stephan von Krawczynski
2002-03-11 10:52 ` Oleg Drokin
2002-03-11 11:24 ` Stephan von Krawczynski
2002-03-11 12:47 ` Stephan von Krawczynski
2002-03-11 12:59 ` Oleg Drokin [this message]
2002-03-15 11:02 ` Stephan von Krawczynski
2002-03-15 11:13 ` Oleg Drokin
2002-03-15 11:30 ` Stephan von Krawczynski
2002-03-15 11:36 ` Sean Neakums
2002-03-15 11:37 ` Oleg Drokin
2002-03-15 12:03 ` Stephan von Krawczynski
2002-03-15 12:05 ` Oleg Drokin
2002-03-21 14:45 ` Stephan von Krawczynski
2002-03-21 14:57 ` Stephan von Krawczynski
2002-03-21 15:01 ` Oleg Drokin
2002-03-21 15:05 ` Stephan von Krawczynski
2002-03-21 15:07 ` Oleg Drokin
2002-03-21 17:15 ` Stephan von Krawczynski
2002-03-22 5:48 ` Oleg Drokin
2002-03-22 0:19 ` Trond Myklebust
2002-03-22 11:00 ` Stephan von Krawczynski
2002-03-22 11:07 ` Trond Myklebust
2002-03-22 13:19 ` Stephan von Krawczynski
2002-03-15 14:07 ` Stephan von Krawczynski
2002-03-11 14:48 ` Stephan von Krawczynski
2002-03-11 13:51 ` Oleg Drokin
2002-03-11 14:03 ` Trond Myklebust
2002-03-11 15:57 ` Stephan von Krawczynski
2002-03-11 16:31 ` Hans Reiser
2002-03-15 10:32 ` Oleg Drokin
2002-03-11 13:59 ` Trond Myklebust
2002-03-11 11:00 ` Stephan von Krawczynski
2002-03-11 11:11 ` Oleg Drokin
2002-03-18 7:07 ` NIIBE Yutaka
2002-03-18 8:15 ` Trond Myklebust
2002-03-18 9:33 ` NIIBE Yutaka
2002-03-18 9:56 ` Trond Myklebust
2002-03-18 23:57 ` NIIBE Yutaka
2002-03-19 14:45 ` Trond Myklebust
2002-03-20 0:42 ` NIIBE Yutaka
2002-03-20 8:30 ` Trond Myklebust
2002-03-19 15:42 ` Ton Hospel
2002-03-19 18:31 ` BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and Alan Cox
2002-03-19 22:10 ` BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client) Trond Myklebust
2002-03-22 10:33 ` David Woodhouse
2002-03-22 11:03 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020311155937.A1474@namesys.com \
--to=green@namesys.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=skraw@ithnet.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).