From: NIIBE Yutaka <gniibe@m17n.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Stephan von Krawczynski <skraw@ithnet.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client)
Date: Mon, 18 Mar 2002 18:33:29 +0900 (JST) [thread overview]
Message-ID: <200203180933.g2I9XTg07727@mule.m17n.org> (raw)
In-Reply-To: <shs8z8qb8c5.fsf@charged.uio.no>
Trond Myklebust wrote:
> Er... Why?
Because the inode could be on inode_unused, being still on the hash at
the client side, and server could reuse the inode (in case of
unfsd/ext3). When the inode will be reused for different type, it
will result error. Here is a scenario for non-patched 2.4.18:
(1) Symbolic link has been removed. The inode is put on inode_unused.
Say the inode # was 0x1234.
(2) Client issue "creat", server returns inode # 0x1234 (by the reuse).
(3) Call chain is:
nfs_create -> nfs_instantiate -> nfs_fhget -> __nfs_fhget -> iget4
iget4 returns the cached inode object on inode_unused.
(4) nfs_fill_inode doesn't fill it, because inode->i_mode is not 0.
(5) nfs_refresh_inode result error because inode->i_mode != fattr->mode.
Note that this is _real_ case.
> If you really want to change something in nfs_find_actor() then the
> following works better w.r.t. init_special_inode() on character
> devices:
>
> if ((inode->i_mode & S_IFMT) != (fattr->mode & S_IFMT))
> return 0;
Well, I've just tested this. This works well, thank you.
--
next prev parent reply other threads:[~2002-03-18 9:33 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-09 12:19 BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client) Stephan von Krawczynski
2002-03-09 19:10 ` Alan Cox
2002-03-10 17:50 ` Stephan von Krawczynski
2002-03-10 22:39 ` Trond Myklebust
2002-03-11 0:18 ` Stephan von Krawczynski
2002-03-11 0:28 ` Trond Myklebust
2002-03-11 6:14 ` Oleg Drokin
2002-03-11 10:46 ` Stephan von Krawczynski
2002-03-11 10:52 ` Oleg Drokin
2002-03-11 11:24 ` Stephan von Krawczynski
2002-03-11 12:47 ` Stephan von Krawczynski
2002-03-11 12:59 ` Oleg Drokin
2002-03-15 11:02 ` Stephan von Krawczynski
2002-03-15 11:13 ` Oleg Drokin
2002-03-15 11:30 ` Stephan von Krawczynski
2002-03-15 11:36 ` Sean Neakums
2002-03-15 11:37 ` Oleg Drokin
2002-03-15 12:03 ` Stephan von Krawczynski
2002-03-15 12:05 ` Oleg Drokin
2002-03-21 14:45 ` Stephan von Krawczynski
2002-03-21 14:57 ` Stephan von Krawczynski
2002-03-21 15:01 ` Oleg Drokin
2002-03-21 15:05 ` Stephan von Krawczynski
2002-03-21 15:07 ` Oleg Drokin
2002-03-21 17:15 ` Stephan von Krawczynski
2002-03-22 5:48 ` Oleg Drokin
2002-03-22 0:19 ` Trond Myklebust
2002-03-22 11:00 ` Stephan von Krawczynski
2002-03-22 11:07 ` Trond Myklebust
2002-03-22 13:19 ` Stephan von Krawczynski
2002-03-15 14:07 ` Stephan von Krawczynski
2002-03-11 14:48 ` Stephan von Krawczynski
2002-03-11 13:51 ` Oleg Drokin
2002-03-11 14:03 ` Trond Myklebust
2002-03-11 15:57 ` Stephan von Krawczynski
2002-03-11 16:31 ` Hans Reiser
2002-03-15 10:32 ` Oleg Drokin
2002-03-11 13:59 ` Trond Myklebust
2002-03-11 11:00 ` Stephan von Krawczynski
2002-03-11 11:11 ` Oleg Drokin
2002-03-18 7:07 ` NIIBE Yutaka
2002-03-18 8:15 ` Trond Myklebust
2002-03-18 9:33 ` NIIBE Yutaka [this message]
2002-03-18 9:56 ` Trond Myklebust
2002-03-18 23:57 ` NIIBE Yutaka
2002-03-19 14:45 ` Trond Myklebust
2002-03-20 0:42 ` NIIBE Yutaka
2002-03-20 8:30 ` Trond Myklebust
2002-03-19 15:42 ` Ton Hospel
2002-03-19 18:31 ` BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and Alan Cox
2002-03-19 22:10 ` BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client) Trond Myklebust
2002-03-22 10:33 ` David Woodhouse
2002-03-22 11:03 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200203180933.g2I9XTg07727@mule.m17n.org \
--to=gniibe@m17n.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skraw@ithnet.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).