From: NIIBE Yutaka <gniibe@m17n.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Stephan von Krawczynski <skraw@ithnet.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client)
Date: Wed, 20 Mar 2002 09:42:49 +0900 (JST) [thread overview]
Message-ID: <200203200042.g2K0gnL19526@mule.m17n.org> (raw)
In-Reply-To: <E16nKrq-0007uP-00@charged.uio.no>
While I agree that your argument is correct generally, what I'd like
to discuss is a specific technical concern with the _change_. Well,
you may have a big picture of NFS than me, so I just say my thought
here...
I attach the change (of my current version against 2.4.18) again, so
that we can focus the issue.
Here, the non-patched implementation checks inode correctness and
fails in:
nfs_refresh_inode: inode XXXXXXX mode changed, OOOO to OOOO
I think there is nothing to be useful in client side inode data, when
inode->i_count == 0. So, it doesn't make sense to check correctness
with this.
Provided the file handle is eternal thing, it doesn't fail...
IMO, it's no use to check the correctness for the inode when ->i_count == 0.
We can reuse the memory of the client side inode, that's true,
but we don't need to check old data against new one at that time.
BTW, I got positive feedback with this change.
2002-03-20 NIIBE Yutaka <gniibe@m17n.org>
* fs/nfs/inode.c (nfs_read_inode): Don't set inode->i_rdev here.
(nfs_fill_inode): But set it here, instead.
(nfs_find_actor): Reusing cached inode, clear ->i_mode.
--- fs/nfs/inode.c 19 Mar 2002 23:57:40 -0000 1.1.2.1
+++ fs/nfs/inode.c 20 Mar 2002 00:05:30 -0000
@@ -104,7 +104,6 @@ nfs_read_inode(struct inode * inode)
{
inode->i_blksize = inode->i_sb->s_blocksize;
inode->i_mode = 0;
- inode->i_rdev = 0;
/* We can't support UPDATE_ATIME(), since the server will reset it */
inode->i_flags |= S_NOATIME;
INIT_LIST_HEAD(&inode->u.nfs_i.read);
@@ -638,6 +637,7 @@ nfs_fill_inode(struct inode *inode, stru
* that's precisely what we have in nfs_file_inode_operations.
*/
inode->i_op = &nfs_file_inode_operations;
+ inode->i_rdev = 0;
if (S_ISREG(inode->i_mode)) {
inode->i_fop = &nfs_file_operations;
inode->i_data.a_ops = &nfs_file_aops;
@@ -679,7 +679,7 @@ nfs_find_actor(struct inode *inode, unsi
return 0;
/* Force an attribute cache update if inode->i_count == 0 */
if (!atomic_read(&inode->i_count))
- NFS_CACHEINV(inode);
+ inode->i_mode = 0;
return 1;
}
--
next prev parent reply other threads:[~2002-03-20 0:43 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-09 12:19 BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client) Stephan von Krawczynski
2002-03-09 19:10 ` Alan Cox
2002-03-10 17:50 ` Stephan von Krawczynski
2002-03-10 22:39 ` Trond Myklebust
2002-03-11 0:18 ` Stephan von Krawczynski
2002-03-11 0:28 ` Trond Myklebust
2002-03-11 6:14 ` Oleg Drokin
2002-03-11 10:46 ` Stephan von Krawczynski
2002-03-11 10:52 ` Oleg Drokin
2002-03-11 11:24 ` Stephan von Krawczynski
2002-03-11 12:47 ` Stephan von Krawczynski
2002-03-11 12:59 ` Oleg Drokin
2002-03-15 11:02 ` Stephan von Krawczynski
2002-03-15 11:13 ` Oleg Drokin
2002-03-15 11:30 ` Stephan von Krawczynski
2002-03-15 11:36 ` Sean Neakums
2002-03-15 11:37 ` Oleg Drokin
2002-03-15 12:03 ` Stephan von Krawczynski
2002-03-15 12:05 ` Oleg Drokin
2002-03-21 14:45 ` Stephan von Krawczynski
2002-03-21 14:57 ` Stephan von Krawczynski
2002-03-21 15:01 ` Oleg Drokin
2002-03-21 15:05 ` Stephan von Krawczynski
2002-03-21 15:07 ` Oleg Drokin
2002-03-21 17:15 ` Stephan von Krawczynski
2002-03-22 5:48 ` Oleg Drokin
2002-03-22 0:19 ` Trond Myklebust
2002-03-22 11:00 ` Stephan von Krawczynski
2002-03-22 11:07 ` Trond Myklebust
2002-03-22 13:19 ` Stephan von Krawczynski
2002-03-15 14:07 ` Stephan von Krawczynski
2002-03-11 14:48 ` Stephan von Krawczynski
2002-03-11 13:51 ` Oleg Drokin
2002-03-11 14:03 ` Trond Myklebust
2002-03-11 15:57 ` Stephan von Krawczynski
2002-03-11 16:31 ` Hans Reiser
2002-03-15 10:32 ` Oleg Drokin
2002-03-11 13:59 ` Trond Myklebust
2002-03-11 11:00 ` Stephan von Krawczynski
2002-03-11 11:11 ` Oleg Drokin
2002-03-18 7:07 ` NIIBE Yutaka
2002-03-18 8:15 ` Trond Myklebust
2002-03-18 9:33 ` NIIBE Yutaka
2002-03-18 9:56 ` Trond Myklebust
2002-03-18 23:57 ` NIIBE Yutaka
2002-03-19 14:45 ` Trond Myklebust
2002-03-20 0:42 ` NIIBE Yutaka [this message]
2002-03-20 8:30 ` Trond Myklebust
2002-03-19 15:42 ` Ton Hospel
2002-03-19 18:31 ` BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and Alan Cox
2002-03-19 22:10 ` BUG REPORT: kernel nfs between 2.4.19-pre2 (server) and 2.2.21-pre3 (client) Trond Myklebust
2002-03-22 10:33 ` David Woodhouse
2002-03-22 11:03 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200203200042.g2K0gnL19526@mule.m17n.org \
--to=gniibe@m17n.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skraw@ithnet.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).