From: John Levon <movement@marcelothewonderpenguin.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@sgi.com>,
bobm@fc.hp.com, phil.el@wanadoo.fr, torvalds@transmeta.com
Subject: Re: [PATCH][RFC] oprofile 2.5.38 patch
Date: Tue, 24 Sep 2002 13:23:57 +0100 [thread overview]
Message-ID: <20020924122357.GA52643@compsoc.man.ac.uk> (raw)
In-Reply-To: <20020924144838.A1144@sgi.com>
On Tue, Sep 24, 2002 at 02:48:38PM -0400, Christoph Hellwig wrote:
> [snip config bits]
Thanks.
> OTOH I wonder whether you really want an submenu. It could as well just
> be part of the general settings one.
I was a bit dubious it might be hard to find. It's not particularly
general ...
> Usually <foo>-objs is below obj-*, but that's just cosmetic. The Makefile
> inclusion seems very wrong to me. Why do you need it?
It's by far the simplest way to build the single module target...
> Shouldn't drivers/oprofile/i386/ be arch/i386/oprofile??
Perhaps. I kind of liked the code to be together. Also I wasn't sure how
I could convince kbuild to make a single target from the disparate dirs.
Kai mentioned that XFS does something similar, I'll look into that ...
> Why is this copyright different from the others?
Perils of very similar vim iab's ... fixed
> Why don't you just set no write method at all?
OK.
> Maybe oprofilefs wants to become a generic version, it has nothing
> oprofile-specific..
I don't know what you mean here. Do you mean hooking into driverfs ?
Last I checked it wasn't suitable for such oddball minifs's.
> Please use cond_syscall() and compile that file only for CONFIG_PROFILING set.
Ah, thanks.
> + struct dcookie_struct * d_cookie; /* cookie, if any */
>
> Make that conditional on CONFIG_PROFILING?
And same for the task_struct field. Will do.
> Put that exports into profile.c?
Sure.
thanks
john
next prev parent reply other threads:[~2002-09-24 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-23 22:29 [PATCH][RFC] oprofile 2.5.38 patch John Levon
2002-09-24 18:48 ` Christoph Hellwig
2002-09-24 12:23 ` John Levon [this message]
2002-09-26 16:08 ` Alan Cox
[not found] <20020923222933.GA33523@compsoc.man.ac.uk.suse.lists.linux.kernel>
2002-09-24 12:43 ` Andi Kleen
2002-09-24 12:55 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020924122357.GA52643@compsoc.man.ac.uk \
--to=movement@marcelothewonderpenguin.com \
--cc=bobm@fc.hp.com \
--cc=hch@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil.el@wanadoo.fr \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).