linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dipankar Sarma <dipankar@in.ibm.com>
To: William Lee Irwin III <wli@holomorphy.com>,
	"Martin J. Bligh" <mbligh@aracnet.com>,
	Zwane Mwaikambo <zwane@linuxpower.ca>,
	Andrew Morton <akpm@digeo.com>,
	lkml <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: 2.5.38-mm3
Date: Sat, 28 Sep 2002 11:11:03 +0530	[thread overview]
Message-ID: <20020928111103.C32125@in.ibm.com> (raw)
In-Reply-To: <20020927225455.GW22942@holomorphy.com>; from wli@holomorphy.com on Fri, Sep 27, 2002 at 03:54:55PM -0700

On Fri, Sep 27, 2002 at 03:54:55PM -0700, William Lee Irwin III wrote:
> On Fri, Sep 27, 2002 at 10:44:24PM +0530, Dipankar Sarma wrote:
> > Not sure why it shows up more in -mm, but likely because -mm has
> > lot less contention on other locks like dcache_lock.
> 
> Well, the profile I posted was an interactive UP workload, and it's
> fairly high there. Trimming cycles off this is good for everyone.

Oh, I was commenting on possible files_lock contention on mbligh's
NUMA-Q.

> 
> Small SMP boxen (dual?) used similarly will probably see additional
> gains as the number of locked operations in fget() will be reduced.
> There's clearly no contention or cacheline bouncing in my workloads as
> none of them have tasks sharing file tables, nor is anything else
> messing with the cachelines.

I remember seeing fget() high up in specweb profiles. I suspect that
fget profile count is high because it just happens to get called very 
often for most workloads (all file syscalls) and the atomic 
operations (SMP) and the function call overhead just adds to the cost. 
If possible, we should try inlining it too.

Thanks
-- 
Dipankar Sarma  <dipankar@in.ibm.com> http://lse.sourceforge.net
Linux Technology Center, IBM Software Lab, Bangalore, India.

  reply	other threads:[~2002-09-28  5:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-26  7:57 2.5.38-mm3 Andrew Morton
2002-09-26 12:24 ` 2.5.38-mm3 Dipankar Sarma
2002-09-26 12:29   ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 12:40     ` 2.5.38-mm3 Dipankar Sarma
2002-09-26 12:42       ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 13:05         ` 2.5.38-mm3 Dipankar Sarma
2002-09-26 13:17           ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 13:29         ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-26 13:39           ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 13:46             ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-27  8:27             ` 2.5.38-mm3 Dipankar Sarma
2002-09-27  9:20               ` 2.5.38-mm3 William Lee Irwin III
2002-09-27  9:58                 ` 2.5.38-mm3 Dipankar Sarma
2002-09-27 15:04                   ` 2.5.38-mm3 Martin J. Bligh
2002-09-27 17:14                     ` 2.5.38-mm3 Dipankar Sarma
2002-09-27 22:54                       ` 2.5.38-mm3 William Lee Irwin III
2002-09-28  5:41                         ` Dipankar Sarma [this message]
2002-09-28  4:35                   ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-28  4:36                     ` 2.5.38-mm3 William Lee Irwin III
2002-09-28  4:54                       ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-28  5:29                         ` 2.5.38-mm3 Dipankar Sarma
2002-09-28  4:30                 ` 2.5.38-mm3 Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020928111103.C32125@in.ibm.com \
    --to=dipankar@in.ibm.com \
    --cc=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@aracnet.com \
    --cc=wli@holomorphy.com \
    --cc=zwane@linuxpower.ca \
    --subject='Re: 2.5.38-mm3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).