[PATCH] default file permission for vfat

[PATCH] default file permission for vfat

[Miroslav Rudisin]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

Hi,

The attached patch change default permission of files on [v]fatfs.
Default RWX have no utilization. This patch remove exec flag.

2.4.19 & 2.5.30

Thanks

--
Miroslav Rudisin


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 462 bytes --]

--- inode.c.orig	Mon Aug  5 21:56:01 2002
+++ inode.c	Mon Aug  5 21:58:32 2002
@@ -932,8 +932,8 @@
 		inode->i_generation |= 1;
 		inode->i_mode = MSDOS_MKMODE(de->attr,
 		    ((sbi->options.showexec &&
-		       !is_exec(de->ext))
-		    	? S_IRUGO|S_IWUGO : S_IRWXUGO)
+		       is_exec(de->ext))
+		    	? S_IRWXUGO : S_IRUGO|S_IWUGO)
 		    & ~sbi->options.fs_umask) | S_IFREG;
 		MSDOS_I(inode)->i_start = CF_LE_W(de->start);
 		if (sbi->fat_bits == 32) {

Re: [PATCH] default file permission for vfat

[Willy Tarreau]

On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> Hi,
> 
> The attached patch change default permission of files on [v]fatfs.
> Default RWX have no utilization. This patch remove exec flag.

Hi !

This is sometimes very useful to put init scripts on a floppy disk. I'd
prefer to keep exec flags. If you don't want files to be executable, you
still can mount the FS with the 'noexec' option.

Cheers,
Willy

Re: [PATCH] default file permission for vfat

[Padraig Brady]

Willy Tarreau wrote:
> On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> 
>>Hi,
>>
>>The attached patch change default permission of files on [v]fatfs.
>>Default RWX have no utilization. This patch remove exec flag.
> 
> Hi !
> 
> This is sometimes very useful to put init scripts on a floppy disk.

Not the common case and you can use different format floppies for this anyway.

 > I'd prefer to keep exec flags. If you don't want files to be executable, you
> still can mount the FS with the 'noexec' option.

Not since: http://www.uwsg.iu.edu/hypermail/linux/kernel/0109.3/0363.html
Ideal would be to have a umask and dmask option (that applied to everything
not just vfat)

See also: http://kt.zork.net/kernel-traffic/kt20020415_162.html#1

Pádraig.

Re: [PATCH] default file permission for vfat

[Willy Tarreau]

On Wed, Oct 02, 2002 at 10:02:48AM +0100, Padraig Brady wrote:
> Willy Tarreau wrote:
> >On Tue, Oct 01, 2002 at 07:39:08PM +0200, Miroslav Rudisin wrote:
> >
> >>Hi,
> >>
> >>The attached patch change default permission of files on [v]fatfs.
> >>Default RWX have no utilization. This patch remove exec flag.
> >
> >Hi !
> >
> >This is sometimes very useful to put init scripts on a floppy disk.
> 
> Not the common case and you can use different format floppies for this 
> anyway.

not when you want your customers to be able to edit their firewall config
with their M$ PC !

Willy

Re: [PATCH] default file permission for vfat

[GOMBAS Gabor]

On Wed, Oct 02, 2002 at 11:46:12AM +0200, Willy Tarreau wrote:

> not when you want your customers to be able to edit their firewall config
> with their M$ PC !

Copy them to tmpfs, do "chmod +x", execute them.

Gabor

-- 
Gabor Gombas                                       Eotvos Lorand University
E-mail: gombasg@inf.elte.hu                        Hungary

Re: [PATCH] default file permission for vfat

[Stas Sergeev]

Hello.

Miroslav Rudisin wrote:
> The attached patch change default permission of files on [v]fatfs. 
> Default RWX have no utilization. This patch remove exec flag. 
Thank you very much!
Since the "noexec" option was broken, this
patch is extremely usefull.
I would like to see it included, but, as I
don't know the details, I pretend to say nothing
except that it is very usefull for me.