[patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[Francois Romieu]

drivers/atm/iphase.c:tx_intr()
[...]
   1684            spin_lock_irqsave(&iadev->tx_lock, flags);
   1685            ia_tx_poll(iadev);

ia_tx_poll ->
 ia_hack_tcq ->
  ia_enque_rtn_q ->
   IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);

Driver does not seem maintained. Please apply.

--- linux-2.4.20-pre9.orig/drivers/atm/iphase.c	Sat Oct  5 15:51:28 2002
+++ linux-2.4.20-pre9/drivers/atm/iphase.c	Sat Oct  5 22:44:18 2002
@@ -124,7 +124,7 @@ static void ia_enque_head_rtn_q (IARTN_Q
 }
 
 static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
-   IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
+   IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
    if (!entry) return -1;
    entry->data = data;
    entry->next = NULL;

Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[Marcelo Tosatti]

On Sat, 5 Oct 2002, Francois Romieu wrote:

> drivers/atm/iphase.c:tx_intr()
> [...]
>    1684            spin_lock_irqsave(&iadev->tx_lock, flags);
>    1685            ia_tx_poll(iadev);
>
> ia_tx_poll ->
>  ia_hack_tcq ->
>   ia_enque_rtn_q ->
>    IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
>
> Driver does not seem maintained. Please apply.
>
> --- linux-2.4.20-pre9.orig/drivers/atm/iphase.c	Sat Oct  5 15:51:28 2002
> +++ linux-2.4.20-pre9/drivers/atm/iphase.c	Sat Oct  5 22:44:18 2002
> @@ -124,7 +124,7 @@ static void ia_enque_head_rtn_q (IARTN_Q
>  }
>
>  static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
> -   IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
> +   IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
>     if (!entry) return -1;
>     entry->data = data;
>     entry->next = NULL;

It seems correct. Have you tried to send this to Peter Wang
<pwang@iphase.com> ?

Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[Francois Romieu]

Marcelo Tosatti <marcelo@conectiva.com.br> :
[...]
> It seems correct. Have you tried to send this to Peter Wang
> <pwang@iphase.com> ?

Not this one. Last try was something like:

[...]
The original message was received at Sat, 13 Jul 2002 10:37:02 -0500 (CDT)
from uucp@localhost

   ----- The following addresses had permanent fatal errors -----
<pwang@iphase.com>
    (reason: 550 <pwang@iphase.com>... User unknown)

-- 
Ueimor

Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[Adrian Bunk]

On Tue, 8 Oct 2002, Francois Romieu wrote:

> Marcelo Tosatti <marcelo@conectiva.com.br> :
> [...]
> > It seems correct. Have you tried to send this to Peter Wang
> > <pwang@iphase.com> ?
>
> Not this one. Last try was something like:
>...

Mitchell Blank Jr <mitch@sfgoth.com> is the current ATM maintainer, could
you try to contact him?

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox

Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held

[Francois Romieu]

[cc trimmed]

Adrian Bunk <bunk@fs.tum.de> :
[...]
> Mitchell Blank Jr <mitch@sfgoth.com> is the current ATM maintainer, could
> you try to contact him?

Just bounced.

-- 
Ueimor