* Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u
@ 2003-04-09 22:10 Chuck Ebbert
2003-04-10 1:48 ` carbonated beverage
0 siblings, 1 reply; 6+ messages in thread
From: Chuck Ebbert @ 2003-04-09 22:10 UTC (permalink / raw)
To: Justin T. Gibbs, linux-kernel
>1) You don't trust maintainers. If a maintainer can't make large
>changes, who can?
I was wondering about that too.
How can a major code restructure be done in tiny pieces? I don't
think it can.
--
Chuck
I am not an octal number!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u
2003-04-09 22:10 [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u Chuck Ebbert
@ 2003-04-10 1:48 ` carbonated beverage
0 siblings, 0 replies; 6+ messages in thread
From: carbonated beverage @ 2003-04-10 1:48 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Justin T. Gibbs, linux-kernel
Hi,
On Wed, Apr 09, 2003 at 06:10:02PM -0400, Chuck Ebbert wrote:
> How can a major code restructure be done in tiny pieces? I don't
> think it can.
You might want to tell that to Al Viro. ;-)
-- DN
Daniel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u
2003-04-09 11:13 ` Alan Cox
@ 2003-04-09 17:34 ` Justin T. Gibbs
0 siblings, 0 replies; 6+ messages in thread
From: Justin T. Gibbs @ 2003-04-09 17:34 UTC (permalink / raw)
To: Alan Cox, Chuck Ebbert; +Cc: Linux Kernel Mailing List
> On Mer, 2003-04-09 at 02:21, Chuck Ebbert wrote:
>> And your code goes for long periods of time without merging good fixes,
>> like this one (from 2.4.20):
>
> Which is one reason Justin's patches don't get merged. They are giant
> changes which back out other clear corrections.
This tells me two things:
1) You don't trust maintainers. If a maintainer can't make large changes,
who can?
2) When a maintainer makes a mistake (fails to integrate a good change,
or introduces a bug), the maintainers changes are simply dropped rather
then notify (either politely or not I don't much care) the maintainer
of his/her mistake.
Neither of the above applied to integration of the aic79xx driver into
the 2.4.X tree, but it still took something like 8 months.
There must be a better way.
--
Justin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u
2003-04-09 1:21 Chuck Ebbert
2003-04-09 2:13 ` Justin T. Gibbs
@ 2003-04-09 11:13 ` Alan Cox
2003-04-09 17:34 ` Justin T. Gibbs
1 sibling, 1 reply; 6+ messages in thread
From: Alan Cox @ 2003-04-09 11:13 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Justin T. Gibbs, Linux Kernel Mailing List
On Mer, 2003-04-09 at 02:21, Chuck Ebbert wrote:
> And your code goes for long periods of time without merging good fixes,
> like this one (from 2.4.20):
Which is one reason Justin's patches don't get merged. They are giant
changes which back out other clear corrections.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u
2003-04-09 1:21 Chuck Ebbert
@ 2003-04-09 2:13 ` Justin T. Gibbs
2003-04-09 11:13 ` Alan Cox
1 sibling, 0 replies; 6+ messages in thread
From: Justin T. Gibbs @ 2003-04-09 2:13 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: linux-kernel
> And your code goes for long periods of time without merging good fixes,
> like this one (from 2.4.20):
If I were aware of this bug, it would have been merged. Unfortunately,
the Linux model where maintainers are not consulted before changes are
accepted leads to good changes getting missed and bad changes get accepted.
--
Justin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u
@ 2003-04-09 1:21 Chuck Ebbert
2003-04-09 2:13 ` Justin T. Gibbs
2003-04-09 11:13 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: Chuck Ebbert @ 2003-04-09 1:21 UTC (permalink / raw)
To: Justin T. Gibbs; +Cc: linux-kernel
Justin T. Gibbs wrote:
>As far as the 2.4.X series is concerned, pushing has not helped. I've
>seen spelling fixes and incorrorct changes get accepted from non
>maintainers "instantly", while the maintainers changes are not accepted.
And your code goes for long periods of time without merging good fixes,
like this one (from 2.4.20):
--- aic7-20030310/drivers/scsi/aic7xxx/aic7770.c.orig Mon Mar 10 20:46:36 2003
+++ aic7-20030310/drivers/scsi/aic7xxx/aic7770.c Tue Apr 8 20:45:20 2003
@ -314,7 +314,7 @
if (bootverbose)
printf("%s: Reading SEEPROM...", ahc_name(ahc));
have_seeprom = ahc_read_seeprom(&sd, (uint16_t *)sc,
- /*start_addr*/0, sizeof(sc)/2);
+ /*start_addr*/0, sizeof(*sc)/2);
if (have_seeprom) {
--
Chuck
Can't we all just get along?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-04-10 1:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-04-09 22:10 [PATCH] aic7* claims all checked EISA io ranges (was: [MAILER-DAEMON@rumms.u Chuck Ebbert
2003-04-10 1:48 ` carbonated beverage
-- strict thread matches above, loose matches on Subject: below --
2003-04-09 1:21 Chuck Ebbert
2003-04-09 2:13 ` Justin T. Gibbs
2003-04-09 11:13 ` Alan Cox
2003-04-09 17:34 ` Justin T. Gibbs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).