From: viro@parcelfarce.linux.theplanet.co.uk
To: Frank Cusack <fcusack@fcusack.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
torvalds@transmeta.com, marcelo@conectiva.com.br,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfs_unlink() race (was: nfs_refresh_inode: inode number mismatch)
Date: Wed, 11 Jun 2003 02:47:17 +0100 [thread overview]
Message-ID: <20030611014717.GB6754@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030610182824.A18280@google.com>
On Tue, Jun 10, 2003 at 06:28:24PM -0700, Frank Cusack wrote:
> On Wed, Jun 11, 2003 at 01:54:25AM +0100, viro@parcelfarce.linux.theplanet.co.uk wrote:
> > On Mon, Jun 09, 2003 at 06:51:41AM -0700, Frank Cusack wrote:
> >
> > > When foo is unlinked, nfs_unlink() does a sillyrename, this puts the
> > > dentry on nfs_delete_queue, and (in the VFS) unhashes it from the dcache.
> > > This causes a problem, because dentry->d_parent->d_inode is now guaranteed
> > > to remain stale. (OK, I'm not really sure about this last part.)
> >
> > ????
> >
> > What does hashed state have to ->d_parent?
>
> Because now d_parent can be d_deleted (no children) and then go away.
Why? It still has our dentry refering to it and contributing into its
->d_count.
> Then won't dentry->d_parent be wrong? What happens if d_parent becomes
> a negative d_entry v. disappearing entirely.
->d_parent will not become negative.
> It is if d_count goes to 0 on one of them and the inode is then unlinked.
> But the other dentry remains and again tries to unlink when its d_count
> goes to 0. Over NFS the fh includes the generation and so you can't
> accidentally delete what only looks like the same file, but what happens
> in the local fs?
Please, take a look at the way normal links work.
> Also, the real problem is that something goes wrong with d_parent and
Now, _that_ is interesting. What are you actually seeing there?
Note that unhashing doesn't change _any_ ->d_count - hash chains
are not counted in it and ->d_parent is not changed.
> NFS tries to refresh an inode that it should really know doesn't exist
> anymore. That's why my #2 patch only executes during a rmdir.
next prev parent reply other threads:[~2003-06-11 1:33 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 23:54 nfs_refresh_inode: inode number mismatch Frank Cusack
2003-06-04 14:19 ` Trond Myklebust
2003-06-04 21:20 ` Frank Cusack
2003-06-04 21:28 ` Trond Myklebust
2003-06-09 13:51 ` [PATCH] nfs_unlink() race (was: nfs_refresh_inode: inode number mismatch) Frank Cusack
2003-06-09 13:55 ` Frank Cusack
2003-06-09 15:53 ` Linus Torvalds
2003-06-09 16:40 ` Trond Myklebust
2003-06-09 20:46 ` Frank Cusack
2003-06-10 0:01 ` Trond Myklebust
2003-06-11 0:54 ` viro
2003-06-11 1:28 ` Frank Cusack
2003-06-11 1:47 ` viro [this message]
2003-06-11 2:32 ` Frank Cusack
2003-06-11 2:37 ` viro
2003-06-11 1:59 ` Trond Myklebust
2003-06-11 2:27 ` viro
2003-06-11 2:43 ` Frank Cusack
2003-06-11 2:50 ` Frank Cusack
2003-06-11 3:00 ` viro
2003-06-11 7:22 ` [PATCH] NFS sillyrename fixes (was: [PATCH] nfs_unlink() race) Frank Cusack
2003-06-13 0:19 ` [PATCH] NFS sillyrename fixes take 3 Frank Cusack
2003-06-11 3:00 ` [PATCH] nfs_unlink() race (was: nfs_refresh_inode: inode number mismatch) Trond Myklebust
2003-06-11 5:30 ` Linus Torvalds
2003-06-11 6:16 ` Andreas Dilger
2003-06-11 12:33 ` Alan Cox
2003-06-11 15:08 ` Linus Torvalds
2003-06-11 15:51 ` Alan Cox
2003-06-11 16:11 ` Linus Torvalds
2003-06-11 16:21 ` Alan Cox
2003-06-11 16:31 ` Linus Torvalds
2003-06-11 16:34 ` viro
2003-06-11 17:22 ` Alan Cox
2003-06-11 17:37 ` Trond Myklebust
2003-06-11 17:47 ` Trond Myklebust
2003-06-12 21:59 ` Jan Harkes
[not found] ` <16103.29804.198545.680701@charged.uio.no>
2003-06-11 22:24 ` Frank Cusack
2003-06-11 23:16 ` Trond Myklebust
2003-06-11 23:35 ` [PATCH] nfs_unlink() race Frank Cusack
2003-06-05 9:11 ` nfs_refresh_inode: inode number mismatch Adrian Cox
2003-06-05 9:13 ` Russell King
2003-06-05 13:51 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030611014717.GB6754@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=fcusack@fcusack.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).