* [PATCH] AES for CryptoAPI - i586-optimized
@ 2003-07-08 15:27 Fruhwirth Clemens
2003-07-08 16:49 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Fruhwirth Clemens @ 2003-07-08 15:27 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Due to the recent discussion about the asm-optimized version of AES which is
included in loop-AES, I'd like to point out that I've ported this
implementation - Dr. Brian Gladman's btw. - to CryptoAPI a long time ago.
http://therapy.endorphin.org/patches/aes-i586-asm-2.5.58.diff
The demand for this patch will rise quickly if cryptoloop is included :)
Regards, Clemens
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] AES for CryptoAPI - i586-optimized
2003-07-08 15:27 [PATCH] AES for CryptoAPI - i586-optimized Fruhwirth Clemens
@ 2003-07-08 16:49 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2003-07-08 16:49 UTC (permalink / raw)
To: linux-kernel
On Tue, Jul 08, 2003 at 05:27:55PM +0200, Fruhwirth Clemens wrote:
>
> Due to the recent discussion about the asm-optimized version of AES which is
> included in loop-AES, I'd like to point out that I've ported this
> implementation - Dr. Brian Gladman's btw. - to CryptoAPI a long time ago.
Cool, that means we just need to hash out the framework for optimized
implementations now..
A few more comments:
> diff -r --new-file -u crypto/Kconfig ../linux-2.5.58/crypto/Kconfig
> --- crypto/Kconfig Thu Feb 6 13:53:47 2003
> +++ ../linux-2.5.58/crypto/Kconfig Tue Feb 4 00:54:18 2003
> @@ -119,6 +119,26 @@
>
> See http://csrc.nist.gov/encryption/aes/ for more information.
>
> +config CRYPTO_AES_586
> + tristate "AES cipher algorithms (586)"
> + depends on CRYPTO
Should also depend on CONFIG_X86 && !CONFIG_X86_64
> +$(obj)/aes-i586.o: $(obj)/aes-i586-asm.o crypto/aes-i586-glue.o
> + $(LD) -r $(obj)/aes-i586-asm.o $(obj)/aes-i586-glue.o -o $(obj)/aes-i586.o
That's not how kernel makesfile work. It should be something like
aes-i586-y := aes-i586-asm.o aes-i586-glue.o
> +// THE CIPHER INTERFACE
Please use C-style comments.
> + if(key_length != 16 && key_length != 24 && key_length != 32)
> + {
Should be
if (key_length != 16 && key_length != 24 && key_length != 32) {
> +MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
> +MODULE_LICENSE("Dual BSD/GPL");
MODULE_AUTHOR is missing. Also the description should mention that
this is an optimized assembly version.
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20030708152755.GA24331@ghanima.endorphin.org.suse.lists.linux.kernel>]
* Re: [PATCH] AES for CryptoAPI - i586-optimized
@ 2003-07-22 1:17 Jason Papadopoulos
0 siblings, 0 replies; 6+ messages in thread
From: Jason Papadopoulos @ 2003-07-22 1:17 UTC (permalink / raw)
To: linux-kernel
> There already is an example for optimized variants - the z990
implementation.
>
> -Andi
My Master's thesis involved developing custom AES implementations
for the Alpha EV6, UltraSPARC, and P3.
www.boo.net/~jasonp
Source is included, but only the encrypt was implemented.
Hope this helps,
jasonp
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-07-22 0:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-08 15:27 [PATCH] AES for CryptoAPI - i586-optimized Fruhwirth Clemens
2003-07-08 16:49 ` Christoph Hellwig
[not found] <20030708152755.GA24331@ghanima.endorphin.org.suse.lists.linux.kernel>
[not found] ` <20030708174907.A18997@infradead.org.suse.lists.linux.kernel>
2003-07-08 17:12 ` Andi Kleen
2003-07-08 17:28 ` Jeff Garzik
2003-07-08 19:16 ` Andi Kleen
2003-07-22 1:17 Jason Papadopoulos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).