From: Jens Axboe <axboe@suse.de> To: Bernardo Innocenti <bernie@develer.com> Cc: Andrew Morton <akpm@osdl.org>, hch@infradead.org, willy@w.ods.org, hch@lst.de, uclinux-dev@uclinux.org, linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk Subject: Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase) Date: Sun, 27 Jul 2003 01:41:18 +0200 [thread overview] Message-ID: <20030726234118.GB1170@suse.de> (raw) In-Reply-To: <200307270142.47602.bernie@develer.com> On Sun, Jul 27 2003, Bernardo Innocenti wrote: > On Saturday 26 July 2003 16:07, Jens Axboe wrote: > > > > /* > > > * linux/drivers/block/as-iosched.c > > > * > > > - * Anticipatory & deadline i/o scheduler. > > > + * Anticipatory i/o scheduler. > > > * > > > * Copyright (C) 2002 Jens Axboe <axboe@suse.de> > > > * Nick Piggin <piggin@cyberone.com.au> > > > > Huh? What is that about? AS is deadline + anticipation. Good rule is not > > to make comment changes when you don't know your changes to be a fact. > > Oops, I thought it was done by mistake :-) > > By the way, this comment in as-iosched.c refers to a missing file: > > /* > * See Documentation/as-iosched.txt > */ Hmm odd, maybe it never got migrated from Andrews tree. > Another issue: to make the I/O schedulers configurable, I had to > fiddle with ll_rw_blk.c, makiing it slightly harder to understand. Don't worry, the current addon of additional schedulers is crap already, so your patch has to deal with that. The real modular schedulers will change this, removing the nasty bits that are there know. It doesn't even belong in ll_rw_blk.c > > About making it selectable, I'm fine with it. Please send an updated > > patch. > > Here it is: Thanks -- Jens Axboe
next prev parent reply other threads:[~2003-07-26 23:42 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2003-07-23 18:46 Kernel 2.6 size increase Bernardo Innocenti 2003-07-23 19:14 ` Richard B. Johnson 2003-07-23 20:07 ` David S. Miller 2003-07-23 21:47 ` Randy.Dunlap 2003-07-23 19:32 ` [uClinux-dev] " Christoph Hellwig 2003-07-23 20:11 ` David S. Miller 2003-07-23 20:15 ` Christoph Hellwig 2003-07-23 20:22 ` David S. Miller 2003-07-23 20:27 ` Christoph Hellwig 2003-07-23 22:35 ` [uClinux-dev] Kernel 2.6 size increase - get_current()? Bernardo Innocenti 2003-07-23 22:37 ` Alan Cox 2003-07-23 23:00 ` Bernardo Innocenti 2003-07-24 5:06 ` David McCullough 2003-07-24 11:28 ` Alan Cox 2003-07-24 12:04 ` David McCullough 2003-07-24 14:48 ` Alan Cox 2003-07-25 18:25 ` bill davidsen 2003-07-24 15:30 ` Hollis Blanchard 2003-07-24 19:37 ` Alan Cox 2003-07-24 19:51 ` Hollis Blanchard 2003-07-24 21:20 ` J.A. Magallon 2003-07-25 4:22 ` Otto Solares 2003-07-25 14:38 ` Hollis Blanchard 2003-07-28 3:19 ` Miles Bader 2003-07-28 8:14 ` Ihar "Philips" Filipau 2003-07-28 8:58 ` Miles Bader 2003-07-28 9:03 ` Ihar "Philips" Filipau 2003-07-23 21:57 ` [uClinux-dev] Kernel 2.6 size increase Bernardo Innocenti 2003-07-23 22:07 ` Bernardo Innocenti 2003-07-23 22:27 ` Willy Tarreau 2003-07-23 22:34 ` Alan Cox 2003-07-24 20:27 ` Bernardo Innocenti 2003-07-25 15:46 ` Christoph Hellwig 2003-07-25 23:55 ` [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase) Bernardo Innocenti 2003-07-26 8:17 ` Andrew Morton 2003-07-26 12:40 ` Bernardo Innocenti 2003-07-26 14:07 ` Jens Axboe 2003-07-26 23:42 ` Bernardo Innocenti 2003-07-26 23:41 ` Jens Axboe [this message] 2003-07-28 17:13 ` [uClinux-dev] Kernel 2.6 size increase Nicolas Pitre 2003-07-28 23:02 ` Bernardo Innocenti 2003-07-29 2:36 ` Miles Bader 2003-08-08 13:25 ` [uClinux-dev] " David Woodhouse 2003-08-08 14:37 ` Bernardo Innocenti 2003-08-08 14:43 ` David Woodhouse 2003-07-25 18:16 ` bill davidsen 2003-07-29 22:29 ` Tom Rini 2003-07-29 22:48 ` Alan Cox 2003-07-29 23:06 ` Tom Rini 2003-07-30 2:07 ` Miles Bader 2003-07-30 15:33 ` Tom Rini 2003-07-31 1:49 ` Miles Bader 2003-07-31 4:17 ` Tom Rini 2003-07-31 5:03 ` Miles Bader 2003-07-31 15:24 ` Tom Rini 2003-07-30 2:49 ` [uClinux-dev] " Bernardo Innocenti 2003-07-30 15:35 ` Tom Rini 2003-07-30 16:45 ` [uClinux-dev] Kernel 2.6 size increase (PATCH) Bernardo Innocenti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20030726234118.GB1170@suse.de \ --to=axboe@suse.de \ --cc=akpm@osdl.org \ --cc=alan@lxorguk.ukuu.org.uk \ --cc=bernie@develer.com \ --cc=hch@infradead.org \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=uclinux-dev@uclinux.org \ --cc=willy@w.ods.org \ --subject='Re: [PATCH] Make I/O schedulers optional (Was: Re: Kernel 2.6 size increase)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).