linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikael Pettersson <mikpe@csd.uu.se>
To: alan@lxorguk.ukuu.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: time for some drivers to be removed?
Date: Tue, 5 Aug 2003 14:42:28 +0200 (MEST)	[thread overview]
Message-ID: <200308051242.h75CgSj6028203@harpo.it.uu.se> (raw)

On 27 Jul 2003 21:56:11 +0100, Alan Cox wrote:
> On Sul, 2003-07-27 at 21:56, Adrian Bunk wrote:
> > That's no problem for me.
> > 
> > The only question is how to call the option that allows building only on
> > UP (e.g. cli/sti usage in the driver)? My suggestion was BROKEN_ON_SMP,
> > would you suggest OBSOLETE_ON_SMP?
> 
> Interesting question - whatever I guess. We don't have an existing convention.
> How many drivers have we got nowdays that failing on just SMP ?

ftape fails on SMP due to sti/save_flags/restore_flags removal.

My .config:

CONFIG_SMP=y
...
CONFIG_FTAPE=m
CONFIG_ZFTAPE=m
...
# CONFIG_FT_STD_FDC is not set
# CONFIG_FT_MACH2 is not set
# CONFIG_FT_PROBE_FC10 is not set
CONFIG_FT_ALT_FDC=y

#
# Consult the manuals of your tape drive for the correct settings!
#
CONFIG_FT_FDC_BASE=0x360
CONFIG_FT_FDC_IRQ=6
CONFIG_FT_FDC_DMA=2
CONFIG_FT_ALPHA_CLOCK=0

And the warnings:

drivers/char/ftape/lowlevel/fdc-io.c: In function `fdc_command':
drivers/char/ftape/lowlevel/fdc-io.c:221: warning: implicit declaration of function `restore_flags'
drivers/char/ftape/lowlevel/fdc-isr.c: In function `fdc_isr':
drivers/char/ftape/lowlevel/fdc-isr.c:1094: warning: implicit declaration of function `sti'
drivers/char/ftape/lowlevel/ftape-io.c: In function `ftape_sleep':
drivers/char/ftape/lowlevel/ftape-io.c:97: warning: implicit declaration of function `save_flags'
drivers/char/ftape/lowlevel/ftape-io.c:98: warning: implicit declaration of function `sti'
drivers/char/ftape/lowlevel/ftape-io.c:112: warning: implicit declaration of function `restore_flags'
drivers/char/ftape/lowlevel/ftape-format.c: In function `ftape_format_track':
drivers/char/ftape/lowlevel/ftape-format.c:135: warning: implicit declaration of function `restore_flags'
*** Warning: "sti" [drivers/char/ftape/lowlevel/ftape.ko] undefined!
*** Warning: "save_flags" [drivers/char/ftape/lowlevel/ftape.ko] undefined!
*** Warning: "restore_flags" [drivers/char/ftape/lowlevel/ftape.ko] undefined!

I have the HW so I can test patches if someone feels like fixing this.

/Mikael

             reply	other threads:[~2003-08-05 12:43 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-05 12:42 Mikael Pettersson [this message]
2003-08-05 13:03 ` Adrian Bunk
2003-08-05 13:35   ` Mikael Pettersson
2003-08-05 13:48     ` Adrian Bunk
2003-08-05 14:01       ` Mikael Pettersson
2003-08-06 10:06         ` Claus-Justus Heine
2003-08-09 19:40           ` Adrian Bunk
2003-08-05 16:35 ` Alan Cox
2003-08-05 18:47   ` Leopold Gouverneur
  -- strict thread matches above, loose matches on Subject: below --
2003-08-14  5:34 John Bradford
2003-08-13 20:55 John Bradford
2003-08-13 20:50 ` Adrian Bunk
2003-08-13 20:55 ` Bill Davidsen
2003-07-28  7:12 linux
2003-07-27 16:22 John Bradford
2003-07-25 11:10 John Bradford
2003-07-24 18:29 John Bradford
2003-07-24 18:31 ` Robert P. J. Day
2003-07-24 19:31   ` Eli Carter
2003-07-25 10:48 ` Bas Mevissen
2003-07-24 14:43 John Bradford
2003-07-24 19:24 ` Brian Jackson
2003-07-24 12:20 Robert P. J. Day
2003-07-24 14:58 ` Alan Cox
2003-07-24 15:34   ` Bas Mevissen
2003-07-24 17:32     ` Diego Calleja García
2003-07-24 17:50       ` Robert P. J. Day
2003-07-24 19:16         ` Diego Calleja García
2003-07-24 19:43           ` Robert P. J. Day
2003-07-24 18:02       ` Samuel Flory
2003-07-24 19:07     ` Alan Cox
2003-07-25 10:48       ` Bas Mevissen
2003-07-27 15:31 ` Adrian Bunk
2003-07-27 15:59   ` David D. Hagood
2003-07-27 16:18     ` Adrian Bunk
2003-07-27 16:40     ` Alan Cox
2003-07-27 17:00       ` Adrian Bunk
2003-07-27 18:45       ` David D. Hagood
2003-07-27 20:40         ` Alan Cox
2003-07-27 20:56           ` Adrian Bunk
2003-07-27 20:56             ` Alan Cox
2003-07-28  2:23               ` Herbert Pötzl
2003-07-29 19:33               ` Adrian Bunk
2003-08-13 20:16                 ` Bill Davidsen
2003-08-09 18:04   ` David Woodhouse
2003-08-09 19:36     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200308051242.h75CgSj6028203@harpo.it.uu.se \
    --to=mikpe@csd.uu.se \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: time for some drivers to be removed?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).