From: Erik Andersen <andersen@codepoet.org>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Andries Brouwer <aebr@win.tue.nl>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ide-disk.c rev 1.13 killed CONFIG_IDEDISK_STROKE
Date: Wed, 6 Aug 2003 13:30:58 -0600 [thread overview]
Message-ID: <20030806193058.GA27207@codepoet.org> (raw)
In-Reply-To: <Pine.SOL.4.30.0308062024180.10247-300000@mion.elka.pw.edu.pl>
On Wed Aug 06, 2003 at 08:32:23PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On Wed, 6 Aug 2003, Erik Andersen wrote:
>
> > > Can you please resend me the patch once its accepted in 2.6 ?
> > >
> > > Maybe we want to test it a while in -ac, also?
> >
> > Ok. Though it is being incorporated as part of a much larger
> > patch in 2.6. I suppose that will filter back into 2.4 when
> > it is ready,
>
> Hi Erik,
>
> I made init_idedisk_capacity() cleanup.
> Then I ported your patch and reworked it a bit.
>
> Could you take a look?
I like your improvements. The only concern I have is you
retained my use of do_div() intact. That needs to change since
it turns out that do_div() directly modifies the numerator
(violating the principle of least surprise). See the recent
thread on "do_div considered harmful". In that thread, Andries
mentions he has made a generic sectors_to_MB() function to
consolidate such things. which I think is a very good idea since
then this only has to be correct once. That would also let you
eliminate the somewhat ugly and not particularly obvious division
plus rounding (X - X/625 + 974)/1950 sequence from
idedisk_check_hpa_lba28(),
-Erik
--
Erik B. Andersen http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--
next prev parent reply other threads:[~2003-08-06 19:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030806181142.GD25910@codepoet.org>
2003-08-06 18:32 ` [PATCH] ide-disk.c rev 1.13 killed CONFIG_IDEDISK_STROKE Bartlomiej Zolnierkiewicz
2003-08-06 19:30 ` Erik Andersen [this message]
2003-08-06 19:58 ` Bartlomiej Zolnierkiewicz
2003-08-07 1:11 ` Andries Brouwer
2003-08-07 2:31 ` Bartlomiej Zolnierkiewicz
2003-08-07 13:22 Andries.Brouwer
2003-08-07 13:50 ` Bartlomiej Zolnierkiewicz
-- strict thread matches above, loose matches on Subject: below --
2003-08-07 11:23 Andries.Brouwer
2003-08-07 11:49 ` Bartlomiej Zolnierkiewicz
2003-08-07 9:57 Andries.Brouwer
2003-08-07 10:44 ` Bartlomiej Zolnierkiewicz
2003-08-07 1:59 Andries.Brouwer
2003-08-02 12:45 Andries Brouwer
2003-08-02 13:10 ` Bartlomiej Zolnierkiewicz
2003-08-02 17:42 ` Andries Brouwer
2003-08-02 21:06 ` Alan Cox
2003-08-02 23:34 ` [PATCH] " Erik Andersen
2003-08-03 1:26 ` Andries Brouwer
2003-08-03 2:12 ` Erik Andersen
2003-08-03 9:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030806193058.GA27207@codepoet.org \
--to=andersen@codepoet.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=aebr@win.tue.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).