2.6.0-test4-mm3

2.6.0-test4-mm3

[Andrew Morton]

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test4/2.6.0-test4-mm3/


. Lots of small fixes.

. The kswapd-chews-tons-of-CPU problem should be fixed.






Changes since 2.6.0-test4-mm2:


 huge-net-update.patch

 Updated

-proc-net-igmp-oops-fix.patch

 Merged into huge-net-update.patch

-no-root-device-option.patch

 This broke things.

+proc-kallsyms-caching-fix.patch

 Fix caching of /proc/kallsyms contents

-futex-minor-fixes.patch

 This is still changing.

+large-dev_t-12-fix.patch

 oops fix.

+evdev_ioctl-fix.patch

 input driver fix

+as-no-initial-antic.patch

 Anticipatory scheduler special-case fix

+mark-devfs-obsolete.patch

 Mark devfs as obsolete.

+hch-contacts-update.patch

 hch has moved

+h8300-include-update.patch

 h8300 fixes

+cyclades-isa-fix.patch

 serial driver fix

+old-module-tools-warning.patch

 Emit a warning if the user doesn't have the new module tools installed

+arcnet-printk-fix.patch

 Driver fixlet

+floppy-cleanup.patch
+floppy-more-cleanup.patch

 Floppy cleanups.

+v850-nommu-export-fixes.patch
+v850-RODATA-fix.patch

 v850 update

+dnotify-use-tgid.patch

 Use threadgroup ID for delivery of dnotify signals.

+send_sigio-decl-fix.patch

 Cleanup

+ipc-use-tgid.patch

 Use thread group ID for sysv IPC.

+voyager-cpumask_t-fix.patch

 Voyager race fix.

+mtrr-attrib_to_str-consolidation.patch

 Remove some code duplication

+ioctl_end-fix.patch

 Fix compat ioctl tables

+raw-driver-fixes.patch

 /dev/raw oops fix

+ipc_init-shuffle.patch

 Initialise the IPC system later.

+zone-pressure-fixes.patch
+zone-pressure-simplification.patch

 memory reclaim fixes

+sched-CAN_MIGRATE_TASK-fix.patch

 Task migrationfix

+4g4g-slab-__get_user-fix.patch

 4G/4G /proc/slabinfo fix

+aio-O_SYNC-fix-missing-bit.patch

 Lost AIO bits.




All 257 patches:

linus.patch

mm.patch
  add -mmN to EXTRAVERSION

kgdb-ga.patch
  kgdb stub for ia32 (George Anzinger's one)
  kgdbL warning fix

kgdb-warning-fix.patch
  kgdbL warning fix

kgdb-build-fix.patch

kgdb-spinlock-fix.patch

kgdb-fix-debug-info.patch
  kgdb: CONFIG_DEBUG_INFO fix

kgdb-cpumask_t.patch

kgdb-x86_64-fixes.patch
  x86_64 fixes

handle-unreadable-dot-config.patch
  .config checks updated

huge-net-update.patch
  net update

config_spinline.patch
  uninline spinlocks for profiling accuracy.

ppc64-build-fixes.patch
  Fix ppc64 breakage

ppc64-bar-0-fix.patch
  Allow PCI BARs that start at 0

ppc64-reloc_hide.patch

ppc64-semaphore-reimplementation.patch
  ppc64: use the ia32 semaphore implementation

ppc64-local.patch
  ppc64: local.h implementation

ppc64-sched_clock.patch
  ppc64: sched_clock()

sym-do-160.patch
  make the SYM driver do 160 MB/sec

x86_64-update-3.patch
  x86-64 update for test4

random-locking-fixes.patch
  random: SMP locking

random-accounting-and-sleeping-fixes.patch
  random: accounting and sleeping fixes

rt-tasks-special-vm-treatment.patch
  real-time enhanced page allocator and throttling

rt-tasks-special-vm-treatment-2.patch

input-use-after-free-checks.patch
  input layer debug checks

deadline-requeue-workaround.patch
  deadline requeue workaround

fbdev.patch

tdfx-build-fix.patch
  tdfx linkage fix

cursor-flashing-fix.patch
  fbdev: fix cursor letovers

disable-athlon-prefetch.patch

sis900-atomicity-fix.patch
  sis900 atomicity fix

slab-hexdump.patch
  slab: hexdump structures when things go wrong

aic7xxx-parallel-build-fix.patch
  fix parallel builds for aic7xxx

yenta-20030817-1-zv.patch

yenta-20030817-2-override.patch

yenta-20030817-3-sockinit.patch

yenta-20030817-4-pm.patch

yenta-20030817-5-pm2.patch

yenta-20030817-6-init.patch

yenta-20030817-7-quirks.patch

proc-pid-setuid-ownership-fix.patch
  fix /proc/pid/fd ownership across setuid()

pid-revalidate-security-hook.patch
  Call security hook from pid*_revalidate

dac960-GAM-IOCTLs-cleanup.patch
  move DAC960 GAM IOCTLs into a new device

thread-pgrp-fix-2.patch
  Fix setpgid and threads

kj-maintainers.patch
  Add the kernel janitors to MAINTAINERS

ide-docs-update.patch
  Update ide.txt documentation to current ide.c

ramdisk-cleanup.patch

v4l-use-after-free-fix.patch
  Fix bug in v4l core for 2.6.0-test3-bk

ikconfig-makefile-update.patch
  ikconfig - Makefile update

ftape-warning-fix.patch
  Fix ftape warning

jffs-retval-fix.patch
  jffs aops return type fix

delay-ksoftirqd-fallback.patch
  Try harded in IRQ context before falling back to ksoftirqd

intel8x0-cleanup.patch
  intel8x0 cleanups

make-ACPI_SLEEP-select-SOFTWARE_SUSPEND.patch
  Make ACPI_SLEEP select SOFTWARE_SUSPEND

3GB-personality.patch
  Add 3GB personality

zeromap_pmd_range-fix.patch
  zeromap_pmd_range bugfix

no-async-write-errors-on-close.patch
  don't report async write errors on close() after all

sis190-fix.patch
  sis190 synchronize_irq fix

remove-add_wait_queue_cond.patch
  remove add_wait_queue_cond()

spin_lock_irqrestore-fixes.patch
  spin_lock_irqrestore() typo fixes

pcmciamtd-fix.patch
  pcmciamtd.c: remove release timer

zoran-memleak-fixes.patch
  zoran: memleak fixes

zoran-rename-debug.patch
  zoran: debug->zr_debug

zoran-release-callback.patch
  zoran: add release callback

zoran-pci_disable_device.patch
  zoranL: add pci_disable_device() call

zoran-cleanups.patch
  zoran: cleanups

zoran-cleanups-2.patch
  zoran: more cleanups

zoran-naming-fix.patch
  zoran: correct name field breakage

airo-build-fix.patch
  airo CONFIG_PCI=n build fix

m68k-vmlinux_lds-move.patch
  move m68k vmlinux.lds files

mac-ide-fix.patch
  Fix Mac IDE

m68k-asm-sections-fix.patch
  m68k asm/sections.h

m68k-asm-local.patch
  m68k asm/local.h

amiga-z2ram-fix.patch
  Amiga z2ram

amiga-floppy-fix.patch
  Amiga floppy

atari-floppy-fix.patch
  Atari floppy

m68k-switch_to-fix.patch
  M68k switch_to fix

pcxx-warning-fix.patch
  drivers/char/pcxx.c warning fix

pcnet32-unregister_pci-fix.patch
  pcnet32 needs unregister_pci

hwifs-oops-unregister-fix.patch
  Fix ide unregister vs. driver model

c99-conversions.patch
  c99 struct initialiser conversions

cyc2x-fixes.patch
  cyc2x: sanitize ioremap usage & more

noacpi-option-fix.patch
  Fix 'pci=noacpi' with buggy ACPI BIOSes

h8300-interrupt-fix.patch
  h8300 interrupt problem fix

proc-kallsyms-caching-fix.patch
  /proc/kallsym caching fix

proc-kallsyms-permission-fix.patch
  Fix permissions on /proc/kallsyms

cu3088-string-null-termination-fix.patch
  cu3088 null termination fix

kobject-doc-addition.patch
  Kobject doc addition

vm_enough_memory-speedup.patch
  vm_enough_memory microoptimisation

abi-doc-update.patch
  abi doc update

remove-bio-boot-messages.patch
  bio.c: reduce verbosity at boot

claim-serio-early.patch
  Serio: claim serio early

ni5010-build-fix.patch
  ni5010.c: remove cli/sti

sis190-build-fix.patch
  sis190 doesn't compile with gcc 2.95

nopage-fix.patch
  do_no_page() fix

fix-strange-code-in-bio_add_page.patch
  Fix odd code in bio_add_page

parport_pc-rmmod-oops-fix.patch
  parport_pc rmmod oops fix

reiserfs-writepage-fix.patch
  reiserfs writepage-versus-truncate fix

visws-build-fix.patch
  visws: fix 2.6.0-test4 breakage

cciss-queue-init-fix.patch
  cciss queue initialisation fix

htree-big-endian-fix.patch
  Fix ext3 htree corruption on big-endian platforms

selinux-file-fcntl-fix.patch
  Fix selinux_file_fcntl

selinux-avtab-fix.patch
  Fix SELinux avtab

selinux-format-specifiers-fix.patch
  Fix SELinux format specifiers

selinux-binprm-hooks-rework.patch
  Rework SELinux binprm hooks

ext2-xattr-typo-fix.patch
  Fix typo in #ifdef for ext2 xattr support

bad-inode-ops.patch
  Add more bad_inode operations

kcore-aout-build-fix.patch
  Fix build with CONFIG_KCORE_AOUT

nfs4proc-warnings-fix.patch
  knfsd nfs4 warning fixes

bluetooth-warning-fixes.patch
  Fix bluetooth compile warnings

nopage-rss-accounting-fix.patch
  do_no_page() rss accounting fix

sonypi-update.patch
  sonypi driver update

meye-update.patch
  meye driver update

jbd-stfu.patch
  jbd: remove uninformative printk

proc-pid-maps-32-bit-fix.patch
  Do 32bit addresses in /proc/self/maps if possible

acpi-pci-link-fix.patch
  acpi pci_link fix

rusage-context-switch-counters.patch
  add context switch counters

large-dev_t-01.patch
  large dev_t work - first series (1/12)

large-dev_t-02.patch
  large dev_t work - first series (2/12)

large-dev_t-03.patch
  large dev_t work - first series (3/12)

large-dev_t-04.patch
  large dev_t work - first series (4/12)

large-dev_t-05.patch
  large dev_t work - first series (5/12)

large-dev_t-06.patch
  large dev_t work - first series (6/12)

large-dev_t-07.patch
  large dev_t work - first series (7/12)

large-dev_t-08.patch
  large dev_t work - first series (8/12)

large-dev_t-09.patch
  large dev_t work - first series (9/12)

large-dev_t-10.patch
  large dev_t work - first series (10/12)

large-dev_t-11.patch
  large dev_t work - first series (11/12)

large-dev_t-12.patch
  large dev_t work - first series (12/12)

large-dev_t-12-fix.patch
  large dev_t 12/12 fix

size_t-printk-warning-fixes.patch
  remove size_t-based printk warnings

stallion-build-fix-2.patch
  stallion serial driver cleanup

evdev_ioctl-fix.patch
  evdev_ioctl does not report EV_MSC capabilities

as-no-initial-antic.patch
  AS: don't anticipate against a tasks' initial I/O

mark-devfs-obsolete.patch
  mark devfs obsolete

hch-contacts-update.patch
  hch has moved

h8300-include-update.patch
  h8300 include update

cyclades-isa-fix.patch
  Cyclades ISA serial driver fix

old-module-tools-warning.patch
  kbuild: warn if the user has old modutils

arcnet-printk-fix.patch
  fix arcnet printk parameter types

floppy-cleanup.patch
  floppy driver cleanup

floppy-more-cleanup.patch
  floppy driver: more cleanups

v850-nommu-export-fixes.patch
  v850: Guard some symbol exports with #ifdef CONFIG_MMU

v850-RODATA-fix.patch
  v850: Give v850 its own version of the vmlinux.lds.h RODATA macro

dnotify-use-tgid.patch
  Use tgid rather than pid in dnotify

send_sigio-decl-fix.patch
  Fix a few declarations

ipc-use-tgid.patch
  ipc/sem.c: ->pid to ->tgid changes

voyager-cpumask_t-fix.patch
  make voyager work again after the cpumask_t changes

mtrr-attrib_to_str-consolidation.patch
  mtrr cleanups

ioctl_end-fix.patch
  compat ioctl_table fix

raw-driver-fixes.patch
  raw driver oops fix

ipc_init-shuffle.patch
  ipc_init() uses vmalloc too early

zone-pressure-fixes.patch
  vmscan: zone pressure calculation fix

zone-pressure-simplification.patch
  vmscan: zone pressure simplification and fix

p00001_synaptics-restore-on-close.patch

p00002_psmouse-reset-timeout.patch

p00003_synaptics-multi-button.patch

p00004_synaptics-optional.patch

p00005_synaptics-pass-through.patch

p00006_psmouse-suspend-resume.patch

p00007_synaptics-old-proto.patch

synaptics-mode-set.patch
  Synaptics mode setting

syn-multi-btn-fix.patch
  synaptics multibutton fix

keyboard-resend-fix.patch
  keyboard resend fix

linux-isp-2.patch

linux-isp-2-fix-again.patch
  lost feral fix

feral-bounce-fix.patch
  Feral driver - highmem issues

feral-bounce-fix-2.patch
  Feral driver bouncing fix

list_del-debug.patch
  list_del debug check

print-build-options-on-oops.patch
  print a few config options on oops

show_task-free-stack-fix.patch
  show_task() fix and cleanup

put_task_struct-debug.patch

ia32-mknod64.patch
  mknod64 for ia32

ext2-64-bit-special-inodes.patch
  ext2: support for 64-bit device nodes

ext3-64-bit-special-inodes.patch
  ext3: support for 64-bit device nodes

64-bit-dev_t-kdev_t.patch
  64-bit dev_t and kdev_t

64-bit-dev_t-other-archs.patch
  enable 64-bit dev_t for other archs

mknod64-64-bit-fix.patch
  dev_t: fix mknod for 64-bit archs

ustat64.patch
  ustat64

ppc-64-bit-stat.patch
  fix ppc stat.h for 64-bit dev_t

64-bit-dev_t-init_rd-fixes.patch
  initrd fixes for 64-bit dev_t

arch-dev_t-stat-fixes.patch
  Fix all asm-*/stat.h dev_t instances

oops-dump-preceding-code.patch
  i386 oops output: dump preceding code

lockmeter.patch

sparc64-lockmeter-fix.patch

sparc64-lockmeter-fix-2.patch
  Fix lockmeter on sparc64

printk-oops-mangle-fix.patch
  disentangle printk's whilst oopsing on SMP

20-odirect_enable.patch

21-odirect_cruft.patch

22-read_proc.patch

23-write_proc.patch

24-commit_proc.patch

25-odirect.patch

nfs-O_DIRECT-always-enabled.patch
  Force CONFIG_NFS_DIRECTIO

sched-CAN_MIGRATE_TASK-fix.patch
  CAN_MIGRATE fix

sched-balance-fix-2.6.0-test3-mm3-A0.patch
  sched-balance-fix-2.6.0-test3-mm3-A0

sched-2.6.0-test2-mm2-A3.patch
  sched-2.6.0-test2-mm2-A3

ppc-sched_clock.patch

sparc64_sched_clock.patch

x86_64-sched_clock.patch
  Add sched_clock for x86-64

sched-warning-fix.patch

sched-balance-tuning.patch
  CPU scheduler balancing fix

sched-no-tsc-on-numa.patch
  Subject: Re: Fw: Re: 2.6.0-test2-mm3

o12.2int.patch
  O12.2int for interactivity

o12.3.patch
  O12.3 for interactivity

o13int.patch
  O13int for interactivity

o13.1int.patch
  O13.1int

o14int.patch
  O14int

o14int-div-fix.patch
  o14int 64-bit-divide fix

o14.1int.patch
  O14.1int

o15int.patch
  O15int for interactivity

o16int.patch
  From: Con Kolivas <kernel@kolivas.org>
  Subject: [PATCH] O16int for interactivity

o16.1int.patch
  O16.1int for interactivity

o16.2int.patch
  O16.2int

o16.3int.patch
  O16.3int

o18int.patch
  O18int

o18.1int.patch
  O18.1int

sched-cpu-migration-fix.patch
  sched: task migration fix

4g-2.6.0-test2-mm2-A5.patch
  4G/4G split patch
  4G/4G: remove debug code
  4g4g: pmd fix
  4g/4g: fixes from Bill
  4g4g: fpu emulation fix
  4g/4g usercopy atomicity fix
  4G/4G: remove debug code
  4g4g: pmd fix
  4g/4g: fixes from Bill
  4g4g: fpu emulation fix
  4g/4g usercopy atomicity fix

4g4g-slab-__get_user-fix.patch
  4g4g: fix __get_user in slab

4g4g-vmlinux-update-got-lost.patch

4g4g-do_page_fault-cleanup.patch
  4G/4G: remove debug code

4g4g-cleanups.patch

kgdb-4g4g-fix-2.patch

4g4g-config-fix.patch

4g4g-pmd-fix.patch
  4g4g: pmd fix

4g4g-wli-fixes.patch
  4g/4g: fixes from Bill

4g4g-fpu-fix.patch
  4g4g: fpu emulation fix

4g4g-show_registers-fix.patch
  4g4g: show_registers() fix

4g4g-pin_page-atomicity-fix.patch
  4g/4g usercopy atomicity fix

4g4g-remove-touch_all_pages.patch

4g4g-debug-flags-fix.patch
  4g4g: debug flags fix

4g4g-TI_task-fix.patch
  4g4g: Fix wrong asm-offsets entry

cyclone-fixmap-fix.patch
  cyclone time fixmap fix

ppc-fixes.patch
  make mm4 compile on ppc

aic7xxx_old-oops-fix.patch

aio-01-retry.patch
  AIO: Core retry infrastructure

io_submit_one-EINVAL-fix.patch
  Fix aio process hang on EINVAL

aio-02-lockpage_wq.patch
  AIO: Async page wait

aio-03-fs_read.patch
  AIO: Filesystem aio read

aio-04-buffer_wq.patch
  AIO: Async buffer wait

aio-05-fs_write.patch
  AIO: Filesystem aio write

aio-05-fs_write-fix.patch

aio-06-bread_wq.patch
  AIO: Async block read

aio-06-bread_wq-fix.patch

aio-07-ext2getblk_wq.patch
  AIO: Async get block for ext2

O_SYNC-speedup-2.patch
  speed up O_SYNC writes

aio-09-o_sync.patch
  aio O_SYNC

aio-10-BUG-fix.patch
  AIO: fix a BUG

aio-11-workqueue-flush.patch
  AIO: flush workqueues before destroying ioctx'es

aio-12-readahead.patch
  AIO: readahead fixes

aio-dio-no-readahead.patch
  aio O_DIRECT no readahead

lock_buffer_wq-fix.patch
  lock_buffer_wq fix

unuse_mm-locked.patch
  AIO: hold the context lock across unuse_mm

aio-take-task_lock.patch
  From: Suparna Bhattacharya <suparna@in.ibm.com>
  Subject: Re: 2.5.72-mm1 - Under heavy testing with AIO,.. vmstat seems to blow the kernel

aio-O_SYNC-fix.patch
  Unify o_sync changes for aio and regular writes

aio-O_SYNC-fix-missing-bit.patch
  aio-O_SYNC-fix bits got lost

O_SYNC-speedup-nolock-fix.patch

aio-writev-nsegs-fix.patch
  aio: writev nr_segs fix

aio-remove-lseek-triggerable-BUG_ONs.patch

aio-readahead-rework.patch
  Unified page range readahead for aio and regular reads

aio-readahead-speedup.patch
  Readahead issues and AIO read speedup

aio-osync-fix-2.patch
  More AIO O_SYNC related fixes

Re: 2.6.0-test4-mm3

[Andrew Morton]

Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test4/2.6.0-test4-mm3/

That rollup is missing some AIO patches.  And master.kernel.org has
conveniently died.

Please use

http://www.zip.com.au/~akpm/linux/patches/2.6.0-test4-mm3-1.gz

Re: 2.6.0-test4-mm3

[Ed Sweetman]

Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test4/2.6.0-test4-mm3/
> 
> 
> . Lots of small fixes.


It seems that since test3-mm2 ...possibly mm3, my kernels just hang 
after loading the input driver for the pc speaker.  Now directly after 
this on test3-mm1 serio loads.
  serio: i8042 AUX port at 0x60,0x64 irq 12
input: AT Set 2 keyboard on isa0060/serio0
serio: i8042 KBD port at 0x60,0x64 irq 1

I'm guessing this is where the later kernels are hanging.
I checked and i dont see any serio/input patches since mm1 in test3 but 
every mm kernel i've tried since mm3 hangs at the same point where as 
mm1 does not.  All have the same config.  I'm using acpi as well.  This 
is a via amd board.  I dont wanna send a general email with all kinds of 
extra info (.config and such) unless someone is interested in the 
problem and needs it.

Re: 2.6.0-test4-mm3

[Andrew Morton]

Ed Sweetman <ed.sweetman@wmich.edu> wrote:
>
> Andrew Morton wrote:
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test4/2.6.0-test4-mm3/
> > 
> > 
> > . Lots of small fixes.
> 
> 
> It seems that since test3-mm2 ...possibly mm3, my kernels just hang 
> after loading the input driver for the pc speaker.  Now directly after 
> this on test3-mm1 serio loads.
>   serio: i8042 AUX port at 0x60,0x64 irq 12
> input: AT Set 2 keyboard on isa0060/serio0
> serio: i8042 KBD port at 0x60,0x64 irq 1
> 
> I'm guessing this is where the later kernels are hanging.
> I checked and i dont see any serio/input patches since mm1 in test3 but 
> every mm kernel i've tried since mm3 hangs at the same point where as 
> mm1 does not.  All have the same config.  I'm using acpi as well.  This 
> is a via amd board.  I dont wanna send a general email with all kinds of 
> extra info (.config and such) unless someone is interested in the 
> problem and needs it.

The only patch I can see in there is syn-multi-btn-fix.patch in test3-mm3,
which seems unlikely.

Have you tested 2.6.0-test4?  If that also fails then I'd be suspecting the
ACPI changes; there seem to be a few new problems in that area lately.

Re: 2.6.0-test4-mm3

[Felipe Alfaro Solana]

On Fri, 2003-08-29 at 17:42, Ed Sweetman wrote:
> 
> It seems that since test3-mm2 ...possibly mm3, my kernels just hang 
> after loading the input driver for the pc speaker.  Now directly after 
> this on test3-mm1 serio loads.
>   serio: i8042 AUX port at 0x60,0x64 irq 12
> input: AT Set 2 keyboard on isa0060/serio0
> serio: i8042 KBD port at 0x60,0x64 irq 1

Please, take a look at
http://bugzilla.kernel.org/show_bug.cgi?id=1123

It's a problem with ACPI interrupt routing, it seems.

OOps in 2.6.0-test4-mm3-1

[Mike Fedyk]

[-- Attachment #1: Type: text/plain, Size: 3184 bytes --]

It's vanilla mm3-1 with this one patch added from Neil Brown.  I don't think
it has anything to do with it (it looks like a driver issue to me).  But it
can't hurt to mention it.

diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~	2003-08-24 08:07:18.000000000 +1000
+++ ./drivers/md/md.c	2003-08-26 09:11:39.000000000 +1000
@@ -638,14 +638,13 @@ static void super_90_sync(mddev_t *mddev
 	/* make rdev->sb match mddev data..
 	 *
 	 * 1/ zero out disks
-	 * 2/ Add info for each disk, keeping track of highest desc_nr
-	 * 3/ any empty disks < highest become removed
+	 * 2/ Add info for each disk, keeping track of highest desc_nr (next_spare);
+	 * 3/ any empty disks < next_spare become removed
 	 *
 	 * disks[0] gets initialised to REMOVED because
 	 * we cannot be sure from other fields if it has
 	 * been initialised or not.
 	 */
-	int highest = 0;
 	int i;
 	int active=0, working=0,failed=0,spare=0,nr_disks=0;
 
@@ -716,17 +715,17 @@ static void super_90_sync(mddev_t *mddev
 			spare++;
 			working++;
 		}
-		if (rdev2->desc_nr > highest)
-			highest = rdev2->desc_nr;
 	}
 	
-	/* now set the "removed" bit on any non-trailing holes */
-	for (i=0; i<highest; i++) {
+	/* now set the "removed" and "faulty" bits on any missing devices */
+	for (i=0 ; i < mddev->raid_disks ; i++) {
 		mdp_disk_t *d = &sb->disks[i];
 		if (d->state == 0 && d->number == 0) {
 			d->number = i;
 			d->raid_disk = i;
 			d->state = (1<<MD_DISK_REMOVED);
+			d->state |= (1<<MD_DISK_FAULTY);
+			failed++;
 		}
 	}
 	sb->nr_disks = nr_disks;




Configuring Adaptec (SCSI-ID 7) at IO:230, IRQ 9, DMA priority 5
Unable to handle kernel NULL pointer dereference at virtual address 00000038
 printing eip:
c01ecf9a
*pde = 00000000
Oops: 0002 [#1]
PREEMPT SMP 
CPU:    0
EIP:    0060:[kobject_put+6/28]    Not tainted VLI
EFLAGS: 00010206
EIP is at kobject_put+0x6/0x1c
eax: 00000024   ebx: c0459578   ecx: 00000000   edx: 00000024
esi: c9b89ed8   edi: c9b89eec   ebp: c9b89e90   esp: c9b89e90
ds: 007b   es: 007b   ss: 0068
Process modprobe (pid: 73, threadinfo=c9b88000 task=c12bf2f0)
Stack: c9b89e9c c023d2eb 00000024 c9b89eec c026dccb 00000000 c04594c0 ca944dc0 
       c03e3600 c04594c0 ca902da8 00000000 c04594c0 00000000 00000001 dead4ead 
       c9b89ee4 c9b89ee4 00000000 00000001 dead4ead c9b89ee4 c9b89ee4 c9b89ef8 
Call Trace:
 [put_device+15/20] put_device+0xf/0x14
 [scsi_host_dev_release+139/160] scsi_host_dev_release+0x8b/0xa0
 [device_release+22/80] device_release+0x16/0x50
 [kobject_cleanup+40/64] kobject_cleanup+0x28/0x40
 [kobject_put+23/28] kobject_put+0x17/0x1c
 [put_device+15/20] put_device+0xf/0x14
 [scsi_host_put+17/24] scsi_host_put+0x11/0x18
 [scsi_unregister+81/88] scsi_unregister+0x51/0x58
 [_end+172423342/1068932160] aha1542_detect+0x5e6/0x608 [aha1542]
 [_end+172423451/1068932160] init_this_scsi_driver+0x4b/0x116 [aha1542]
 [sys_init_module+405/728] sys_init_module+0x195/0x2d8
 [syscall_call+7/11] syscall_call+0x7/0xb

Code: 85 c0 74 0d 8b 00 85 c0 74 07 52 ff d0 83 c4 04 90 85 db 74 09 8d 43 10 50 e8 07 00 00 00 8b 5d fc 89 ec 5d c3 55 89 e5 8b 55 08 <f0> ff 4a 14 0f 94 c0 84 c0 74 06 52 e8 a9 ff ff ff 89 ec 5d c3 

[-- Attachment #2: aha1542-oops-2.6.0-test4-mm3-1-mdfail.dmesg --]
[-- Type: text/plain, Size: 19817 bytes --]

Aug 29 14:29:55 srv-copyroom kernel: Linux version 2.6.0-test4-mm3-1-mdfail (root@srv-lr2600) (gcc version 2.95.4 20011002 (Debian prerelease)) #1 SMP Fri Aug 29 13:33:26 PDT 2003
Aug 29 14:29:55 srv-copyroom kernel: Video mode to be used for restore is f01
Aug 29 14:29:55 srv-copyroom kernel: BIOS-provided physical RAM map:
Aug 29 14:29:55 srv-copyroom kernel:  BIOS-e820: 0000000000000000 - 000000000009fc00 (usable)
Aug 29 14:29:55 srv-copyroom kernel:  BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved)
Aug 29 14:29:55 srv-copyroom kernel:  BIOS-e820: 00000000000f0000 - 0000000000100000 (reserved)
Aug 29 14:29:55 srv-copyroom kernel:  BIOS-e820: 0000000000100000 - 000000000a000000 (usable)
Aug 29 14:29:55 srv-copyroom kernel:  BIOS-e820: 00000000ffff0000 - 0000000100000000 (reserved)
Aug 29 14:29:55 srv-copyroom kernel: 0MB HIGHMEM available.
Aug 29 14:29:55 srv-copyroom kernel: 160MB LOWMEM available.
Aug 29 14:29:55 srv-copyroom kernel: On node 0 totalpages: 40960
Aug 29 14:29:55 srv-copyroom kernel:   DMA zone: 4096 pages, LIFO batch:1
Aug 29 14:29:55 srv-copyroom kernel:   Normal zone: 36864 pages, LIFO batch:9
Aug 29 14:29:55 srv-copyroom kernel:   HighMem zone: 0 pages, LIFO batch:1
Aug 29 14:29:55 srv-copyroom kernel: DMI 2.0 present.
Aug 29 14:29:55 srv-copyroom kernel: ACPI disabled because your bios is from 97 and too old
Aug 29 14:29:55 srv-copyroom kernel: You can enable it with acpi=force
Aug 29 14:29:55 srv-copyroom kernel: ACPI: Unable to locate RSDP
Aug 29 14:29:55 srv-copyroom kernel: Building zonelist for node : 0
Aug 29 14:29:55 srv-copyroom kernel: Kernel command line: root=/dev/hda1 ro vga=extended hdc=ide-scsi nmi_watchdog=2
Aug 29 14:29:55 srv-copyroom kernel: ide_setup: hdc=ide-scsi
Aug 29 14:29:55 srv-copyroom kernel: Local APIC disabled by BIOS -- reenabling.
Aug 29 14:29:55 srv-copyroom kernel: Found and enabled local APIC!
Aug 29 14:29:55 srv-copyroom kernel: current: c03a9b40
Aug 29 14:29:55 srv-copyroom kernel: current->thread_info: c0430000
Aug 29 14:29:55 srv-copyroom kernel: Initializing CPU#0
Aug 29 14:29:55 srv-copyroom kernel: PID hash table entries: 1024 (order 10: 8192 bytes)
Aug 29 14:29:55 srv-copyroom kernel: Detected 300.692 MHz processor.
Aug 29 14:29:55 srv-copyroom kernel: Console: colour VGA+ 80x50
Aug 29 14:29:55 srv-copyroom kernel: Calibrating delay loop... 591.87 BogoMIPS
Aug 29 14:29:55 srv-copyroom kernel: Memory: 157792k/163840k available (2180k kernel code, 5420k reserved, 1082k data, 188k init, 0k highmem)
Aug 29 14:29:55 srv-copyroom kernel: Security Scaffold v1.0.0 initialized
Aug 29 14:29:55 srv-copyroom kernel: Capability LSM initialized
Aug 29 14:29:55 srv-copyroom kernel: Dentry cache hash table entries: 32768 (order: 5, 131072 bytes)
Aug 29 14:29:55 srv-copyroom kernel: Inode-cache hash table entries: 16384 (order: 4, 65536 bytes)
Aug 29 14:29:55 srv-copyroom kernel: Mount-cache hash table entries: 512 (order: 0, 4096 bytes)
Aug 29 14:29:55 srv-copyroom kernel: -> /dev
Aug 29 14:29:55 srv-copyroom kernel: -> /dev/console
Aug 29 14:29:55 srv-copyroom kernel: -> /root
Aug 29 14:29:55 srv-copyroom kernel: CPU:     After generic identify, caps: 0080fbff 00000000 00000000 00000000
Aug 29 14:29:55 srv-copyroom kernel: CPU:     After vendor identify, caps: 0080fbff 00000000 00000000 00000000
Aug 29 14:29:55 srv-copyroom kernel: CPU: L1 I cache: 16K, L1 D cache: 16K
Aug 29 14:29:55 srv-copyroom kernel: CPU: L2 cache: 512K
Aug 29 14:29:55 srv-copyroom kernel: CPU:     After all inits, caps: 0080fbff 00000000 00000000 00000040
Aug 29 14:29:55 srv-copyroom kernel: Intel machine check architecture supported.
Aug 29 14:29:55 srv-copyroom kernel: Intel machine check reporting enabled on CPU#0.
Aug 29 14:29:55 srv-copyroom kernel: Checking 'hlt' instruction... OK.
Aug 29 14:29:55 srv-copyroom kernel: POSIX conformance testing by UNIFIX
Aug 29 14:29:55 srv-copyroom kernel: CPU0: Intel Pentium II (Klamath) stepping 03
Aug 29 14:29:55 srv-copyroom kernel: per-CPU timeslice cutoff: 1463.01 usecs.
Aug 29 14:29:55 srv-copyroom kernel: task migration cache decay timeout: 2 msecs.
Aug 29 14:29:55 srv-copyroom kernel: SMP motherboard not detected.
Aug 29 14:29:55 srv-copyroom kernel: enabled ExtINT on CPU#0
Aug 29 14:29:55 srv-copyroom kernel: ESR value before enabling vector: 00000000
Aug 29 14:29:55 srv-copyroom kernel: ESR value after enabling vector: 00000000
Aug 29 14:29:55 srv-copyroom kernel: testing NMI watchdog ... OK.
Aug 29 14:29:55 srv-copyroom kernel: Using local APIC timer interrupts.
Aug 29 14:29:55 srv-copyroom kernel: calibrating APIC timer ...
Aug 29 14:29:55 srv-copyroom kernel: ..... CPU clock speed is 300.0632 MHz.
Aug 29 14:29:55 srv-copyroom kernel: ..... host bus clock speed is 66.0807 MHz.
Aug 29 14:29:55 srv-copyroom kernel: Starting migration thread for cpu 0
Aug 29 14:29:55 srv-copyroom kernel: CPUS done 2
Aug 29 14:29:55 srv-copyroom kernel: zapping low mappings.
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for No Bus:legacy
Aug 29 14:29:55 srv-copyroom kernel: Initializing RT netlink socket
Aug 29 14:29:55 srv-copyroom kernel: PCI: PCI BIOS revision 2.10 entry at 0xfb0a0, last bus=0
Aug 29 14:29:55 srv-copyroom kernel: PCI: Using configuration type 1
Aug 29 14:29:55 srv-copyroom kernel: mtrr: v2.0 (20020519)
Aug 29 14:29:55 srv-copyroom kernel: ACPI: Subsystem revision 20030813
Aug 29 14:29:55 srv-copyroom kernel: ACPI: Interpreter disabled.
Aug 29 14:29:55 srv-copyroom kernel: Linux Plug and Play Support v0.97 (c) Adam Belay
Aug 29 14:29:55 srv-copyroom kernel: PnPBIOS: Scanning system for PnP BIOS support...
Aug 29 14:29:55 srv-copyroom kernel: PnPBIOS: Found PnP BIOS installation structure at 0xc00fbd70
Aug 29 14:29:55 srv-copyroom kernel: PnPBIOS: PnP BIOS version 1.0, entry 0xf0000:0xbd98, dseg 0xf0000
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for No Bus:pnp0
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:00
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:01
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:02
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:03
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:04
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:05
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:06
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:07
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:08
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:09
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:0a
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:0b
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:0c
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pnp:00:0d
Aug 29 14:29:55 srv-copyroom kernel: PnPBIOS: 14 nodes reported by PnP BIOS; 14 recorded by driver
Aug 29 14:29:55 srv-copyroom kernel: SCSI subsystem initialized
Aug 29 14:29:55 srv-copyroom kernel: ACPI: ACPI tables contain no PCI IRQ routing entries
Aug 29 14:29:55 srv-copyroom kernel: PCI: Invalid ACPI-PCI IRQ routing table
Aug 29 14:29:55 srv-copyroom kernel: PCI: Probing PCI hardware
Aug 29 14:29:55 srv-copyroom kernel: PCI: Probing PCI hardware (bus 00)
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for No Bus:pci0000:00
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:00.0
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:07.0
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:07.1
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:07.2
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:08.0
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:0a.0
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:0a.1
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:0a.2
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for pci:0000:00:0c.0
Aug 29 14:29:55 srv-copyroom kernel: pty: 256 Unix98 ptys configured
Aug 29 14:29:55 srv-copyroom kernel: Machine check exception polling timer started.
Aug 29 14:29:55 srv-copyroom kernel: apm: BIOS version 1.2 Flags 0x07 (Driver version 1.16ac)
Aug 29 14:29:55 srv-copyroom kernel: VFS: Disk quotas dquot_6.5.1
Aug 29 14:29:55 srv-copyroom kernel: Initializing Cryptographic API
Aug 29 14:29:55 srv-copyroom kernel: Limiting direct PCI/PCI transfers.
Aug 29 14:29:55 srv-copyroom kernel: Activating ISA DMA hang workarounds.
Aug 29 14:29:55 srv-copyroom kernel:         -0420: *** Error: Could not allocate an object descriptor
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for No Bus:pnp1
Aug 29 14:29:55 srv-copyroom kernel: isapnp: Scanning for PnP cards...
Aug 29 14:29:55 srv-copyroom kernel: isapnp: No Plug & Play device found
Aug 29 14:29:55 srv-copyroom kernel: Hangcheck: starting hangcheck timer 0.5.0 (tick is 180 seconds, margin is 60 seconds).
Aug 29 14:29:55 srv-copyroom kernel: Serial: 8250/16550 driver $Revision: 1.90 $ IRQ sharing enabled
Aug 29 14:29:55 srv-copyroom kernel: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A
Aug 29 14:29:55 srv-copyroom kernel: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
Aug 29 14:29:55 srv-copyroom kernel: Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
Aug 29 14:29:55 srv-copyroom kernel: ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
Aug 29 14:29:55 srv-copyroom kernel: PIIX3: IDE controller at PCI slot 0000:00:07.1
Aug 29 14:29:55 srv-copyroom kernel: PIIX3: chipset revision 0
Aug 29 14:29:55 srv-copyroom kernel: PIIX3: not 100%% native mode: will probe irqs later
Aug 29 14:29:55 srv-copyroom kernel:     ide0: BM-DMA at 0xf000-0xf007, BIOS settings: hda:pio, hdb:pio
Aug 29 14:29:55 srv-copyroom kernel:     ide1: BM-DMA at 0xf008-0xf00f, BIOS settings: hdc:pio, hdd:pio
Aug 29 14:29:55 srv-copyroom kernel: hda: WDC AC34300L, ATA DISK drive
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for No Bus:ide0
Aug 29 14:29:55 srv-copyroom kernel: Using anticipatory scheduling elevator
Aug 29 14:29:55 srv-copyroom kernel: ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for ide:0.0
Aug 29 14:29:55 srv-copyroom kernel: hdc: _NEC CD-RW NR-7900A, ATAPI CD/DVD-ROM drive
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for No Bus:ide1
Aug 29 14:29:55 srv-copyroom kernel: hdd: WDC WD1200JB-00CRA1, ATA DISK drive
Aug 29 14:29:55 srv-copyroom kernel: ide1 at 0x170-0x177,0x376 on irq 15
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for ide:1.0
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for ide:1.1
Aug 29 14:29:55 srv-copyroom kernel: hda: max request size: 128KiB
Aug 29 14:29:55 srv-copyroom kernel: hda: 8406720 sectors (4304 MB) w/256KiB Cache, CHS=8896/15/63, (U)DMA
Aug 29 14:29:55 srv-copyroom kernel:  hda: hda1 hda2
Aug 29 14:29:55 srv-copyroom kernel: hdd: max request size: 128KiB
Aug 29 14:29:55 srv-copyroom kernel: hdd: 234441648 sectors (120034 MB) w/8192KiB Cache, CHS=65535/16/63, (U)DMA
Aug 29 14:29:55 srv-copyroom kernel:  hdd: hdd1
Aug 29 14:29:55 srv-copyroom kernel: mice: PS/2 mouse device common for all mice
Aug 29 14:29:55 srv-copyroom kernel: serio: i8042 AUX port at 0x60,0x64 irq 12
Aug 29 14:29:55 srv-copyroom kernel: input: AT Set 2 keyboard on isa0060/serio0
Aug 29 14:29:55 srv-copyroom kernel: serio: i8042 KBD port at 0x60,0x64 irq 1
Aug 29 14:29:55 srv-copyroom kernel: md: linear personality registered as nr 1
Aug 29 14:29:55 srv-copyroom kernel: md: raid0 personality registered as nr 2
Aug 29 14:29:55 srv-copyroom kernel: md: raid1 personality registered as nr 3
Aug 29 14:29:55 srv-copyroom kernel: md: raid5 personality registered as nr 4
Aug 29 14:29:55 srv-copyroom kernel: raid5: measuring checksumming speed
Aug 29 14:29:55 srv-copyroom kernel:    8regs     :   512.000 MB/sec
Aug 29 14:29:55 srv-copyroom kernel:    8regs_prefetch:   444.000 MB/sec
Aug 29 14:29:55 srv-copyroom kernel:    32regs    :   348.000 MB/sec
Aug 29 14:29:55 srv-copyroom kernel:    32regs_prefetch:   288.000 MB/sec
Aug 29 14:29:55 srv-copyroom kernel:    pII_mmx   :   744.000 MB/sec
Aug 29 14:29:55 srv-copyroom kernel:    p5_mmx    :   768.000 MB/sec
Aug 29 14:29:55 srv-copyroom kernel: raid5: using function: p5_mmx (768.000 MB/sec)
Aug 29 14:29:55 srv-copyroom kernel: md: md driver 0.90.0 MAX_MD_DEVS=256, MD_SB_DISKS=27
Aug 29 14:29:55 srv-copyroom kernel: device-mapper: 4.0.0-ioctl (2003-06-04) initialised: dm@uk.sistina.com
Aug 29 14:29:55 srv-copyroom kernel: NET4: Frame Diverter 0.46
Aug 29 14:29:55 srv-copyroom kernel: NET4: Linux TCP/IP 1.0 for NET4.0
Aug 29 14:29:55 srv-copyroom kernel: IP: routing cache hash table of 512 buckets, 8Kbytes
Aug 29 14:29:55 srv-copyroom kernel: TCP: Hash tables configured (established 8192 bind 10922)
Aug 29 14:29:55 srv-copyroom kernel: BIOS EDD facility v0.09 2003-Jan-22, 1 devices found
Aug 29 14:29:55 srv-copyroom kernel: md: Autodetecting RAID arrays.
Aug 29 14:29:55 srv-copyroom kernel: md: autorun ...
Aug 29 14:29:55 srv-copyroom kernel: md: ... autorun DONE.
Aug 29 14:29:55 srv-copyroom kernel: found reiserfs format "3.6" with standard journal
Aug 29 14:29:55 srv-copyroom kernel: Reiserfs journal params: device hda1, size 8192, journal first block 18, max trans len 1024, max batch 900, max commit age 30, max trans age 30
Aug 29 14:29:55 srv-copyroom kernel: reiserfs: checking transaction log (hda1) for (hda1)
Aug 29 14:29:55 srv-copyroom kernel: Using r5 hash to sort names
Aug 29 14:29:55 srv-copyroom kernel: VFS: Mounted root (reiserfs filesystem) readonly.
Aug 29 14:29:55 srv-copyroom kernel: Freeing unused kernel memory: 188k freed
Aug 29 14:29:55 srv-copyroom kernel: NET4: Unix domain sockets 1.0/SMP for Linux NET4.0.
Aug 29 14:29:55 srv-copyroom kernel: Adding 297192k swap on /dev/hda2.  Priority:-1 extents:1
Aug 29 14:29:55 srv-copyroom kernel: Real Time Clock Driver v1.11a
Aug 29 14:29:55 srv-copyroom kernel: drivers/usb/core/usb.c: registered new driver usbfs
Aug 29 14:29:55 srv-copyroom kernel: drivers/usb/core/usb.c: registered new driver hub
Aug 29 14:29:55 srv-copyroom kernel: drivers/usb/core/usb.c: registered new driver usbscanner
Aug 29 14:29:55 srv-copyroom kernel: drivers/usb/image/scanner.c: 0.4.14:USB Scanner Driver
Aug 29 14:29:55 srv-copyroom kernel: drivers/usb/host/uhci-hcd.c: USB Universal Host Controller Interface driver v2.1
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:07.2: UHCI Host Controller
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:07.2: irq 11, io base 00009000
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:07.2: new USB bus registered, assigned bus number 1
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:usb1
Aug 29 14:29:55 srv-copyroom kernel: hub 1-0:0: USB hub found
Aug 29 14:29:55 srv-copyroom kernel: hub 1-0:0: 2 ports detected
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:1-0:0
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:0a.0: UHCI Host Controller
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:0a.0: irq 5, io base 00009100
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:0a.0: new USB bus registered, assigned bus number 2
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:usb2
Aug 29 14:29:55 srv-copyroom kernel: hub 2-0:0: USB hub found
Aug 29 14:29:55 srv-copyroom kernel: hub 2-0:0: 2 ports detected
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:2-0:0
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:0a.1: UHCI Host Controller
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:0a.1: irq 11, io base 00009200
Aug 29 14:29:55 srv-copyroom kernel: uhci-hcd 0000:00:0a.1: new USB bus registered, assigned bus number 3
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:usb3
Aug 29 14:29:55 srv-copyroom kernel: hub 3-0:0: USB hub found
Aug 29 14:29:55 srv-copyroom kernel: hub 3-0:0: 2 ports detected
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:3-0:0
Aug 29 14:29:55 srv-copyroom kernel: PCI: Enabling device 0000:00:0c.0 (0000 -> 0003)
Aug 29 14:29:55 srv-copyroom kernel: 3c59x: Donald Becker and others. www.scyld.com/network/vortex.html
Aug 29 14:29:55 srv-copyroom kernel: 0000:00:0c.0: 3Com PCI 3c905B Cyclone 100baseTx at 0x9300. Vers LK1.1.19
Aug 29 14:29:55 srv-copyroom kernel: PCI: Setting latency timer of device 0000:00:0c.0 to 64
Aug 29 14:29:55 srv-copyroom kernel:   ***WARNING*** No MII transceivers found!
Aug 29 14:29:55 srv-copyroom kernel: divert: allocating divert_blk for eth0
Aug 29 14:29:55 srv-copyroom kernel: hub 2-0:0: debounce: port 1: delay 100ms stable 4 status 0x101
Aug 29 14:29:55 srv-copyroom kernel: Configuring Adaptec (SCSI-ID 7) at IO:230, IRQ 9, DMA priority 5
Aug 29 14:29:55 srv-copyroom kernel: Unable to handle kernel NULL pointer dereference at virtual address 00000038
Aug 29 14:29:55 srv-copyroom kernel:  printing eip:
Aug 29 14:29:55 srv-copyroom kernel: c01ecf9a
Aug 29 14:29:55 srv-copyroom kernel: *pde = 00000000
Aug 29 14:29:55 srv-copyroom kernel: Oops: 0002 [#1]
Aug 29 14:29:55 srv-copyroom kernel: PREEMPT SMP 
Aug 29 14:29:55 srv-copyroom kernel: CPU:    0
Aug 29 14:29:55 srv-copyroom kernel: EIP:    0060:[kobject_put+6/28]    Not tainted VLI
Aug 29 14:29:55 srv-copyroom kernel: EFLAGS: 00010206
Aug 29 14:29:55 srv-copyroom kernel: EIP is at kobject_put+0x6/0x1c
Aug 29 14:29:55 srv-copyroom kernel: eax: 00000024   ebx: c0459578   ecx: 00000000   edx: 00000024
Aug 29 14:29:55 srv-copyroom kernel: esi: c9b89ed8   edi: c9b89eec   ebp: c9b89e90   esp: c9b89e90
Aug 29 14:29:55 srv-copyroom kernel: ds: 007b   es: 007b   ss: 0068
Aug 29 14:29:55 srv-copyroom kernel: Process modprobe (pid: 73, threadinfo=c9b88000 task=c12bf2f0)
Aug 29 14:29:55 srv-copyroom kernel: Stack: c9b89e9c c023d2eb 00000024 c9b89eec c026dccb 00000000 c04594c0 ca944dc0 
Aug 29 14:29:55 srv-copyroom kernel:        c03e3600 c04594c0 ca902da8 00000000 c04594c0 00000000 00000001 dead4ead 
Aug 29 14:29:55 srv-copyroom kernel:        c9b89ee4 c9b89ee4 00000000 00000001 dead4ead c9b89ee4 c9b89ee4 c9b89ef8 
Aug 29 14:29:55 srv-copyroom kernel: Call Trace:
Aug 29 14:29:55 srv-copyroom kernel:  [put_device+15/20] put_device+0xf/0x14
Aug 29 14:29:55 srv-copyroom kernel:  [scsi_host_dev_release+139/160] scsi_host_dev_release+0x8b/0xa0
Aug 29 14:29:55 srv-copyroom kernel:  [device_release+22/80] device_release+0x16/0x50
Aug 29 14:29:55 srv-copyroom kernel:  [kobject_cleanup+40/64] kobject_cleanup+0x28/0x40
Aug 29 14:29:55 srv-copyroom kernel:  [kobject_put+23/28] kobject_put+0x17/0x1c
Aug 29 14:29:55 srv-copyroom kernel:  [put_device+15/20] put_device+0xf/0x14
Aug 29 14:29:55 srv-copyroom kernel:  [scsi_host_put+17/24] scsi_host_put+0x11/0x18
Aug 29 14:29:55 srv-copyroom kernel:  [scsi_unregister+81/88] scsi_unregister+0x51/0x58
Aug 29 14:29:55 srv-copyroom kernel:  [_end+172423342/1068932160] aha1542_detect+0x5e6/0x608 [aha1542]
Aug 29 14:29:55 srv-copyroom kernel:  [_end+172423451/1068932160] init_this_scsi_driver+0x4b/0x116 [aha1542]
Aug 29 14:29:55 srv-copyroom kernel:  [sys_init_module+405/728] sys_init_module+0x195/0x2d8
Aug 29 14:29:55 srv-copyroom kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Aug 29 14:29:55 srv-copyroom kernel: 
Aug 29 14:29:55 srv-copyroom kernel: Code: 85 c0 74 0d 8b 00 85 c0 74 07 52 ff d0 83 c4 04 90 85 db 74 09 8d 43 10 50 e8 07 00 00 00 8b 5d fc 89 ec 5d c3 55 89 e5 8b 55 08 <f0> ff 4a 14 0f 94 c0 84 c0 74 06 52 e8 a9 ff ff ff 89 ec 5d c3 
Aug 29 14:29:55 srv-copyroom kernel:  <6>hub 2-0:0: new USB device on port 1, assigned address 2
Aug 29 14:29:55 srv-copyroom kernel: PM: Adding info for usb:2-1
Aug 29 14:29:55 srv-copyroom kernel: drivers/usb/image/scanner.c: USB scanner device (0x1606/0x0060) now attached to usb/scanner0

Re: OOps in 2.6.0-test4-mm3-1

[Andrew Morton]

Mike Fedyk <mfedyk@matchmail.com> wrote:
>
> It's vanilla mm3-1 with this one patch added from Neil Brown.  I don't think
> it has anything to do with it (it looks like a driver issue to me).  But it
> can't hurt to mention it.
> 

No, it is not an MD thing.

You need two patches.  It's up to the scsi guys to decide if they're the
right way to go.  I think they are.




Some drivers such as aha1542 and aic7xxx_old will call scsi_register() and
then, if some succeeding operations fails they will call scsi_unregister(),
without an intervening scsi_set_host().

This causes an oops in scsi_put_device(), because kobj->parent is NULL.

In other words, scsi_register() immediately followed by scsi_unregister()
is guaranteed to oops.

The patch makes scsi_host_dev_release() more robust against this usage
pattern.


 drivers/scsi/hosts.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletion(-)

diff -puN drivers/scsi/hosts.c~aha1542-oops-fix drivers/scsi/hosts.c
--- 25/drivers/scsi/hosts.c~aha1542-oops-fix	2003-08-29 19:48:37.000000000 -0700
+++ 25-akpm/drivers/scsi/hosts.c	2003-08-29 20:02:49.000000000 -0700
@@ -158,7 +158,13 @@ static void scsi_host_dev_release(struct
 	scsi_proc_hostdir_rm(shost->hostt);
 	scsi_destroy_command_freelist(shost);
 
-	put_device(parent);
+	/*
+	 * Some drivers (eg aha1542) do scsi_register()/scsi_unregister()
+	 * during probing without performing a scsi_set_device() in between.
+	 * In this case dev->parent is NULL.
+	 */
+	if (parent)
+		put_device(parent);
 	kfree(shost);
 }
 

_



and





scsi_unregister() unconditionally does list_del(&shost->sht_legacy_list).

But scsi_register() leaves that list_head uninitialised if scsi_host_alloc()
returned NULL.

In other words: scsi_unregister() is guaranteed to oops if scsi_host_alloc()
fails.

Fix it by initialising the list_head in scsi_register().


 drivers/scsi/hosts.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletion(-)

diff -puN drivers/scsi/hosts.c~scsi_unregister-oops-fix drivers/scsi/hosts.c
--- 25/drivers/scsi/hosts.c~scsi_unregister-oops-fix	2003-08-29 20:02:53.000000000 -0700
+++ 25-akpm/drivers/scsi/hosts.c	2003-08-29 20:02:53.000000000 -0700
@@ -297,8 +297,12 @@ struct Scsi_Host *scsi_register(struct s
 		dump_stack();
 	}
 
-	if (shost)
+	if (shost) {
 		list_add_tail(&shost->sht_legacy_list, &sht->legacy_hosts);
+	} else {
+		/* Do this to keep scsi_unregister() happy */
+		INIT_LIST_HEAD(&shost->sht_legacy_list);
+	}
 	return shost;
 }
 

_

Re: OOps in 2.6.0-test4-mm3-1

[Mike Fedyk]

On Fri, Aug 29, 2003 at 08:09:26PM -0700, Andrew Morton wrote:
> Mike Fedyk <mfedyk@matchmail.com> wrote:
> >
> > It's vanilla mm3-1 with this one patch added from Neil Brown.  I don't think
> > it has anything to do with it (it looks like a driver issue to me).  But it
> > can't hurt to mention it.

> Some drivers such as aha1542 and aic7xxx_old will call scsi_register() and
> then, if some succeeding operations fails they will call scsi_unregister(),
> without an intervening scsi_set_host().
> 
> This causes an oops in scsi_put_device(), because kobj->parent is NULL.
> 
> In other words, scsi_register() immediately followed by scsi_unregister()
> is guaranteed to oops.
> 
> The patch makes scsi_host_dev_release() more robust against this usage
> pattern.

Ok, I'll give that patch a try.  Though, is there any reason why
2.6.0-test2-mm1 doesn't oops too?  (that was the previous kernel on that
machine)

Re: OOps in 2.6.0-test4-mm3-1

[Andrew Morton]

Mike Fedyk <mfedyk@matchmail.com> wrote:
>
> Though, is there any reason why
>  2.6.0-test2-mm1 doesn't oops too? 

Of course.  drivers/scsi/hosts.c was changed and it broke.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Andrew Morton]

Mike Fedyk <mfedyk@matchmail.com> wrote:
>
> I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 

ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being
kept around for weirdo things like IDE-based tape drives, scanners, etc.

Just use /dev/hdX directly.

Re: 2.6.0-test4-mm3

[Mike Fedyk]

Hi,

I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi.  I've been
using it for the last few days straight and I tried copying files from my
ide cdrom using ide-scsi.  cp segfaults, I get this oops, and X hangs.
Syslog was running long enough to capture it, and a sysrq SUB saved it to
disk.

I will be trying a newer kernel soon.  Has this been caught and fixed already?

Sep 10 11:23:27 mis-mike-wstn kernel: sr0: scsi-1 drive
Sep 10 11:23:27 mis-mike-wstn kernel: Uniform CD-ROM driver Revision: 3.12
Sep 10 11:23:27 mis-mike-wstn kernel: Attached scsi CD-ROM sr0 at scsi0, channel 0, id 0, lun 0
Sep 10 11:24:45 mis-mike-wstn kernel: nfs: server fs not responding, still trying
Sep 10 11:24:47 mis-mike-wstn last message repeated 2 times
Sep 10 11:24:47 mis-mike-wstn kernel: nfs: server fs OK
Sep 10 11:24:47 mis-mike-wstn last message repeated 2 times
Sep 10 11:29:39 mis-mike-wstn kernel: Unable to handle kernel paging request at virtual address 6b6b6b7b
Sep 10 11:29:39 mis-mike-wstn kernel:  printing eip:
Sep 10 11:29:39 mis-mike-wstn kernel: d48894dc
Sep 10 11:29:39 mis-mike-wstn kernel: *pde = 00000000
Sep 10 11:29:39 mis-mike-wstn kernel: Oops: 0000 [#1]
Sep 10 11:29:39 mis-mike-wstn kernel: PREEMPT SMP 
Sep 10 11:29:39 mis-mike-wstn kernel: CPU:    0
Sep 10 11:29:39 mis-mike-wstn kernel: EIP:    0060:[_end+339697948/1068932160]    Not tainted VLI
Sep 10 11:29:39 mis-mike-wstn kernel: EFLAGS: 00010002
Sep 10 11:29:39 mis-mike-wstn kernel: EIP is at idescsi_queue+0x59c/0x614 [ide_scsi]
Sep 10 11:29:39 mis-mike-wstn kernel: eax: 6b6b6b6b   ebx: c2050000   ecx: c2050000   edx: d3357864
Sep 10 11:29:39 mis-mike-wstn kernel: esi: d3357864   edi: c410629c   ebp: c2051d18   esp: c2051ce0
Sep 10 11:29:39 mis-mike-wstn kernel: ds: 007b   es: 007b   ss: 0068
Sep 10 11:29:39 mis-mike-wstn kernel: Process cp (pid: 29140, threadinfo=c2050000 task=ca90e000)
Sep 10 11:29:39 mis-mike-wstn kernel: Stack: d3a94540 00000293 d3a9451c d3a9451c c9e92c00 d33578b8 c461c18c c13cdca0 
Sep 10 11:29:39 mis-mike-wstn kernel:        ffffffff 00000000 d3a946d8 c9e92c00 c410629c c0487b58 c2051d38 c026cf08 
Sep 10 11:29:39 mis-mike-wstn kernel:        d3357864 c026d0d0 c2050000 d3357864 d3680304 00000000 c2051d58 c02724dd 
Sep 10 11:29:39 mis-mike-wstn kernel: Call Trace:
Sep 10 11:29:39 mis-mike-wstn kernel:  [scsi_dispatch_cmd+556/676] scsi_dispatch_cmd+0x22c/0x2a4
Sep 10 11:29:39 mis-mike-wstn kernel:  [scsi_done+0/108] scsi_done+0x0/0x6c
Sep 10 11:29:39 mis-mike-wstn kernel:  [scsi_request_fn+713/1036] scsi_request_fn+0x2c9/0x40c
Sep 10 11:29:39 mis-mike-wstn kernel:  [generic_unplug_device+132/216] generic_unplug_device+0x84/0xd8
Sep 10 11:29:39 mis-mike-wstn kernel:  [blk_run_queues+270/424] blk_run_queues+0x10e/0x1a8
Sep 10 11:29:39 mis-mike-wstn kernel:  [block_sync_page+8/16] block_sync_page+0x8/0x10
Sep 10 11:29:39 mis-mike-wstn kernel:  [wait_on_page_bit_wq+169/228] wait_on_page_bit_wq+0xa9/0xe4
Sep 10 11:29:39 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:39 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_generic_mapping_read+770/1156] do_generic_mapping_read+0x302/0x484
Sep 10 11:29:39 mis-mike-wstn kernel:  [__generic_file_aio_read+478/508] __generic_file_aio_read+0x1de/0x1fc
Sep 10 11:29:39 mis-mike-wstn kernel:  [file_read_actor+0/224] file_read_actor+0x0/0xe0
Sep 10 11:29:39 mis-mike-wstn kernel:  [generic_file_read+171/200] generic_file_read+0xab/0xc8
Sep 10 11:29:39 mis-mike-wstn kernel:  [_end+341016069/1068932160] rpcauth_lookupcred+0x75/0x80 [sunrpc]
Sep 10 11:29:39 mis-mike-wstn kernel:  [cp_new_stat64+224/248] cp_new_stat64+0xe0/0xf8
Sep 10 11:29:39 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:39 mis-mike-wstn kernel:  [sys_fstat64+37/44] sys_fstat64+0x25/0x2c
Sep 10 11:29:39 mis-mike-wstn kernel:  [vfs_read+183/240] vfs_read+0xb7/0xf0
Sep 10 11:29:39 mis-mike-wstn kernel:  [sys_read+48/80] sys_read+0x30/0x50
Sep 10 11:29:39 mis-mike-wstn kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Sep 10 11:29:39 mis-mike-wstn kernel:  [ip_mc_source+583/892] ip_mc_source+0x247/0x37c
Sep 10 11:29:39 mis-mike-wstn kernel: 
Sep 10 11:29:39 mis-mike-wstn kernel: Code: 08 00 00 00 74 09 e8 a8 6e 89 eb 8d 74 26 00 6a 04 8b 7d f8 57 8b 45 fc 50 e8 01 39 9d eb 83 c4 0c fa ff 43 14 8b 55 08 8b 42 04 <8b> 40 10 8b 58 2c 81 7b 04 ad 4e ad de 74 17 68 e2 94 88 d4 68 
Sep 10 11:29:39 mis-mike-wstn kernel:  <6>note: cp[29140] exited with preempt_count 1
Sep 10 11:29:39 mis-mike-wstn kernel: Debug: sleeping function called from invalid context at include/asm/semaphore.h:119
Sep 10 11:29:39 mis-mike-wstn kernel: Call Trace:
Sep 10 11:29:39 mis-mike-wstn kernel:  [__might_sleep+99/104] __might_sleep+0x63/0x68
Sep 10 11:29:39 mis-mike-wstn kernel:  [remove_shared_vm_struct+43/132] remove_shared_vm_struct+0x2b/0x84
Sep 10 11:29:39 mis-mike-wstn kernel:  [exit_mmap+485/552] exit_mmap+0x1e5/0x228
Sep 10 11:29:39 mis-mike-wstn kernel:  [mmput+174/204] mmput+0xae/0xcc
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_exit+498/1332] do_exit+0x1f2/0x534
Sep 10 11:29:39 mis-mike-wstn kernel:  [die+351/352] die+0x15f/0x160
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_page_fault+733/1045] do_page_fault+0x2dd/0x415
Sep 10 11:29:39 mis-mike-wstn kernel:  [_end+339697948/1068932160] idescsi_queue+0x59c/0x614 [ide_scsi]
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_page_fault+0/1045] do_page_fault+0x0/0x415
Sep 10 11:29:40 mis-mike-wstn kernel:  [recalc_task_prio+377/392] recalc_task_prio+0x179/0x188
Sep 10 11:29:40 mis-mike-wstn kernel:  [schedule+1404/1760] schedule+0x57c/0x6e0
Sep 10 11:29:40 mis-mike-wstn kernel:  [preempt_schedule+43/72] preempt_schedule+0x2b/0x48
Sep 10 11:29:40 mis-mike-wstn kernel:  [ide_do_drive_cmd+354/399] ide_do_drive_cmd+0x162/0x18f
Sep 10 11:29:40 mis-mike-wstn kernel:  [error_code+47/64] error_code+0x2f/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [_end+339697948/1068932160] idescsi_queue+0x59c/0x614 [ide_scsi]
Sep 10 11:29:40 mis-mike-wstn kernel:  [scsi_dispatch_cmd+556/676] scsi_dispatch_cmd+0x22c/0x2a4
Sep 10 11:29:40 mis-mike-wstn kernel:  [scsi_done+0/108] scsi_done+0x0/0x6c
Sep 10 11:29:40 mis-mike-wstn kernel:  [scsi_request_fn+713/1036] scsi_request_fn+0x2c9/0x40c
Sep 10 11:29:40 mis-mike-wstn kernel:  [generic_unplug_device+132/216] generic_unplug_device+0x84/0xd8
Sep 10 11:29:40 mis-mike-wstn kernel:  [blk_run_queues+270/424] blk_run_queues+0x10e/0x1a8
Sep 10 11:29:40 mis-mike-wstn kernel:  [block_sync_page+8/16] block_sync_page+0x8/0x10
Sep 10 11:29:40 mis-mike-wstn kernel:  [wait_on_page_bit_wq+169/228] wait_on_page_bit_wq+0xa9/0xe4
Sep 10 11:29:40 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [do_generic_mapping_read+770/1156] do_generic_mapping_read+0x302/0x484
Sep 10 11:29:40 mis-mike-wstn kernel:  [__generic_file_aio_read+478/508] __generic_file_aio_read+0x1de/0x1fc
Sep 10 11:29:40 mis-mike-wstn kernel:  [file_read_actor+0/224] file_read_actor+0x0/0xe0
Sep 10 11:29:40 mis-mike-wstn kernel:  [generic_file_read+171/200] generic_file_read+0xab/0xc8
Sep 10 11:29:40 mis-mike-wstn kernel:  [_end+341016069/1068932160] rpcauth_lookupcred+0x75/0x80 [sunrpc]
Sep 10 11:29:40 mis-mike-wstn kernel:  [cp_new_stat64+224/248] cp_new_stat64+0xe0/0xf8
Sep 10 11:29:40 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [sys_fstat64+37/44] sys_fstat64+0x25/0x2c
Sep 10 11:29:40 mis-mike-wstn kernel:  [vfs_read+183/240] vfs_read+0xb7/0xf0
Sep 10 11:29:40 mis-mike-wstn kernel:  [sys_read+48/80] sys_read+0x30/0x50
Sep 10 11:29:40 mis-mike-wstn kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Sep 10 11:29:40 mis-mike-wstn kernel:  [ip_mc_source+583/892] ip_mc_source+0x247/0x37c

ide-scsi oops was: 2.6.0-test4-mm3

[Mike Fedyk]

Didn't modify subject line... :(

Hi,

I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi.  I've been
using it for the last few days straight and I tried copying files from my
ide cdrom using ide-scsi.  cp segfaults, I get this oops, and X hangs.
Syslog was running long enough to capture it, and a sysrq SUB saved it to
disk.

I will be trying a newer kernel soon.  Has this been caught and fixed already?

Sep 10 11:23:27 mis-mike-wstn kernel: sr0: scsi-1 drive
Sep 10 11:23:27 mis-mike-wstn kernel: Uniform CD-ROM driver Revision: 3.12
Sep 10 11:23:27 mis-mike-wstn kernel: Attached scsi CD-ROM sr0 at scsi0, channel 0, id 0, lun 0
Sep 10 11:24:45 mis-mike-wstn kernel: nfs: server fs not responding, still trying
Sep 10 11:24:47 mis-mike-wstn last message repeated 2 times
Sep 10 11:24:47 mis-mike-wstn kernel: nfs: server fs OK
Sep 10 11:24:47 mis-mike-wstn last message repeated 2 times
Sep 10 11:29:39 mis-mike-wstn kernel: Unable to handle kernel paging request at virtual address 6b6b6b7b
Sep 10 11:29:39 mis-mike-wstn kernel:  printing eip:
Sep 10 11:29:39 mis-mike-wstn kernel: d48894dc
Sep 10 11:29:39 mis-mike-wstn kernel: *pde = 00000000
Sep 10 11:29:39 mis-mike-wstn kernel: Oops: 0000 [#1]
Sep 10 11:29:39 mis-mike-wstn kernel: PREEMPT SMP 
Sep 10 11:29:39 mis-mike-wstn kernel: CPU:    0
Sep 10 11:29:39 mis-mike-wstn kernel: EIP:    0060:[_end+339697948/1068932160]    Not tainted VLI
Sep 10 11:29:39 mis-mike-wstn kernel: EFLAGS: 00010002
Sep 10 11:29:39 mis-mike-wstn kernel: EIP is at idescsi_queue+0x59c/0x614 [ide_scsi]
Sep 10 11:29:39 mis-mike-wstn kernel: eax: 6b6b6b6b   ebx: c2050000   ecx: c2050000   edx: d3357864
Sep 10 11:29:39 mis-mike-wstn kernel: esi: d3357864   edi: c410629c   ebp: c2051d18   esp: c2051ce0
Sep 10 11:29:39 mis-mike-wstn kernel: ds: 007b   es: 007b   ss: 0068
Sep 10 11:29:39 mis-mike-wstn kernel: Process cp (pid: 29140, threadinfo=c2050000 task=ca90e000)
Sep 10 11:29:39 mis-mike-wstn kernel: Stack: d3a94540 00000293 d3a9451c d3a9451c c9e92c00 d33578b8 c461c18c c13cdca0 
Sep 10 11:29:39 mis-mike-wstn kernel:        ffffffff 00000000 d3a946d8 c9e92c00 c410629c c0487b58 c2051d38 c026cf08 
Sep 10 11:29:39 mis-mike-wstn kernel:        d3357864 c026d0d0 c2050000 d3357864 d3680304 00000000 c2051d58 c02724dd 
Sep 10 11:29:39 mis-mike-wstn kernel: Call Trace:
Sep 10 11:29:39 mis-mike-wstn kernel:  [scsi_dispatch_cmd+556/676] scsi_dispatch_cmd+0x22c/0x2a4
Sep 10 11:29:39 mis-mike-wstn kernel:  [scsi_done+0/108] scsi_done+0x0/0x6c
Sep 10 11:29:39 mis-mike-wstn kernel:  [scsi_request_fn+713/1036] scsi_request_fn+0x2c9/0x40c
Sep 10 11:29:39 mis-mike-wstn kernel:  [generic_unplug_device+132/216] generic_unplug_device+0x84/0xd8
Sep 10 11:29:39 mis-mike-wstn kernel:  [blk_run_queues+270/424] blk_run_queues+0x10e/0x1a8
Sep 10 11:29:39 mis-mike-wstn kernel:  [block_sync_page+8/16] block_sync_page+0x8/0x10
Sep 10 11:29:39 mis-mike-wstn kernel:  [wait_on_page_bit_wq+169/228] wait_on_page_bit_wq+0xa9/0xe4
Sep 10 11:29:39 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:39 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_generic_mapping_read+770/1156] do_generic_mapping_read+0x302/0x484
Sep 10 11:29:39 mis-mike-wstn kernel:  [__generic_file_aio_read+478/508] __generic_file_aio_read+0x1de/0x1fc
Sep 10 11:29:39 mis-mike-wstn kernel:  [file_read_actor+0/224] file_read_actor+0x0/0xe0
Sep 10 11:29:39 mis-mike-wstn kernel:  [generic_file_read+171/200] generic_file_read+0xab/0xc8
Sep 10 11:29:39 mis-mike-wstn kernel:  [_end+341016069/1068932160] rpcauth_lookupcred+0x75/0x80 [sunrpc]
Sep 10 11:29:39 mis-mike-wstn kernel:  [cp_new_stat64+224/248] cp_new_stat64+0xe0/0xf8
Sep 10 11:29:39 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:39 mis-mike-wstn kernel:  [sys_fstat64+37/44] sys_fstat64+0x25/0x2c
Sep 10 11:29:39 mis-mike-wstn kernel:  [vfs_read+183/240] vfs_read+0xb7/0xf0
Sep 10 11:29:39 mis-mike-wstn kernel:  [sys_read+48/80] sys_read+0x30/0x50
Sep 10 11:29:39 mis-mike-wstn kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Sep 10 11:29:39 mis-mike-wstn kernel:  [ip_mc_source+583/892] ip_mc_source+0x247/0x37c
Sep 10 11:29:39 mis-mike-wstn kernel: 
Sep 10 11:29:39 mis-mike-wstn kernel: Code: 08 00 00 00 74 09 e8 a8 6e 89 eb 8d 74 26 00 6a 04 8b 7d f8 57 8b 45 fc 50 e8 01 39 9d eb 83 c4 0c fa ff 43 14 8b 55 08 8b 42 04 <8b> 40 10 8b 58 2c 81 7b 04 ad 4e ad de 74 17 68 e2 94 88 d4 68 
Sep 10 11:29:39 mis-mike-wstn kernel:  <6>note: cp[29140] exited with preempt_count 1
Sep 10 11:29:39 mis-mike-wstn kernel: Debug: sleeping function called from invalid context at include/asm/semaphore.h:119
Sep 10 11:29:39 mis-mike-wstn kernel: Call Trace:
Sep 10 11:29:39 mis-mike-wstn kernel:  [__might_sleep+99/104] __might_sleep+0x63/0x68
Sep 10 11:29:39 mis-mike-wstn kernel:  [remove_shared_vm_struct+43/132] remove_shared_vm_struct+0x2b/0x84
Sep 10 11:29:39 mis-mike-wstn kernel:  [exit_mmap+485/552] exit_mmap+0x1e5/0x228
Sep 10 11:29:39 mis-mike-wstn kernel:  [mmput+174/204] mmput+0xae/0xcc
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_exit+498/1332] do_exit+0x1f2/0x534
Sep 10 11:29:39 mis-mike-wstn kernel:  [die+351/352] die+0x15f/0x160
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_page_fault+733/1045] do_page_fault+0x2dd/0x415
Sep 10 11:29:39 mis-mike-wstn kernel:  [_end+339697948/1068932160] idescsi_queue+0x59c/0x614 [ide_scsi]
Sep 10 11:29:39 mis-mike-wstn kernel:  [do_page_fault+0/1045] do_page_fault+0x0/0x415
Sep 10 11:29:40 mis-mike-wstn kernel:  [recalc_task_prio+377/392] recalc_task_prio+0x179/0x188
Sep 10 11:29:40 mis-mike-wstn kernel:  [schedule+1404/1760] schedule+0x57c/0x6e0
Sep 10 11:29:40 mis-mike-wstn kernel:  [preempt_schedule+43/72] preempt_schedule+0x2b/0x48
Sep 10 11:29:40 mis-mike-wstn kernel:  [ide_do_drive_cmd+354/399] ide_do_drive_cmd+0x162/0x18f
Sep 10 11:29:40 mis-mike-wstn kernel:  [error_code+47/64] error_code+0x2f/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [_end+339697948/1068932160] idescsi_queue+0x59c/0x614 [ide_scsi]
Sep 10 11:29:40 mis-mike-wstn kernel:  [scsi_dispatch_cmd+556/676] scsi_dispatch_cmd+0x22c/0x2a4
Sep 10 11:29:40 mis-mike-wstn kernel:  [scsi_done+0/108] scsi_done+0x0/0x6c
Sep 10 11:29:40 mis-mike-wstn kernel:  [scsi_request_fn+713/1036] scsi_request_fn+0x2c9/0x40c
Sep 10 11:29:40 mis-mike-wstn kernel:  [generic_unplug_device+132/216] generic_unplug_device+0x84/0xd8
Sep 10 11:29:40 mis-mike-wstn kernel:  [blk_run_queues+270/424] blk_run_queues+0x10e/0x1a8
Sep 10 11:29:40 mis-mike-wstn kernel:  [block_sync_page+8/16] block_sync_page+0x8/0x10
Sep 10 11:29:40 mis-mike-wstn kernel:  [wait_on_page_bit_wq+169/228] wait_on_page_bit_wq+0xa9/0xe4
Sep 10 11:29:40 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [do_generic_mapping_read+770/1156] do_generic_mapping_read+0x302/0x484
Sep 10 11:29:40 mis-mike-wstn kernel:  [__generic_file_aio_read+478/508] __generic_file_aio_read+0x1de/0x1fc
Sep 10 11:29:40 mis-mike-wstn kernel:  [file_read_actor+0/224] file_read_actor+0x0/0xe0
Sep 10 11:29:40 mis-mike-wstn kernel:  [generic_file_read+171/200] generic_file_read+0xab/0xc8
Sep 10 11:29:40 mis-mike-wstn kernel:  [_end+341016069/1068932160] rpcauth_lookupcred+0x75/0x80 [sunrpc]
Sep 10 11:29:40 mis-mike-wstn kernel:  [cp_new_stat64+224/248] cp_new_stat64+0xe0/0xf8
Sep 10 11:29:40 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 10 11:29:40 mis-mike-wstn kernel:  [sys_fstat64+37/44] sys_fstat64+0x25/0x2c
Sep 10 11:29:40 mis-mike-wstn kernel:  [vfs_read+183/240] vfs_read+0xb7/0xf0
Sep 10 11:29:40 mis-mike-wstn kernel:  [sys_read+48/80] sys_read+0x30/0x50
Sep 10 11:29:40 mis-mike-wstn kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Sep 10 11:29:40 mis-mike-wstn kernel:  [ip_mc_source+583/892] ip_mc_source+0x247/0x37c

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Mike Fedyk]

On Wed, Sep 10, 2003 at 11:43:46AM -0700, Andrew Morton wrote:
> Mike Fedyk <mfedyk@matchmail.com> wrote:
> >
> > I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 
> 
> ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being

Ok, I gotcha.

> kept around for weirdo things like IDE-based tape drives, scanners, etc.
> 

But will those devices hit the same code paths that my cp did?

> Just use /dev/hdX directly.

Will do. (actually doing.  I have a really bad cd-rom that insists on
spinning down after each request -- or maybe large seek, not sure.  Needs
replacement.)

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Martin J. Bligh]

>> I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 
> 
> ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being
> kept around for weirdo things like IDE-based tape drives, scanners, etc.
> 
> Just use /dev/hdX directly.

That's a real shame ... it seemed to work fine until recently. Some
of the DVD writers (eg the one I have - Sony DRU500A or whatever)
need it. Is it unfixable? or just nobody's done it?

M.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Murray J. Root]

On Wed, Sep 10, 2003 at 01:04:03PM -0700, Martin J. Bligh wrote:
> >> I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 
> > 
> > ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being
> > kept around for weirdo things like IDE-based tape drives, scanners, etc.
> > 
> > Just use /dev/hdX directly.
> 
> That's a real shame ... it seemed to work fine until recently. Some
> of the DVD writers (eg the one I have - Sony DRU500A or whatever)
> need it. Is it unfixable? or just nobody's done it?
> 

I hope it's working in test5 - it works in test4. I need it for my Sony CD 
writer, since without it cdrecord doesn't think it has write capability.

-- 
Murray J. Root

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Paul Larson]

On Wed, 2003-09-10 at 15:04, Martin J. Bligh wrote:
> >> I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 
> > 
> > ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being
> > kept around for weirdo things like IDE-based tape drives, scanners, etc.
> > 
> > Just use /dev/hdX directly.
> 
> That's a real shame ... it seemed to work fine until recently. Some
> of the DVD writers (eg the one I have - Sony DRU500A or whatever)
> need it. Is it unfixable? or just nobody's done it?
If it is going to be left to rot, then should there be a CONFIG_OBSOLETE
(or something to that effect) for things that are being considered for
removal?  This would be in the same spirit as CONFIG_CLEAN_COMPILE and
would give people a chance to yell if they have a legitimate case to
continue support.

-Paul Larson

Sandisk WiFi + CF card question

[J.C. Wren]

	Perhaps not the most appropriate place to but I know someone here will know:  
Has anyone found specs for the Sandisk WiFi + CF card?  We're trying to 
figure out if the electronics on our CF slot will support it.  I'm trying to 
determine if the CF card is run as an IDE interface, or a block memory 
interface, and which interface method is used to talk to the Prizm chipset.

	Sandisk has been remarkably unforthcoming about answering emails.

	--John

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Jens Axboe]

On Wed, Sep 10 2003, Martin J. Bligh wrote:
> >> I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 
> > 
> > ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being
> > kept around for weirdo things like IDE-based tape drives, scanners, etc.
> > 
> > Just use /dev/hdX directly.
> 
> That's a real shame ... it seemed to work fine until recently. Some
> of the DVD writers (eg the one I have - Sony DRU500A or whatever)

Then maybe it would be a really good idea to find out why it doesn't
work with ide-cd. What are the symptoms?

> need it. Is it unfixable? or just nobody's done it?

It's not unfixable, there's just not a lot of motivation to fix it since
it's basically dead.

-- 
Jens Axboe

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Gerhard Mack]

On Thu, 11 Sep 2003, Jens Axboe wrote:

> On Wed, Sep 10 2003, Martin J. Bligh wrote:
> > That's a real shame ... it seemed to work fine until recently. Some
> > of the DVD writers (eg the one I have - Sony DRU500A or whatever)
>
> Then maybe it would be a really good idea to find out why it doesn't
> work with ide-cd. What are the symptoms?
>
> > need it. Is it unfixable? or just nobody's done it?
>
> It's not unfixable, there's just not a lot of motivation to fix it since
> it's basically dead.
>

What about backwards compatability with all of that cd burning software
out there that only knows to scan the SCSI devices?

	Gerhard

--
Gerhard Mack

gmack@innerfire.net

<>< As a computer I find your faith in technology amusing.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Alan Cox]

On Mer, 2003-09-10 at 20:10, Mike Fedyk wrote:
> On Wed, Sep 10, 2003 at 11:43:46AM -0700, Andrew Morton wrote:
> > Mike Fedyk <mfedyk@matchmail.com> wrote:
> > >
> > > I have another oops for you with 2.6.0-test4-mm3-1 and ide-scsi. 
> > 
> > ide-scsi is a dead duck.  defunct.  kaput.  Don't use it.  It's only being
> 
> Ok, I gotcha.
> 
> > kept around for weirdo things like IDE-based tape drives, scanners, etc.
> > 
> 
> But will those devices hit the same code paths that my cp did?

Yes so it does still need fixing.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Alan Cox]

On Iau, 2003-09-11 at 09:20, Jens Axboe wrote:
> > need it. Is it unfixable? or just nobody's done it?
> 
> It's not unfixable, there's just not a lot of motivation to fix it since
> it's basically dead.

Almost all IDE tape drives require ide-scsi/st modules for one.  I'm not
sure of the problems in the 2.5 case, in the 2.4 case the big one was
that both IDE and SCSI want to control reset/recovery and reissue of
commands. That turns into a nasty mess and 2.4 now lets the IDE layer do
it, with SCSI just backing off. That may well be the right model for
2.5.x - ie the reset eh handler just waits for the IDE layer to kill the
command. The other one was races in the reset code which 2.4 I think now
has fixed, which will bite non scsi users but less often

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Martin J. Bligh]

>> That's a real shame ... it seemed to work fine until recently. Some
>> of the DVD writers (eg the one I have - Sony DRU500A or whatever)
> 
> Then maybe it would be a really good idea to find out why it doesn't
> work with ide-cd. What are the symptoms?

Symptoms are that it required cdrecord-pro, which was a closed source
piece of turd I can't do much with ;-)

M.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Mike Fedyk]

On Thu, Sep 11, 2003 at 11:13:02AM -0700, Martin J. Bligh wrote:
> >> That's a real shame ... it seemed to work fine until recently. Some
> >> of the DVD writers (eg the one I have - Sony DRU500A or whatever)
> > 
> > Then maybe it would be a really good idea to find out why it doesn't
> > work with ide-cd. What are the symptoms?
> 
> Symptoms are that it required cdrecord-pro, which was a closed source
> piece of turd I can't do much with ;-)

Are you using the version of cdrecord with Linus' patch when he added CDR capability to
ide-cd?

I know it has been in debian testing for a while now...

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Jens Axboe]

On Thu, Sep 11 2003, Alan Cox wrote:
> On Iau, 2003-09-11 at 09:20, Jens Axboe wrote:
> > > need it. Is it unfixable? or just nobody's done it?
> > 
> > It's not unfixable, there's just not a lot of motivation to fix it since
> > it's basically dead.
> 
> Almost all IDE tape drives require ide-scsi/st modules for one.  I'm not

Big deal, 99% of ide-scsi use is for cd burning. But yes, it should be
fixed. I'm not disagreeing, I just don't think it's a high prio item.
And apparently noone else thinks so either, if not it would have been
fixed a long time ago (it's been broken for how long now?)

> sure of the problems in the 2.5 case, in the 2.4 case the big one was
> that both IDE and SCSI want to control reset/recovery and reissue of
> commands. That turns into a nasty mess and 2.4 now lets the IDE layer do
> it, with SCSI just backing off. That may well be the right model for
> 2.5.x - ie the reset eh handler just waits for the IDE layer to kill the
> command. The other one was races in the reset code which 2.4 I think now
> has fixed, which will bite non scsi users but less often

Just needs someone to do it. Once it bugs someone enough, that someone
will do it. Until then, it remains broken :)

-- 
Jens Axboe

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Jens Axboe]

On Thu, Sep 11 2003, Gerhard Mack wrote:
> On Thu, 11 Sep 2003, Jens Axboe wrote:
> 
> > On Wed, Sep 10 2003, Martin J. Bligh wrote:
> > > That's a real shame ... it seemed to work fine until recently. Some
> > > of the DVD writers (eg the one I have - Sony DRU500A or whatever)
> >
> > Then maybe it would be a really good idea to find out why it doesn't
> > work with ide-cd. What are the symptoms?
> >
> > > need it. Is it unfixable? or just nobody's done it?
> >
> > It's not unfixable, there's just not a lot of motivation to fix it since
> > it's basically dead.
> >
> 
> What about backwards compatability with all of that cd burning software
> out there that only knows to scan the SCSI devices?

That's basically impossible, I don't want to shoe horn atapi numbering
into faked bus,id,lun type things.

So people will just have to get used to the change. And I bet that Joe
user with his cd-r thinks it's a lot more intuitive to use dev=/dev/hdc
(which is his burner) rather than dev=1,0,0 for instance. The scanning
basically helps that case alone, because noone can guess these numbers.

-- 
Jens Axboe

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Jens Axboe]

On Thu, Sep 11 2003, Martin J. Bligh wrote:
> >> That's a real shame ... it seemed to work fine until recently. Some
> >> of the DVD writers (eg the one I have - Sony DRU500A or whatever)
> > 
> > Then maybe it would be a really good idea to find out why it doesn't
> > work with ide-cd. What are the symptoms?
> 
> Symptoms are that it required cdrecord-pro, which was a closed source
> piece of turd I can't do much with ;-)

Surely the pro version supports open-by-device as well? And then it
should work fine.

-- 
Jens Axboe

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Ian Hastie]

On Thursday 11 Sep 2003 22:52, Jens Axboe wrote:
> On Thu, Sep 11 2003, Martin J. Bligh wrote:
> >
> > Symptoms are that it required cdrecord-pro, which was a closed source
> > piece of turd I can't do much with ;-)
>
> Surely the pro version supports open-by-device as well? And then it
> should work fine.

It does.  However it also produces the same error message as cdrecord when 
doing so, ie

Warning: Open by 'devname' is unintentional and not supported.

The implication being that it could go away or become broken at any time.

-- 
Ian.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Jens Axboe]

On Tue, Sep 16 2003, Ian Hastie wrote:
> On Thursday 11 Sep 2003 22:52, Jens Axboe wrote:
> > On Thu, Sep 11 2003, Martin J. Bligh wrote:
> > >
> > > Symptoms are that it required cdrecord-pro, which was a closed source
> > > piece of turd I can't do much with ;-)
> >
> > Surely the pro version supports open-by-device as well? And then it
> > should work fine.
> 
> It does.  However it also produces the same error message as cdrecord when 
> doing so, ie
> 
> Warning: Open by 'devname' is unintentional and not supported.
> 
> The implication being that it could go away or become broken at any time.

I wouldn't read anything in to that if I were you. Joerg has some mis
guided ideas about ATAPI addressing, but he would be a fool to remove
open by devname at this point.

-- 
Jens Axboe

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Ian Hastie]

On Tuesday 16 Sep 2003 10:20, Jens Axboe wrote:
> On Tue, Sep 16 2003, Ian Hastie wrote:
> > On Thursday 11 Sep 2003 22:52, Jens Axboe wrote:
> > > Surely the pro version supports open-by-device as well? And then it
> > > should work fine.
> >
> > It does.  However it also produces the same error message as cdrecord
> > when doing so, ie
> >
> > Warning: Open by 'devname' is unintentional and not supported.
> >
> > The implication being that it could go away or become broken at any time.
>
> I wouldn't read anything in to that if I were you. Joerg has some mis
> guided ideas about ATAPI addressing, but he would be a fool to remove
> open by devname at this point.

What about this version of the argument then?  There are a number if pieces of 
software, eg cdrdao, that don't support open by devname.  The kernel 
developers would be foolish to remove support for them at this time.  Works 
both ways doesn't it.

-- 
Ian.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Mike Fedyk]

On Tue, Sep 16, 2003 at 07:26:02PM +0100, Ian Hastie wrote:
> On Tuesday 16 Sep 2003 10:20, Jens Axboe wrote:
> > On Tue, Sep 16 2003, Ian Hastie wrote:
> > > On Thursday 11 Sep 2003 22:52, Jens Axboe wrote:
> > > > Surely the pro version supports open-by-device as well? And then it
> > > > should work fine.
> > >
> > > It does.  However it also produces the same error message as cdrecord
> > > when doing so, ie
> > >
> > > Warning: Open by 'devname' is unintentional and not supported.
> > >
> > > The implication being that it could go away or become broken at any time.
> >
> > I wouldn't read anything in to that if I were you. Joerg has some mis
> > guided ideas about ATAPI addressing, but he would be a fool to remove
> > open by devname at this point.
> 
> What about this version of the argument then?  There are a number if pieces of 
> software, eg cdrdao, that don't support open by devname.  The kernel 
> developers would be foolish to remove support for them at this time.  Works 
> both ways doesn't it.

This is one example where the kernel is pushing userspace forward.  There's
no need to add any drag to the momentum in this case.

Let's get those userspace apps converted over.  It will make many things
simpler.  Including other user space apps.

Re: OOps in HFS was: 2.6.0-test4-mm3

[Andrew Morton]

Mike Fedyk <mfedyk@matchmail.com> wrote:
>
> Just reading a hfs floppy...

It's not an oops - it's a warning.

> Sep 15 10:10:49 mis-mike-wstn kernel: inserting floppy driver for 2.6.0-test4-mm3-1-mdfail
> Sep 15 10:10:49 mis-mike-wstn kernel: Floppy drive(s): fd0 is 1.44M
> Sep 15 10:10:49 mis-mike-wstn kernel: FDC 0 is a post-1991 82077
> Sep 15 10:10:49 mis-mike-wstn kernel: PM: Adding info for platform:floppy0
> Sep 15 10:11:14 mis-mike-wstn kernel: Debug: sleeping function called from invalid context at mm/slab.c:1833
> Sep 15 10:11:14 mis-mike-wstn kernel: Call Trace:
> Sep 15 10:11:14 mis-mike-wstn kernel:  [__might_sleep+99/104] __might_sleep+0x63/0x68
> Sep 15 10:11:15 mis-mike-wstn kernel:  [kmem_cache_alloc+37/324] kmem_cache_alloc+0x25/0x144
> Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340461616/1068932160] grow_entries+0x24/0xa0 [hfs]
> Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340462938/1068932160] get_new_entry+0x1e/0x460 [hfs]

get_entry() does disk I/O under spin_lock(&entry_lock).  Deadlock country.
A simple fix would be to convert entry_lock into a semaphore.

> Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c261451c
> Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: cc08f104
> Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c7997ccc
> Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c6cb9728

Well that's not very good.  Can you make an image of that floppy available for download?

Does 2.4's HFS driver work OK?

OOps in HFS was: 2.6.0-test4-mm3

[Mike Fedyk]

Just reading a hfs floppy...

Sep 15 10:10:49 mis-mike-wstn kernel: inserting floppy driver for 2.6.0-test4-mm3-1-mdfail
Sep 15 10:10:49 mis-mike-wstn kernel: Floppy drive(s): fd0 is 1.44M
Sep 15 10:10:49 mis-mike-wstn kernel: FDC 0 is a post-1991 82077
Sep 15 10:10:49 mis-mike-wstn kernel: PM: Adding info for platform:floppy0
Sep 15 10:11:14 mis-mike-wstn kernel: Debug: sleeping function called from invalid context at mm/slab.c:1833
Sep 15 10:11:14 mis-mike-wstn kernel: Call Trace:
Sep 15 10:11:14 mis-mike-wstn kernel:  [__might_sleep+99/104] __might_sleep+0x63/0x68
Sep 15 10:11:15 mis-mike-wstn kernel:  [kmem_cache_alloc+37/324] kmem_cache_alloc+0x25/0x144
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340461616/1068932160] grow_entries+0x24/0xa0 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340462938/1068932160] get_new_entry+0x1e/0x460 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340463557/1068932160] get_new_entry+0x289/0x460 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [queue_work+256/268] queue_work+0x100/0x10c
Sep 15 10:11:15 mis-mike-wstn kernel:  [recalc_task_prio+377/392] recalc_task_prio+0x179/0x188
Sep 15 10:11:15 mis-mike-wstn kernel:  [schedule+1404/1760] schedule+0x57c/0x6e0
Sep 15 10:11:15 mis-mike-wstn kernel:  [__wait_on_buffer_wq+212/224] __wait_on_buffer_wq+0xd4/0xe0
Sep 15 10:11:15 mis-mike-wstn kernel:  [autoremove_wake_function+0/64] autoremove_wake_function+0x0/0x40
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340462806/1068932160] find_entry+0x1a/0x80 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340464113/1068932160] get_entry+0x55/0xc0 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340465538/1068932160] hfs_cat_get+0x12/0x18 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340506273/1068932160] hfs_fill_super+0x13d/0x1c7 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [disk_name+36/116] disk_name+0x24/0x74
Sep 15 10:11:15 mis-mike-wstn kernel:  [get_sb_bdev+232/308] get_sb_bdev+0xe8/0x134
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340503342/1068932160] hfs_get_sb+0x1e/0x28 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340505956/1068932160] hfs_fill_super+0x0/0x1c7 [hfs]
Sep 15 10:11:15 mis-mike-wstn kernel:  [do_kern_mount+87/252] do_kern_mount+0x57/0xfc
Sep 15 10:11:15 mis-mike-wstn kernel:  [do_add_mount+90/332] do_add_mount+0x5a/0x14c
Sep 15 10:11:15 mis-mike-wstn kernel:  [do_mount+329/352] do_mount+0x149/0x160
Sep 15 10:11:15 mis-mike-wstn kernel:  [copy_mount_options+144/264] copy_mount_options+0x90/0x108
Sep 15 10:11:15 mis-mike-wstn kernel:  [sys_mount+193/360] sys_mount+0xc1/0x168
Sep 15 10:11:15 mis-mike-wstn kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Sep 15 10:11:15 mis-mike-wstn kernel: 
Sep 15 10:11:48 mis-mike-wstn kernel: Debug: sleeping function called from invalid context at mm/slab.c:1833
Sep 15 10:11:48 mis-mike-wstn kernel: Call Trace:
Sep 15 10:11:48 mis-mike-wstn kernel:  [__might_sleep+99/104] __might_sleep+0x63/0x68
Sep 15 10:11:48 mis-mike-wstn kernel:  [kmem_cache_alloc+37/324] kmem_cache_alloc+0x25/0x144
Sep 15 10:11:48 mis-mike-wstn kernel:  [__find_get_block+185/200] __find_get_block+0xb9/0xc8
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340461616/1068932160] grow_entries+0x24/0xa0 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340462938/1068932160] get_new_entry+0x1e/0x460 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340463557/1068932160] get_new_entry+0x289/0x460 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [__wake_up+93/176] __wake_up+0x5d/0xb0
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340458195/1068932160] hfs_bnode_read+0x20b/0x218 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340458960/1068932160] hfs_bnode_find+0xe4/0x114 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [kfree+615/696] kfree+0x267/0x2b8
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340462806/1068932160] find_entry+0x1a/0x80 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340464113/1068932160] get_entry+0x55/0xc0 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340465538/1068932160] hfs_cat_get+0x12/0x18 [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [_end+340474963/1068932160] cap_lookup+0x153/0x20c [hfs]
Sep 15 10:11:48 mis-mike-wstn kernel:  [real_lookup+108/220] real_lookup+0x6c/0xdc
Sep 15 10:11:48 mis-mike-wstn kernel:  [do_lookup+71/132] do_lookup+0x47/0x84
Sep 15 10:11:48 mis-mike-wstn kernel:  [link_path_walk+1927/2684] link_path_walk+0x787/0xa7c
Sep 15 10:11:48 mis-mike-wstn kernel:  [path_lookup+449/460] path_lookup+0x1c1/0x1cc
Sep 15 10:11:48 mis-mike-wstn kernel:  [__user_walk+47/76] __user_walk+0x2f/0x4c
Sep 15 10:11:48 mis-mike-wstn kernel:  [vfs_lstat+23/68] vfs_lstat+0x17/0x44
Sep 15 10:11:48 mis-mike-wstn kernel:  [sys_lstat64+20/44] sys_lstat64+0x14/0x2c
Sep 15 10:11:48 mis-mike-wstn kernel:  [filldir64+0/308] filldir64+0x0/0x134
Sep 15 10:11:48 mis-mike-wstn kernel:  [sys_getdents64+97/166] sys_getdents64+0x61/0xa6
Sep 15 10:11:48 mis-mike-wstn kernel:  [sys_getdents64+154/166] sys_getdents64+0x9a/0xa6
Sep 15 10:11:48 mis-mike-wstn kernel:  [syscall_call+7/11] syscall_call+0x7/0xb
Sep 15 10:11:48 mis-mike-wstn kernel: 
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c261451c
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: cc08f104
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c7997ccc
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c6cb9728
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d21deac0
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d2a1b310
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c8a226a8
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c8592084
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c3aaa290
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c50bcccc
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d29e3b40
Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: cc08f934
Sep 15 10:35:34 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c6cb9934
Sep 15 10:35:34 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d2a1b728
Sep 15 10:35:34 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c1cbf51c
Sep 15 10:46:04 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c85926a8
Sep 15 17:02:56 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c2686728
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c7997ccc
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c6cb9728
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d21deac0
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d2a1b310
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c8a226a8
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c261451c
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: cc08f104
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c85926a8
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c6cb9934
Sep 15 20:04:48 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c50bcccc
Sep 15 20:04:58 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d29e3b40
Sep 15 20:04:58 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c2686728
Sep 16 04:14:49 mis-mike-wstn kernel: nfs: server fs not responding, still trying
Sep 16 04:15:01 mis-mike-wstn kernel: nfs: server fs not responding, still trying
Sep 16 04:15:16 mis-mike-wstn kernel: nfs: server fs OK
Sep 16 04:15:16 mis-mike-wstn kernel: nfs: server fs OK
Sep 16 06:25:16 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c3aaa290
Sep 16 06:25:16 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c8592084
Sep 16 06:25:16 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: cc08f934
Sep 16 06:25:46 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: d2a1b728

Re: OOps in HFS was: 2.6.0-test4-mm3

[Mike Fedyk]

On Tue, Sep 16, 2003 at 02:40:12PM -0700, Andrew Morton wrote:
> Mike Fedyk <mfedyk@matchmail.com> wrote:
> >
> > Just reading a hfs floppy...
> 
> It's not an oops - it's a warning.
> 

Oh, sorry, I didn't notice.  Will try harder next time. ;)

> > Sep 15 10:10:49 mis-mike-wstn kernel: inserting floppy driver for 2.6.0-test4-mm3-1-mdfail
> > Sep 15 10:10:49 mis-mike-wstn kernel: Floppy drive(s): fd0 is 1.44M
> > Sep 15 10:10:49 mis-mike-wstn kernel: FDC 0 is a post-1991 82077
> > Sep 15 10:10:49 mis-mike-wstn kernel: PM: Adding info for platform:floppy0
> > Sep 15 10:11:14 mis-mike-wstn kernel: Debug: sleeping function called from invalid context at mm/slab.c:1833
> > Sep 15 10:11:14 mis-mike-wstn kernel: Call Trace:
> > Sep 15 10:11:14 mis-mike-wstn kernel:  [__might_sleep+99/104] __might_sleep+0x63/0x68
> > Sep 15 10:11:15 mis-mike-wstn kernel:  [kmem_cache_alloc+37/324] kmem_cache_alloc+0x25/0x144
> > Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340461616/1068932160] grow_entries+0x24/0xa0 [hfs]
> > Sep 15 10:11:15 mis-mike-wstn kernel:  [_end+340462938/1068932160] get_new_entry+0x1e/0x460 [hfs]
> 
> get_entry() does disk I/O under spin_lock(&entry_lock).  Deadlock country.
> A simple fix would be to convert entry_lock into a semaphore.
> 

Maybe.  It's a client diskette.  Would it be ok if a couple files were
truncated or filled with zeros?

> > Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c261451c
> > Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: cc08f104
> > Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c7997ccc
> > Sep 15 10:21:11 mis-mike-wstn kernel: hfs_cat_put: trying to free free entry: c6cb9728
> 
> Well that's not very good.  Can you make an image of that floppy available for download?
> 
> Does 2.4's HFS driver work OK?

I will give that a try.

Re: ide-scsi oops was: 2.6.0-test4-mm3

[Jens Axboe]

On Tue, Sep 16 2003, Ian Hastie wrote:
> On Tuesday 16 Sep 2003 10:20, Jens Axboe wrote:
> > On Tue, Sep 16 2003, Ian Hastie wrote:
> > > On Thursday 11 Sep 2003 22:52, Jens Axboe wrote:
> > > > Surely the pro version supports open-by-device as well? And then it
> > > > should work fine.
> > >
> > > It does.  However it also produces the same error message as cdrecord
> > > when doing so, ie
> > >
> > > Warning: Open by 'devname' is unintentional and not supported.
> > >
> > > The implication being that it could go away or become broken at any time.
> >
> > I wouldn't read anything in to that if I were you. Joerg has some mis
> > guided ideas about ATAPI addressing, but he would be a fool to remove
> > open by devname at this point.
> 
> What about this version of the argument then?  There are a number if
> pieces of software, eg cdrdao, that don't support open by devname.
> The kernel developers would be foolish to remove support for them at
> this time.  Works both ways doesn't it.

(cc me if you want me to read the mails, thanks)

That's a different discussion - they don't work with SG_IO typically
either, so they await the block sg driver anyways. It doesn't change the
fact that trying to pretend devices are hanging off a SCSI bus with bus
and device ids when they are not is just horrible.

-- 
Jens Axboe

Re: 2.6.0-test4-mm3

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

On Tue, 02 Sep 2003 06:14:04 +0200, Martin Schlemmer said:

> The problem I have with the patch you had here, is you changed:
> 
> DEPMOD         = /sbin/depmod
> 
> to:
> 
> DEPMOD         = /sbin/depmod.old
> 
> which is only the one from module-init-tools on a RH system ....

Damn.  Somebody hand me a brown paper bag. :)

(Make note to self - next time, diff the right 2 versions, not the testing version ;)

I got misdirected by your comment "this will only work with RH based systems",
because (a) neither the RH9 or Rawhide tools include a depmod.old, (b)
depmod.old gets created on non-Redhat systems if you install the Rusty version,
and (c) using depmod.old *wont* work - so I totally failed to notice I'd
botched the value of $DEPMOD. ;)


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.0-test4-mm3

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Tue, 2003-09-02 at 01:52, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 01 Sep 2003 22:23:30 +0200, Martin Schlemmer said:
> 
> > > +		if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE
> )   ; t=
> > hen \
> > > +			echo "*** Depmod failed!!!"; \
> > > +			echo "*** You may need to install a current version of 
> module-init-to=
> > ols"; \
> > > +			echo "*** See http://www.codemonkey.org.uk/post-hallowe
> en-2.5.txt"; \
> > > +			exit 1; \
> > > +	 	fi \
> > > +	fi
> > > =20
> > >  else # CONFIG_MODULES
> > 
> > Hmm, this will only work with RH based systems (not using here).  I
> > think the best way is how Andrew did it to just warn if depmod fails.
> > You may agree to disagree if need be :)
> 
> Umm.. how will this fail for *any* system that has a sane 'depmod' (sane as in
> "calls exit(0) if it worked"?  In this patch we never actually check the
> version - we just add code that "if depmod fails during 'make install_modules',
> it may be too old and give them a hint".
> 

The problem I have with the patch you had here, is you changed:

DEPMOD         = /sbin/depmod

to:

DEPMOD         = /sbin/depmod.old

which is only the one from module-init-tools on a RH system ....


Cheers,

-- 

Martin Schlemmer




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.0-test4-mm3

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Mon, 01 Sep 2003 22:23:30 +0200, Martin Schlemmer said:

> > +		if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE
)   ; t=
> hen \
> > +			echo "*** Depmod failed!!!"; \
> > +			echo "*** You may need to install a current version of 
module-init-to=
> ols"; \
> > +			echo "*** See http://www.codemonkey.org.uk/post-hallowe
en-2.5.txt"; \
> > +			exit 1; \
> > +	 	fi \
> > +	fi
> > =20
> >  else # CONFIG_MODULES
> 
> Hmm, this will only work with RH based systems (not using here).  I
> think the best way is how Andrew did it to just warn if depmod fails.
> You may agree to disagree if need be :)

Umm.. how will this fail for *any* system that has a sane 'depmod' (sane as in
"calls exit(0) if it worked"?  In this patch we never actually check the
version - we just add code that "if depmod fails during 'make install_modules',
it may be too old and give them a hint".

(Incidentally, I tested it with the RH9 depmod, the Rusty depmod,  and the
Rawhide depmod - for Rusty and Rawhide it was silent, the older RH9 depmod
barfed and then gave the hint...)


[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.0-test4-mm3

[Sam Ravnborg]

On Mon, Sep 01, 2003 at 10:23:30PM +0200, Martin Schlemmer wrote:
> 
> Hmm, this will only work with RH based systems (not using here).  I
> think the best way is how Andrew did it to just warn if depmod fails.
> You may agree to disagree if need be :)

Andrew's version is already in mainline.

	Sam

Re: 2.6.0-test4-mm3

[Martin Schlemmer]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On Fri, 2003-08-29 at 17:53, Valdis.Kletnieks@vt.edu wrote:
> On Fri, 29 Aug 2003 16:55:47 +0200, Martin Schlemmer said:
> 
> > Cannot think of one that is known.  An quick solution
> > your (and not RH) side, might be something like below.
> 
> What about something like this instead?  I tested it with the module-init-tools
> and stock RH9 depmods...
> 
> Only complain if the depmod actually fails:
> 
> --- Makefile.hold	2003-08-27 01:52:20.000000000 -0400
> +++ Makefile	2003-08-29 11:52:15.542286300 -0400
> @@ -209,7 +209,7 @@
>  RPM 		:= $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
>  		    	else echo rpm; fi)
>  GENKSYMS	= scripts/genksyms/genksyms
> -DEPMOD		= /sbin/depmod
> +DEPMOD		= /sbin/depmod.old
>  KALLSYMS	= scripts/kallsyms
>  PERL		= perl
>  CHECK		= sparse
> @@ -612,7 +612,14 @@
>  endif
>  .PHONY: _modinst_post
>  _modinst_post: _modinst_
> -	if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi
> +	@if [ -r System.map ]; then \
> +		if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE)   ; then \
> +			echo "*** Depmod failed!!!"; \
> +			echo "*** You may need to install a current version of module-init-tools"; \
> +			echo "*** See http://www.codemonkey.org.uk/post-halloween-2.5.txt"; \
> +			exit 1; \
> +	 	fi \
> +	fi
>  
>  else # CONFIG_MODULES

Hmm, this will only work with RH based systems (not using here).  I
think the best way is how Andrew did it to just warn if depmod fails.
You may agree to disagree if need be :)


Regards,

-- 

Martin Schlemmer




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: 2.6.0-test4-mm3

[Martin Schlemmer]

On Fri, 2003-08-29 at 16:55, Martin Schlemmer wrote:
> On Fri, 2003-08-29 at 15:00, Valdis.Kletnieks@vt.edu wrote:
> > On Fri, 29 Aug 2003 11:54:27 +0200, Boszormenyi Zoltan <zboszor@freemail.hu>  said:
> > 
> > > I tried to "make modules_install" on the compiled tree.
> > > It says:
> > > 
> > > # make modules_install
> > > Install a current version of module-init-tools
> > > See http://www.codemonkey.org.uk/post-halloween-2.5.txt
> > > make: *** [_modinst_] Error 1
> > 
> > Whoops... My fault. ;)
> > 
> > It was mostly a proof of concept - if there's a *known*
> > better test I'm all ears. ;)
> 
> Cannot think of one that is known.  An quick solution
> your (and not RH) side, might be something like below.
> I am though not 100% sure if this will work (does the RH
> patches check for modules present before calling bins
> from module-init-tools, or do they just yield if they
> detect a newer kernel?), so if somebody on a RH box could
> test it ...
> 
> The basic concept is that modprobe from modutils start
> an error message with 'modprobe:' and the one from
> module-init-tools starts with 'FATAL:'.
> 
> Another issue you may want to consider, is that modprobe
> from module-init-tools use the 'create_module' syscall
> to determine the kernel version, and I think that the RH
> patches does as well .... what are you going to do if its
> a 2.4 kernel running, but module-init-tools are installed?
> In this case even my patch are going to fail.  I guess thus
> that you will have to try and get Boszormenyi's changes
> applied RH side ...
> 
> ---------------
> iff -puN Makefile~old-module-tools-warning Makefile
> --- 25/Makefile~old-module-tools-warning	Thu Aug 28 14:24:35 2003
> +++ 25-akpm/Makefile	Thu Aug 28 14:24:35 2003
> @@ -606,6 +606,11 @@ modules_install: _modinst_ _modinst_post
>  
>  .PHONY: _modinst_
>  _modinst_:
> +	@if [ -z "`modprobe -n foobar 2>&1 | egrep '^FATAL:'`" ]; then \
> +		echo "Install a current version of module-init-tools"; \
> +		echo "See http://www.codemonkey.org.uk/post-halloween-2.5.txt";\
> +		/bin/false; \
> +	fi
>  	@rm -rf $(MODLIB)/kernel
>  	@rm -f $(MODLIB)/build
>  	@mkdir -p $(MODLIB)/kernel
> 
----------------------

Seems like above never made it out.  Anyhow, adding anything
like this that fails is no good, except maybe if it checks
current kernel, and if depmod then do not return a version
consistent with module-init-tools if we are using a 2.5/6 kernel,
fail.  Reason for this, is that even with the '-V' switch,
depmod.old will be called and the incorrect version supplied if
we are currently on a 2.4 kernel ....


Regards,

-- 
Martin Schlemmer

Re: 2.6.0-test4-mm3

[Martin Schlemmer]

On Fri, 2003-08-29 at 18:27, Cliff White wrote:

Hi

> This also breaks STP. We installed module-init-tools using the 'moveold' 
> method,
> so we can still run 2.4.
> Our depmod is in /usr/local/sbin. 
> Using /sbin/depmod hoses us. Using PATH works for us.
> 
> [root@stp1-002 linux]# depmod -V
> module-init-tools 0.9.12
> 
> [root@stp1-002 linux]# /sbin/depmod -V
> depmod version 2.4.22
> 
> [root@stp1-002 linux]# /usr/local/sbin/depmod -V
> module-init-tools 0.9.12
> 

You guys are sorda missing the point of 'moveold' ....
You want to build it with '--prefix=/' so that
both depmod and depmod.old are in /sbin ....

----------------------
workshop root # ls /sbin/depmod* -l
-rwxr-xr-x    1 root     root        58744 Aug  4 17:19 /sbin/depmod
-rwxr-xr-x    1 root     root        58712 Aug  4 13:57 /sbin/depmod.old
workshop root # ls /sbin/modprobe* -l
lrwxrwxrwx    1 root     root            6 Aug  4 17:19 /sbin/modprobe
-> insmod
lrwxrwxrwx    1 root     root           10 Aug  4 13:57
/sbin/modprobe.old -> insmod.old
lrwxrwxrwx    1 root     root           13 Aug  4 17:19
/sbin/modprobe.static -> insmod.static
workshop root # 
------------------

Any call will then thus run depmod/whatever from module-init-tools
first, and if the kernel is 2.4, etc, it will call
depmod.old/whatever ...


Regards,

-- 
Martin Schlemmer

Re: 2.6.0-test4-mm3

[Andrew Morton]

Cliff White <cliffw@osdl.org> wrote:
>
> This also breaks STP. We installed module-init-tools using the 'moveold' 
> method,
> so we can still run 2.4.
> Our depmod is in /usr/local/sbin. 
> Using /sbin/depmod hoses us. Using PATH works for us.

Hrm, but your build must be playing up already:

dhcp-140-218:/usr/src/25> grep DEPMOD Makefile
DEPMOD          = /sbin/depmod
        @if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
        if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi

> [root@stp1-002 linux]# depmod -V
> module-init-tools 0.9.12
> 
> [root@stp1-002 linux]# /sbin/depmod -V
> depmod version 2.4.22
> 
> [root@stp1-002 linux]# /usr/local/sbin/depmod -V
> module-init-tools 0.9.12
> 
> Please send patch, we'll get some tests moving.

--- 25/Makefile~old-module-tools-warning-fix	Fri Aug 29 09:31:46 2003
+++ 25-akpm/Makefile	Fri Aug 29 09:32:16 2003
@@ -609,7 +609,7 @@ _modinst_:
 	@if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
 		echo "Install a current version of module-init-tools"; \
 		echo "See http://www.codemonkey.org.uk/post-halloween-2.5.txt";\
-		/bin/false; \
+		sleep 1; \
 	fi
 	@rm -rf $(MODLIB)/kernel
 	@rm -f $(MODLIB)/build

_

Re: 2.6.0-test4-mm3

[Cliff White]

> Boszormenyi Zoltan <zboszor@freemail.hu> wrote:
> >
> > I tried to "make modules_install" on the compiled tree.
> > It says:
> > 
> > # make modules_install
> > Install a current version of module-init-tools
> > See http://www.codemonkey.org.uk/post-halloween-2.5.txt
> > make: *** [_modinst_] Error 1
> > 
> > But I have installed it! It's called modutils-2.4.25-8
> > (was -5 previously) from RH rawhide, it works on older
> > (2.6.0-test4-mm1) kernels.
> > This modutils is united with module-init-tools-0.9.12,
> > it reports version 2.4.25 but detects newer kernels and uses
> > the new module interface.
> 
> Tricky.
> 
> It's wrong of the Red Hat package to misidentify itself in this manner.
> 
> It would sort-of make sense for `depmod -V' to autodetect the kernel
> version and print either "modutils" or "module-init-utils".  But that's not
> accurate either: a `make modules_install' would fail when performed under a
> 2.4 kernel.
> 
> So yes, I think that your patch to RH modutils+module-init-tools is the best
> approach: after all, it tells the truth.
> 
> Meanwhile, I'll alter Valdis's patch so that it warns, but does not fail
> the make.
> 

This also breaks STP. We installed module-init-tools using the 'moveold' 
method,
so we can still run 2.4.
Our depmod is in /usr/local/sbin. 
Using /sbin/depmod hoses us. Using PATH works for us.

[root@stp1-002 linux]# depmod -V
module-init-tools 0.9.12

[root@stp1-002 linux]# /sbin/depmod -V
depmod version 2.4.22

[root@stp1-002 linux]# /usr/local/sbin/depmod -V
module-init-tools 0.9.12

Please send patch, we'll get some tests moving.
cliffw

> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: 2.6.0-test4-mm3

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On Fri, 29 Aug 2003 08:35:40 PDT, Andrew Morton said:

> Meanwhile, I'll alter Valdis's patch so that it warns, but does not fail
> the make.
> 

I've sent Andrew an updated patch (attached) which issues a warning if the
final depmod actually fails.  The user won't know there's a problem till the
very end of 'make modules_install', but at least it will give them a hint of
where to go for self-help.  

--- Makefile.hold	2003-08-27 01:52:20.000000000 -0400
+++ Makefile	2003-08-29 11:52:15.542286300 -0400
@@ -209,7 +209,7 @@
 RPM 		:= $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
 		    	else echo rpm; fi)
 GENKSYMS	= scripts/genksyms/genksyms
-DEPMOD		= /sbin/depmod
+DEPMOD		= /sbin/depmod.old
 KALLSYMS	= scripts/kallsyms
 PERL		= perl
 CHECK		= sparse
@@ -612,7 +612,14 @@
 endif
 .PHONY: _modinst_post
 _modinst_post: _modinst_
-	if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE); fi
+	@if [ -r System.map ]; then \
+		if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE)   ; then \
+			echo "*** Depmod failed!!!"; \
+			echo "*** You may need to install a current version of module-init-tools"; \
+			echo "*** See http://www.codemonkey.org.uk/post-halloween-2.5.txt"; \
+			exit 1; \
+	 	fi \
+	fi
 
 else # CONFIG_MODULES
 



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.0-test4-mm3

[Andrew Morton]

Boszormenyi Zoltan <zboszor@freemail.hu> wrote:
>
> I tried to "make modules_install" on the compiled tree.
> It says:
> 
> # make modules_install
> Install a current version of module-init-tools
> See http://www.codemonkey.org.uk/post-halloween-2.5.txt
> make: *** [_modinst_] Error 1
> 
> But I have installed it! It's called modutils-2.4.25-8
> (was -5 previously) from RH rawhide, it works on older
> (2.6.0-test4-mm1) kernels.
> This modutils is united with module-init-tools-0.9.12,
> it reports version 2.4.25 but detects newer kernels and uses
> the new module interface.

Tricky.

It's wrong of the Red Hat package to misidentify itself in this manner.

It would sort-of make sense for `depmod -V' to autodetect the kernel
version and print either "modutils" or "module-init-utils".  But that's not
accurate either: a `make modules_install' would fail when performed under a
2.4 kernel.

So yes, I think that your patch to RH modutils+module-init-tools is the best
approach: after all, it tells the truth.

Meanwhile, I'll alter Valdis's patch so that it warns, but does not fail
the make.

Re: 2.6.0-test4-mm3

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On Fri, 29 Aug 2003 11:54:27 +0200, Boszormenyi Zoltan <zboszor@freemail.hu>  said:

> I tried to "make modules_install" on the compiled tree.
> It says:
> 
> # make modules_install
> Install a current version of module-init-tools
> See http://www.codemonkey.org.uk/post-halloween-2.5.txt
> make: *** [_modinst_] Error 1

Whoops... My fault. ;)

It was mostly a proof of concept - if there's a *known* better test I'm all ears. ;)

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: 2.6.0-test4-mm3

[Bas Mevissen]

Boszormenyi Zoltan wrote:

> Hi,
> 
> I tried to "make modules_install" on the compiled tree.
> It says:
> 
> # make modules_install
> Install a current version of module-init-tools
> See http://www.codemonkey.org.uk/post-halloween-2.5.txt
> make: *** [_modinst_] Error 1
> 
> But I have installed it! It's called modutils-2.4.25-8
> (was -5 previously) from RH rawhide, it works on older
> (2.6.0-test4-mm1) kernels.
> This modutils is united with module-init-tools-0.9.12,
> it reports version 2.4.25 but detects newer kernels and uses
> the new module interface.
> 
> I looked the kernel Makefile and found that it greps the version
> it gets from depmod -V and wants module-init-tools.
> My fix against the rawhide modutils is attached.
> 

Can you do a diff of the Makefile between 2.6.0-test4-mm1 and ...mm3

Regards,

Bas

Re: 2.6.0-test4-mm3

[Boszormenyi Zoltan]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

Hi,

I tried to "make modules_install" on the compiled tree.
It says:

# make modules_install
Install a current version of module-init-tools
See http://www.codemonkey.org.uk/post-halloween-2.5.txt
make: *** [_modinst_] Error 1

But I have installed it! It's called modutils-2.4.25-8
(was -5 previously) from RH rawhide, it works on older
(2.6.0-test4-mm1) kernels.
This modutils is united with module-init-tools-0.9.12,
it reports version 2.4.25 but detects newer kernels and uses
the new module interface.

I looked the kernel Makefile and found that it greps the version
it gets from depmod -V and wants module-init-tools.
My fix against the rawhide modutils is attached.

-- 
Best regards,
Zoltán Böszörményi

---------------------
What did Hussein say about his knife?
One in Bush worth two in the hand.

[-- Attachment #2: modutils.spec.diff --]
[-- Type: text/plain, Size: 829 bytes --]

--- modutils.spec.old	2003-08-29 11:43:10.000000000 +0200
+++ modutils.spec	2003-08-29 11:45:06.000000000 +0200
@@ -4,7 +4,7 @@
 Summary: Kernel module management utilities.
 Name: modutils
 Version: 2.4.25
-Release: 8
+Release: 8.1
 Copyright: GPL
 Group: System Environment/Kernel
 Source: ftp://ftp.kernel.org/pub/linux/utils/kernel/modutils/v2.4/modutils-%{version}.tar.bz2
@@ -23,6 +23,7 @@
 Patch13: module-init-tools-0.9.12-depmod-leak.patch
 Patch101: modutils-2.4.18-small.patch
 Patch1000: modutils-module-init-tools.patch
+Patch1001: module-init-tools-version-hack.patch
 Exclusiveos: Linux
 Prereq: /sbin/chkconfig sh-utils
 Obsoletes: modules
@@ -58,6 +59,7 @@
 %patch12 -p1 -b .updates
 ln -s module-init-tools-%{mitver} module-init-tools
 %patch13 -p1 -b .leak
+%patch1001 -p1 -b .version
 
 %build
 autoconf-2.13

[-- Attachment #3: module-init-tools-version-hack.patch --]
[-- Type: text/plain, Size: 284 bytes --]

--- modutils-2.4.25/include/version.h.old	2003-08-29 11:41:54.000000000 +0200
+++ modutils-2.4.25/include/version.h	2003-08-29 11:41:54.000000000 +0200
@@ -1 +1 @@
-#define MODUTILS_VERSION "2.4.25"
+#define MODUTILS_VERSION "2.4.25 + module-init-tools-0.9.12 RedHat unified version"