From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: viro@parcelfarce.linux.theplanet.co.uk, paulmck@us.ibm.com,
arjan@infradead.org, linux-kernel@vger.kernel.org,
jtk@us.ibm.com, wtaber@us.ibm.com, pbadari@us.ibm.com,
markv@us.ibm.com, greghk@us.ibm.com, torvalds@osdl.org
Subject: Re: [PATCH] fs: Restore files_lock and set_fs_root exports
Date: Thu, 6 Jan 2005 16:29:28 -0800 [thread overview]
Message-ID: <20050106162928.650e9d71.akpm@osdl.org> (raw)
In-Reply-To: <20050106234123.GA27869@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
>
> > I think the exports should be restored. So does Linus ("Not that I like it
> > all that much, but I don't think we should break existing modules unless we
> > have a very specific reason to break just those modules.").
>
> No. I specificly asked the question how they're using it and they're use is
>
> a) completely buggy
> b) poking so deep in the kernel that the user falls under the GPL
> derived works clause. As a copyright holder of quite a bit of fs/*.c
> I certainly wouldn't give IBM a special exception to use it even if
> it was exported.
>
> These exports were only added for intermezzo during 2.4.x and with the
> removal of intermezzo they go. They never were a public API, and that they
> were needed at all was a managment mistake in how that code was merged.
Fine. Completely agree. Sometimes people do need to be forced to make
such changes - I don't think anyone would disagree with that.
What's under discussion here is "how to do it". Do we just remove things
when we notice them, or do we give (say) 12 months notice?
next prev parent reply other threads:[~2005-01-07 0:29 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 19:05 [PATCH] fs: Restore files_lock and set_fs_root exports Paul E. McKenney
2005-01-06 19:13 ` Christoph Hellwig
2005-01-06 20:07 ` Paul E. McKenney
2005-01-06 20:13 ` Christoph Hellwig
2005-01-06 20:35 ` Mike Waychison
2005-01-06 20:59 ` Christoph Hellwig
2005-01-06 21:35 ` Greg KH
2005-01-06 19:14 ` Al Viro
2005-01-06 20:13 ` Paul E. McKenney
2005-01-06 19:20 ` Arjan van de Ven
2005-01-06 20:15 ` Paul E. McKenney
2005-01-06 20:32 ` Al Viro
2005-01-06 21:04 ` Paul E. McKenney
2005-01-06 21:24 ` Al Viro
2005-01-06 23:26 ` Andrew Morton
2005-01-06 23:11 ` Alan Cox
2005-01-07 0:24 ` Linus Torvalds
2005-01-07 0:48 ` Christoph Hellwig
2005-01-07 7:38 ` Arjan van de Ven
2005-01-06 23:41 ` Christoph Hellwig
2005-01-07 0:29 ` Andrew Morton [this message]
2005-01-07 0:26 ` Christoph Hellwig
2005-01-07 3:30 ` Mike Waychison
2005-01-07 9:00 ` Ingo Molnar
2005-01-07 9:15 ` Christoph Hellwig
2005-01-07 12:14 ` Antonio Vargas
2005-01-07 22:00 ` Andrew Morton
2005-01-07 22:19 ` Christoph Hellwig
2005-01-07 22:58 ` Andrew Morton
2005-01-08 15:45 ` Alan Cox
2005-01-07 22:49 ` Alan Cox
2005-01-08 0:12 ` Andrew Morton
2005-01-08 2:20 ` Paul E. McKenney
2005-01-07 23:32 ` Adrian Bunk
2005-01-08 13:10 ` Al Viro
2005-01-07 1:34 ` Alan Cox
2005-01-07 3:17 ` Andrew Morton
2005-01-07 8:12 ` Christoph Hellwig
2005-01-06 23:56 ` [PATCH] add feature-removal-schedule.txt documentation Greg KH
2005-01-07 0:23 ` Christoph Hellwig
2005-01-07 0:32 ` Greg KH
2005-01-07 17:02 ` Randy.Dunlap
2005-01-07 17:54 ` Linus Torvalds
2005-01-07 18:11 ` Greg KH
2005-01-11 12:23 ` [PATCH] cpufreq 2.4 interface removal schedule [Was: Re: [PATCH] add feature-removal-schedule.txt documentation] Dominik Brodowski
2005-01-12 18:41 ` Greg KH
2005-01-07 23:58 ` [PATCH] add feature-removal-schedule.txt documentation Dominik Brodowski
2005-01-12 18:41 ` Greg KH
2005-01-08 18:32 ` Paul E. McKenney
2005-01-08 21:46 ` Alan Cox
2005-01-08 23:03 ` Arjan van de Ven
2005-01-09 6:23 ` Paul E. McKenney
2005-01-09 6:27 ` Paul E. McKenney
2005-01-07 2:02 ` [PATCH] fs: Restore files_lock and set_fs_root exports Paul E. McKenney
2005-01-07 1:01 ` Paul E. McKenney
2005-01-07 1:20 ` Al Viro
2005-01-13 2:51 ` Paul E. McKenney
2005-01-13 7:35 ` Arjan van de Ven
2005-01-13 17:53 ` Paul E. McKenney
2005-01-13 17:07 ` Greg KH
2005-01-13 17:44 ` Paul E. McKenney
2005-01-13 17:55 ` Greg KH
2005-01-13 18:29 ` Paul E. McKenney
2005-01-07 7:33 ` Arjan van de Ven
2005-01-07 8:15 ` Christoph Hellwig
2005-01-07 15:12 ` Paul E. McKenney
2005-01-07 15:23 ` Arjan van de Ven
2005-01-07 15:34 ` Paul E. McKenney
2005-01-07 15:56 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050106162928.650e9d71.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=greghk@us.ibm.com \
--cc=hch@infradead.org \
--cc=jtk@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markv@us.ibm.com \
--cc=paulmck@us.ibm.com \
--cc=pbadari@us.ibm.com \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=wtaber@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).