From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@osdl.org>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
paulmck@us.ibm.com, arjan@infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
jtk@us.ibm.com, wtaber@us.ibm.com, pbadari@us.ibm.com,
markv@us.ibm.com, greghk@us.ibm.com
Subject: Re: [PATCH] fs: Restore files_lock and set_fs_root exports
Date: Fri, 7 Jan 2005 00:48:50 +0000 [thread overview]
Message-ID: <20050107004850.GA29346@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0501061623350.2272@ppc970.osdl.org>
On Thu, Jan 06, 2005 at 04:24:58PM -0800, Linus Torvalds wrote:
> At that point there is a specific _reason_ to break it, aka "that function
> simply doesn't exist any more".
>
> I'm known for happily breaking binary modules, but I think we should do it
> only if we have a reason _other_ than "let's break a module".
Note that the function that started this thread weren't removed with nwfs
in mind - in fact I doubt anyone here has seen the module or it's
requirements.
Arjan and I have produced lists of unused exported symbols and went through
the list what made sense and what not, and these exports were up high on the
doesn't make sense and any use we could imagine would be harmfull list.
The explained use only seconds that opinion - it has caused constant trouble
for years where IBM has been pushing the big distros to relax VFS sanity
checks and add additioal exports for their totally broken kernel driver.
That no beeing enough I know of at least two propritary Unix variants where
it cause exactly the same trouble.
next prev parent reply other threads:[~2005-01-07 1:01 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-06 19:05 [PATCH] fs: Restore files_lock and set_fs_root exports Paul E. McKenney
2005-01-06 19:13 ` Christoph Hellwig
2005-01-06 20:07 ` Paul E. McKenney
2005-01-06 20:13 ` Christoph Hellwig
2005-01-06 20:35 ` Mike Waychison
2005-01-06 20:59 ` Christoph Hellwig
2005-01-06 21:35 ` Greg KH
2005-01-06 19:14 ` Al Viro
2005-01-06 20:13 ` Paul E. McKenney
2005-01-06 19:20 ` Arjan van de Ven
2005-01-06 20:15 ` Paul E. McKenney
2005-01-06 20:32 ` Al Viro
2005-01-06 21:04 ` Paul E. McKenney
2005-01-06 21:24 ` Al Viro
2005-01-06 23:26 ` Andrew Morton
2005-01-06 23:11 ` Alan Cox
2005-01-07 0:24 ` Linus Torvalds
2005-01-07 0:48 ` Christoph Hellwig [this message]
2005-01-07 7:38 ` Arjan van de Ven
2005-01-06 23:41 ` Christoph Hellwig
2005-01-07 0:29 ` Andrew Morton
2005-01-07 0:26 ` Christoph Hellwig
2005-01-07 3:30 ` Mike Waychison
2005-01-07 9:00 ` Ingo Molnar
2005-01-07 9:15 ` Christoph Hellwig
2005-01-07 12:14 ` Antonio Vargas
2005-01-07 22:00 ` Andrew Morton
2005-01-07 22:19 ` Christoph Hellwig
2005-01-07 22:58 ` Andrew Morton
2005-01-08 15:45 ` Alan Cox
2005-01-07 22:49 ` Alan Cox
2005-01-08 0:12 ` Andrew Morton
2005-01-08 2:20 ` Paul E. McKenney
2005-01-07 23:32 ` Adrian Bunk
2005-01-08 13:10 ` Al Viro
2005-01-07 1:34 ` Alan Cox
2005-01-07 3:17 ` Andrew Morton
2005-01-07 8:12 ` Christoph Hellwig
2005-01-06 23:56 ` [PATCH] add feature-removal-schedule.txt documentation Greg KH
2005-01-07 0:23 ` Christoph Hellwig
2005-01-07 0:32 ` Greg KH
2005-01-07 17:02 ` Randy.Dunlap
2005-01-07 17:54 ` Linus Torvalds
2005-01-07 18:11 ` Greg KH
2005-01-11 12:23 ` [PATCH] cpufreq 2.4 interface removal schedule [Was: Re: [PATCH] add feature-removal-schedule.txt documentation] Dominik Brodowski
2005-01-12 18:41 ` Greg KH
2005-01-07 23:58 ` [PATCH] add feature-removal-schedule.txt documentation Dominik Brodowski
2005-01-12 18:41 ` Greg KH
2005-01-08 18:32 ` Paul E. McKenney
2005-01-08 21:46 ` Alan Cox
2005-01-08 23:03 ` Arjan van de Ven
2005-01-09 6:23 ` Paul E. McKenney
2005-01-09 6:27 ` Paul E. McKenney
2005-01-07 2:02 ` [PATCH] fs: Restore files_lock and set_fs_root exports Paul E. McKenney
2005-01-07 1:01 ` Paul E. McKenney
2005-01-07 1:20 ` Al Viro
2005-01-13 2:51 ` Paul E. McKenney
2005-01-13 7:35 ` Arjan van de Ven
2005-01-13 17:53 ` Paul E. McKenney
2005-01-13 17:07 ` Greg KH
2005-01-13 17:44 ` Paul E. McKenney
2005-01-13 17:55 ` Greg KH
2005-01-13 18:29 ` Paul E. McKenney
2005-01-07 7:33 ` Arjan van de Ven
2005-01-07 8:15 ` Christoph Hellwig
2005-01-07 15:12 ` Paul E. McKenney
2005-01-07 15:23 ` Arjan van de Ven
2005-01-07 15:34 ` Paul E. McKenney
2005-01-07 15:56 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050107004850.GA29346@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=greghk@us.ibm.com \
--cc=jtk@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markv@us.ibm.com \
--cc=paulmck@us.ibm.com \
--cc=pbadari@us.ibm.com \
--cc=torvalds@osdl.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=wtaber@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).