* [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
@ 2005-12-13 17:01 Adrian Bunk
2005-12-14 22:24 ` Roman Zippel
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-12-13 17:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: zippel, linux-kernel
Function prototypes belong into header files.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 23 Nov 2005
fs/hfsplus/hfsplus_fs.h | 3 +++
fs/hfsplus/inode.c | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.15-rc2-mm1-full/fs/hfsplus/hfsplus_fs.h.old 2005-11-23 16:36:41.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/hfsplus_fs.h 2005-11-23 16:37:19.000000000 +0100
@@ -347,6 +347,9 @@
void hfsplus_fill_defaults(struct hfsplus_sb_info *);
int hfsplus_show_options(struct seq_file *, struct vfsmount *);
+/* super.c */
+void hfsplus_inode_check(struct super_block *sb);
+
/* tables.c */
extern u16 hfsplus_case_fold_table[];
extern u16 hfsplus_decompose_table[];
--- linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c.old 2005-11-23 16:37:34.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c 2005-11-23 16:37:48.000000000 +0100
@@ -183,7 +183,6 @@
hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
mark_inode_dirty(inode);
{
- void hfsplus_inode_check(struct super_block *sb);
atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
hfsplus_inode_check(sb);
}
@@ -322,7 +321,6 @@
return NULL;
{
- void hfsplus_inode_check(struct super_block *sb);
atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
hfsplus_inode_check(sb);
}
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
2005-12-13 17:01 [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h Adrian Bunk
@ 2005-12-14 22:24 ` Roman Zippel
2005-12-15 0:14 ` [2.6 patch] fs/hfsplus/: remove the hfsplus_inode_check() debug function Adrian Bunk
0 siblings, 1 reply; 7+ messages in thread
From: Roman Zippel @ 2005-12-14 22:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel
Hi,
On Tue, 13 Dec 2005, Adrian Bunk wrote:
> --- linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c.old 2005-11-23 16:37:34.000000000 +0100
> +++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c 2005-11-23 16:37:48.000000000 +0100
> @@ -183,7 +183,6 @@
> hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
> mark_inode_dirty(inode);
> {
> - void hfsplus_inode_check(struct super_block *sb);
> atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
> hfsplus_inode_check(sb);
> }
> @@ -322,7 +321,6 @@
> return NULL;
>
> {
> - void hfsplus_inode_check(struct super_block *sb);
> atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
> hfsplus_inode_check(sb);
> }
As this is only a debug function I don't see much point in cleaning it up.
I'd rather remove it completely (including all references to
last_inode_cnt and inode_cnt).
bye, Roman
^ permalink raw reply [flat|nested] 7+ messages in thread* [2.6 patch] fs/hfsplus/: remove the hfsplus_inode_check() debug function
2005-12-14 22:24 ` Roman Zippel
@ 2005-12-15 0:14 ` Adrian Bunk
0 siblings, 0 replies; 7+ messages in thread
From: Adrian Bunk @ 2005-12-15 0:14 UTC (permalink / raw)
To: Roman Zippel; +Cc: Andrew Morton, linux-kernel
On Wed, Dec 14, 2005 at 11:24:19PM +0100, Roman Zippel wrote:
> Hi,
Hi Roman,
> On Tue, 13 Dec 2005, Adrian Bunk wrote:
>
> > --- linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c.old 2005-11-23 16:37:34.000000000 +0100
> > +++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c 2005-11-23 16:37:48.000000000 +0100
> > @@ -183,7 +183,6 @@
> > hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
> > mark_inode_dirty(inode);
> > {
> > - void hfsplus_inode_check(struct super_block *sb);
> > atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
> > hfsplus_inode_check(sb);
> > }
> > @@ -322,7 +321,6 @@
> > return NULL;
> >
> > {
> > - void hfsplus_inode_check(struct super_block *sb);
> > atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
> > hfsplus_inode_check(sb);
> > }
>
> As this is only a debug function I don't see much point in cleaning it up.
> I'd rather remove it completely (including all references to
> last_inode_cnt and inode_cnt).
patch below.
> bye, Roman
cu
Adrian
<-- snip -->
This patch removes the hfsplus_inode_check() debug function.
It also removes the now obsolete last_inode_cnt and inode_cnt from
struct hfsplus_sb_info.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/hfsplus/hfsplus_fs.h | 3 ---
fs/hfsplus/inode.c | 10 ----------
fs/hfsplus/super.c | 19 -------------------
3 files changed, 32 deletions(-)
--- linux-2.6.15-rc5-mm2-full/fs/hfsplus/hfsplus_fs.h.old 2005-12-14 23:34:45.000000000 +0100
+++ linux-2.6.15-rc5-mm2-full/fs/hfsplus/hfsplus_fs.h 2005-12-14 23:34:55.000000000 +0100
@@ -143,9 +143,6 @@
unsigned long flags;
- atomic_t inode_cnt;
- u32 last_inode_cnt;
-
struct hlist_head rsrc_inodes;
};
--- linux-2.6.15-rc5-mm2-full/fs/hfsplus/inode.c.old 2005-12-14 23:33:29.000000000 +0100
+++ linux-2.6.15-rc5-mm2-full/fs/hfsplus/inode.c 2005-12-14 23:35:18.000000000 +0100
@@ -182,11 +182,6 @@
igrab(dir);
hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
mark_inode_dirty(inode);
- {
- void hfsplus_inode_check(struct super_block *sb);
- atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
- hfsplus_inode_check(sb);
- }
out:
d_add(dentry, inode);
return NULL;
@@ -321,11 +316,6 @@
if (!inode)
return NULL;
- {
- void hfsplus_inode_check(struct super_block *sb);
- atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
- hfsplus_inode_check(sb);
- }
inode->i_ino = HFSPLUS_SB(sb).next_cnid++;
inode->i_mode = mode;
inode->i_uid = current->fsuid;
--- linux-2.6.15-rc5-mm2-full/fs/hfsplus/super.c.old 2005-12-14 23:33:57.000000000 +0100
+++ linux-2.6.15-rc5-mm2-full/fs/hfsplus/super.c 2005-12-14 23:35:26.000000000 +0100
@@ -22,29 +22,12 @@
#include "hfsplus_fs.h"
-void hfsplus_inode_check(struct super_block *sb)
-{
-#if 0
- u32 cnt = atomic_read(&HFSPLUS_SB(sb).inode_cnt);
- u32 last_cnt = HFSPLUS_SB(sb).last_inode_cnt;
-
- if (cnt <= (last_cnt / 2) ||
- cnt >= (last_cnt * 2)) {
- HFSPLUS_SB(sb).last_inode_cnt = cnt;
- printk("inode_check: %u,%u,%u\n", cnt, last_cnt,
- HFSPLUS_SB(sb).cat_tree ? HFSPLUS_SB(sb).cat_tree->node_hash_cnt : 0);
- }
-#endif
-}
-
static void hfsplus_read_inode(struct inode *inode)
{
struct hfs_find_data fd;
struct hfsplus_vh *vhdr;
int err;
- atomic_inc(&HFSPLUS_SB(inode->i_sb).inode_cnt);
- hfsplus_inode_check(inode->i_sb);
INIT_LIST_HEAD(&HFSPLUS_I(inode).open_dir_list);
init_MUTEX(&HFSPLUS_I(inode).extents_lock);
HFSPLUS_I(inode).flags = 0;
@@ -155,12 +138,10 @@
static void hfsplus_clear_inode(struct inode *inode)
{
dprint(DBG_INODE, "hfsplus_clear_inode: %lu\n", inode->i_ino);
- atomic_dec(&HFSPLUS_SB(inode->i_sb).inode_cnt);
if (HFSPLUS_IS_RSRC(inode)) {
HFSPLUS_I(HFSPLUS_I(inode).rsrc_inode).rsrc_inode = NULL;
iput(HFSPLUS_I(inode).rsrc_inode);
}
- hfsplus_inode_check(inode->i_sb);
}
static void hfsplus_write_super(struct super_block *sb)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
@ 2005-11-23 22:35 Adrian Bunk
2005-11-23 22:50 ` Randy.Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-11-23 22:35 UTC (permalink / raw)
To: zippel; +Cc: linux-kernel
Function prototypes belong into header files.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/hfsplus/hfsplus_fs.h | 3 +++
fs/hfsplus/inode.c | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
--- linux-2.6.15-rc2-mm1-full/fs/hfsplus/hfsplus_fs.h.old 2005-11-23 16:36:41.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/hfsplus_fs.h 2005-11-23 16:37:19.000000000 +0100
@@ -347,6 +347,9 @@
void hfsplus_fill_defaults(struct hfsplus_sb_info *);
int hfsplus_show_options(struct seq_file *, struct vfsmount *);
+/* super.c */
+void hfsplus_inode_check(struct super_block *sb);
+
/* tables.c */
extern u16 hfsplus_case_fold_table[];
extern u16 hfsplus_decompose_table[];
--- linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c.old 2005-11-23 16:37:34.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/fs/hfsplus/inode.c 2005-11-23 16:37:48.000000000 +0100
@@ -183,7 +183,6 @@
hlist_add_head(&inode->i_hash, &HFSPLUS_SB(sb).rsrc_inodes);
mark_inode_dirty(inode);
{
- void hfsplus_inode_check(struct super_block *sb);
atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
hfsplus_inode_check(sb);
}
@@ -322,7 +321,6 @@
return NULL;
{
- void hfsplus_inode_check(struct super_block *sb);
atomic_inc(&HFSPLUS_SB(sb).inode_cnt);
hfsplus_inode_check(sb);
}
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
2005-11-23 22:35 [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h Adrian Bunk
@ 2005-11-23 22:50 ` Randy.Dunlap
2005-11-23 22:58 ` Adrian Bunk
0 siblings, 1 reply; 7+ messages in thread
From: Randy.Dunlap @ 2005-11-23 22:50 UTC (permalink / raw)
To: Adrian Bunk; +Cc: zippel, linux-kernel
On Wed, 23 Nov 2005, Adrian Bunk wrote:
> Function prototypes belong into header files.
I'd like to see someone fix kernel/power/disk.c also....
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
2005-11-23 22:50 ` Randy.Dunlap
@ 2005-11-23 22:58 ` Adrian Bunk
2005-11-23 23:01 ` Randy.Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-11-23 22:58 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: zippel, linux-kernel
On Wed, Nov 23, 2005 at 02:50:05PM -0800, Randy.Dunlap wrote:
> On Wed, 23 Nov 2005, Adrian Bunk wrote:
>
> > Function prototypes belong into header files.
>
> I'd like to see someone fix kernel/power/disk.c also....
This will also be done before I'll submit my patch to add
-Wmissing-prototypes to the global CFLAGS - but I can't fix all places
in the kernel at the same day, there are too many of them...
> ~Randy
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h
2005-11-23 22:58 ` Adrian Bunk
@ 2005-11-23 23:01 ` Randy.Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: Randy.Dunlap @ 2005-11-23 23:01 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Randy.Dunlap, zippel, linux-kernel
On Wed, 23 Nov 2005, Adrian Bunk wrote:
> On Wed, Nov 23, 2005 at 02:50:05PM -0800, Randy.Dunlap wrote:
> > On Wed, 23 Nov 2005, Adrian Bunk wrote:
> >
> > > Function prototypes belong into header files.
> >
> > I'd like to see someone fix kernel/power/disk.c also....
>
> This will also be done before I'll submit my patch to add
> -Wmissing-prototypes to the global CFLAGS - but I can't fix all places
> in the kernel at the same day, there are too many of them...
Of course, I didn't expect them to be fixed in one day
or even for you to be the only person who may do it.
Thanks,
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-12-15 0:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-13 17:01 [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h Adrian Bunk
2005-12-14 22:24 ` Roman Zippel
2005-12-15 0:14 ` [2.6 patch] fs/hfsplus/: remove the hfsplus_inode_check() debug function Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-11-23 22:35 [2.6 patch] fs/hfsplus/: move the hfsplus_inode_check() prototype to hfsplus_fs.h Adrian Bunk
2005-11-23 22:50 ` Randy.Dunlap
2005-11-23 22:58 ` Adrian Bunk
2005-11-23 23:01 ` Randy.Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).