From: Al Viro <viro@ftp.linux.org.uk>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration
Date: Thu, 15 Dec 2005 17:16:45 +0000 [thread overview]
Message-ID: <20051215171645.GY27946@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0512151258200.1605@scrub.home>
On Thu, Dec 15, 2005 at 01:00:05PM +0100, Roman Zippel wrote:
> Hi,
>
> On Thu, 15 Dec 2005, Al Viro wrote:
>
> > another compile fix, pulled straight from m68k CVS
>
> Thanks, but if you pull changes out of CVS could you please keep the
> author intact? CVS may be bad, but it's not that bad.
CVS users, OTOH...
Mon Oct 22 09:34:34 2001 UTC (4 years, 1 month ago) by zippel
Branches: MAIN
CVS tags: m68k-2_5_9, m68k-2_5_8, m68k-2_5_7, m68k-2_5_65,
[snip]
m68k-2_4_13, m68k-2_4_12
Branch point for: m68k-2_4
Diff to previous 1.1: preferred, colored
Changes since revision 1.1: +1 -0 lines
import Geert's 2.4.12 m68k patch
and the same for drivers/macintosh part.
So who should I put as the author? You or Geert (or whatever attributions
might have been in said big patch)? Incidentally, ADBREQ_RAW had leaked
into mainline (sans definition) in 2.3.45-pre2, which was Feb 13 2000, i.e.
more than 1.5 year before your commit, so there's quite a chunk of history
missing...
I'm serious, BTW - I certainly would have no problem preserving attribution,
but it simply hadn't been there. CVS logs are only as good as the data
being put there by committers...
next prev parent reply other threads:[~2005-12-15 17:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 8:55 [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration Al Viro
2005-12-15 12:00 ` Roman Zippel
2005-12-15 17:16 ` Al Viro [this message]
2005-12-15 17:47 ` Al Viro
2005-12-15 17:54 ` Geert Uytterhoeven
2005-12-16 1:21 ` Finn Thain
2005-12-15 17:51 ` Roman Zippel
2005-12-15 17:55 ` Al Viro
2005-12-15 18:00 ` Geert Uytterhoeven
2005-12-15 18:14 ` Al Viro
2005-12-15 18:58 ` Al Viro
2005-12-15 20:05 ` Brad Boyer
2005-12-22 5:06 ` Al Viro
2005-12-25 2:26 ` Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051215171645.GY27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).