From: Brad Boyer <flar@allandria.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Roman Zippel <zippel@linux-m68k.org>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration
Date: Sat, 24 Dec 2005 18:26:56 -0800 [thread overview]
Message-ID: <20051225022656.GA18947@pants.nu> (raw)
In-Reply-To: <20051222050655.GO27946@ftp.linux.org.uk>
On Thu, Dec 22, 2005 at 05:06:55AM +0000, Al Viro wrote:
> On Thu, Dec 15, 2005 at 12:05:21PM -0800, Brad Boyer wrote:
> > I would like to stop using adb_request in mac/misc.c as well, but it's not
> > as simple as just changing it to use cuda_request and pmu_request. That
> > should do it for the cuda and pmu based models, but the egret (Mac IIsi
> > and friends) based models get left out by that fix. If noone else looks
> > at it before me, I'll check this out after I fix some other stuff related
> > to m68k mac support.
>
> OK... AFAICS, patch I've just posted to l-k and linux-m68k (subject:
> [PATCH 04/36] m68k: switch mac/misc.c to direct use of appropriate
> cuda/pmu/maciisi requests) should so it. Do you have any problems with
> that variant?
I don't have any big issues with it. However, I am not at home right now
and can't actually try it out on real hardware. It looks like it should
work as well as the version it is replacing. I'm pretty sure the IIsi
case was broken before. I think we should go ahead and commit this to
get rid of the issues it fixes, and then come back to it later and take
another pass at it to fix the fact that it has never worked in 2.6 on
some models. It's better than nothing.
Brad Boyer
flar@allandria.com
prev parent reply other threads:[~2005-12-25 2:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 8:55 [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration Al Viro
2005-12-15 12:00 ` Roman Zippel
2005-12-15 17:16 ` Al Viro
2005-12-15 17:47 ` Al Viro
2005-12-15 17:54 ` Geert Uytterhoeven
2005-12-16 1:21 ` Finn Thain
2005-12-15 17:51 ` Roman Zippel
2005-12-15 17:55 ` Al Viro
2005-12-15 18:00 ` Geert Uytterhoeven
2005-12-15 18:14 ` Al Viro
2005-12-15 18:58 ` Al Viro
2005-12-15 20:05 ` Brad Boyer
2005-12-22 5:06 ` Al Viro
2005-12-25 2:26 ` Brad Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051225022656.GA18947@pants.nu \
--to=flar@allandria.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).