From: Al Viro <viro@ftp.linux.org.uk>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration
Date: Thu, 15 Dec 2005 18:58:29 +0000 [thread overview]
Message-ID: <20051215185829.GC27946@ftp.linux.org.uk> (raw)
In-Reply-To: <20051215181405.GB27946@ftp.linux.org.uk>
On Thu, Dec 15, 2005 at 06:14:05PM +0000, Al Viro wrote:
> >From my reading of the code it's a way for mac/misc.c to send a packet that
> starts with CUDA_PACKET or PMU_PACKET instead of ADB_PACKET, but otherwise
> is the same as normal adb_request() ones...
>
> Used for access to timer, nvram, etc. - looks like that puppy used to
> use the same protocol for more than just ADB and the first byte of packet
> really selects the destination...
After reading some more... Is there any reason why mac/misc.c can't
simply use cuda_request() and pmu_request() instead? At least for
read/write for time and nvram we end up with identical sequence of
operations anyway - if you expand the calls in
adb_request((struct adb_request *) &req, NULL,
ADBREQ_RAW|ADBREQ_SYNC,
2, CUDA_PACKET, CUDA_GET_TIME);
[m68k]
and
if (cuda_request(&req, NULL, 2, CUDA_PACKET, CUDA_GET_TIME) < 0)
/* bail out */
while (!req.complete)
cuda_poll();
[ppc]
until you get to call of cuda_write(), you'll see the same code. Come
to think of that... Shouldn't the ifdefs for CONFIG_ADB_PMU in there be for
CONFIG_ADB_PMU68? The former depends on PMAC_PPC, so it's not particulary
useful thing to check on m68k...
next prev parent reply other threads:[~2005-12-15 18:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 8:55 [PATCH 2/3] m68k: compile fix - ADBREQ_RAW missing declaration Al Viro
2005-12-15 12:00 ` Roman Zippel
2005-12-15 17:16 ` Al Viro
2005-12-15 17:47 ` Al Viro
2005-12-15 17:54 ` Geert Uytterhoeven
2005-12-16 1:21 ` Finn Thain
2005-12-15 17:51 ` Roman Zippel
2005-12-15 17:55 ` Al Viro
2005-12-15 18:00 ` Geert Uytterhoeven
2005-12-15 18:14 ` Al Viro
2005-12-15 18:58 ` Al Viro [this message]
2005-12-15 20:05 ` Brad Boyer
2005-12-22 5:06 ` Al Viro
2005-12-25 2:26 ` Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051215185829.GC27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).