[PATCH] enable XFS write barrier

[PATCH] enable XFS write barrier

[Tetsuo Takata]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

I found out that the q->ordered is not being set properly on XFS.


I'm testing the write barrier support of XFS.
I run the test on kernel 2.6.16-rc1-git4.
but I found out that the "-o barrier" option is automatically disabled
in my environment.
For this reason I could not test the write barrier's execution path.

The error message in "/var/log/messages" is:
Filesystem "sdb1": Disabling barriers, not supported by the underlying device


This patch fixes these bugs.


Best regards,

Tetsuo Takata

[-- Attachment #2: 2.6.16-rc1-git4-sd.patch --]
[-- Type: application/octet-stream, Size: 559 bytes --]

The patch below fixes the aforementioned problem.

Signed-off-by: Tetsuo Takata <takatatt@intellilink.co.jp>
---

diff -urpN linux-2.6.16-rc1-git4/block/ll_rw_blk.c linux-2.6.16-rc1-git4-fixed/block/ll_rw_blk.c
--- linux-2.6.16-rc1-git4/block/ll_rw_blk.c	2006-01-23 21:29:12.000000000 +0900
+++ linux-2.6.16-rc1-git4-fixed/block/ll_rw_blk.c	2006-01-23 22:05:11.000000000 +0900
@@ -332,6 +332,7 @@ int blk_queue_ordered(request_queue_t *q
 		return -EINVAL;
 	}
 
+	q->ordered = ordered;
 	q->next_ordered = ordered;
 	q->prepare_flush_fn = prepare_flush_fn;

Re: [PATCH] enable XFS write barrier

[Jens Axboe]

On Mon, Jan 23 2006, Tetsuo Takata wrote:
> I found out that the q->ordered is not being set properly on XFS.
> 
> 
> I'm testing the write barrier support of XFS.
> I run the test on kernel 2.6.16-rc1-git4.
> but I found out that the "-o barrier" option is automatically disabled
> in my environment.
> For this reason I could not test the write barrier's execution path.
> 
> The error message in "/var/log/messages" is:
> Filesystem "sdb1": Disabling barriers, not supported by the underlying device
> 
> 
> This patch fixes these bugs.

Woops, thanks!

-- 
Jens Axboe