linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Douglas Gilbert <dougg@torque.net>,
	Matthias Andree <matthias.andree@gmx.de>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: lsscsi-0.17 released
Date: Wed, 22 Feb 2006 09:14:39 -0800	[thread overview]
Message-ID: <20060222171438.GA20272@kroah.com> (raw)
In-Reply-To: <20060222163426.GG28587@parisc-linux.org>

On Wed, Feb 22, 2006 at 09:34:26AM -0700, Matthew Wilcox wrote:
> On Wed, Feb 22, 2006 at 11:27:16AM -0500, Douglas Gilbert wrote:
> > Matthias Andree wrote:
> > > On Wed, 22 Feb 2006, Douglas Gilbert wrote: 
> > >>Matthias Andree wrote:
> > >>>Does this work around new incompatibilities in the kernel
> > >>>or does this fix lsscsi bugs?
> > >>
> > >>The former. In lk 2.6.16-rc1 the
> > >>/sys/class/scsi_device/<hcil>/device/block symlink
> > >>changed to ".../block:sd<x>" breaking lsscsi 0.16 (and
> > >>earlier) and sg_map26 (in sg3_utils).
> > > 
> > > Heck, what was the reason for breaking userspace again?
> > 
> > Maybe the person responsible can answer. I'm only reacting
> > to a change that broke two of my utilities.
> 
> Probably better to cc the person responsible if you want an answer.

It was changed as there would be more than one "block" symlink in a
device's directory if more than one block device was attached to a
single struct device.  For example, ub and multi-lun devices (there were
other reports of this happening for scsi devices too at the time from
what I remember.)

So, in that case, your tool would have been broken anyway, so this fix
was required to make it correct :)

The fix was to make block devices work the same way as all other class
devices, which had this fix a while ago.

thanks,

greg k-h

  parent reply	other threads:[~2006-02-22 17:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-21 23:39 lsscsi-0.17 released Douglas Gilbert
2006-02-22  8:50 ` Matthias Andree
2006-02-22 15:01   ` Douglas Gilbert
2006-02-22 16:06     ` Matthias Andree
2006-02-22 16:27       ` Douglas Gilbert
2006-02-22 16:34         ` Matthew Wilcox
2006-02-22 16:38           ` Randy.Dunlap
2006-02-22 17:14           ` Greg KH [this message]
2006-02-22 18:00             ` Matthias Andree
2006-02-22 18:32               ` Greg KH
2006-02-22 20:22                 ` Matthias Andree
2006-02-22 17:59 Douglas Gilbert
2006-02-22 18:37 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060222171438.GA20272@kroah.com \
    --to=greg@kroah.com \
    --cc=dougg@torque.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=matthias.andree@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).