From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Kirill Korotaev <dev@sw.ru>
Cc: "Serge E. Hallyn" <serue@us.ibm.com>,
linux-kernel@vger.kernel.org, herbert@13thfloor.at,
sam@vilain.net, "Eric W. Biederman" <ebiederm@xmission.com>,
xemul@sw.ru, James Morris <jmorris@namei.org>
Subject: Re: [RFC][PATCH 0/5] uts namespaces: Introduction
Date: Tue, 11 Apr 2006 09:01:46 -0500 [thread overview]
Message-ID: <20060411140146.GB10610@sergelap.austin.ibm.com> (raw)
In-Reply-To: <443BA1D3.1070200@sw.ru>
Quoting Kirill Korotaev (dev@sw.ru):
> Serge,
>
> >This patchset is based on Kirill Korotaev's Mar 24 submission, taking
> >comments (in particular from James Morris and Eric Biederman) into
> >account.
> thanks a lot for doing this!
NP, thanks for doing the first round.
> >Some performance results are attached. I was mainly curious whether
> >it would be worth putting the task_struct->uts_ns pointer inside
> >a #ifdef CONFIG_UTS_NS. The result show that leaving it in when
> >CONFIG_UTS_NS=n has negligable performance impact, so that is the
> >approach this patch takes.
> Serge, your testing approach looks really strange for me.
> First of all, you selected the worst namespace to check performance
> overhead on.
> 1) uts_ns is rarely used and never used on hot paths,
> 2) also all these test suites below doesn't test the code paths you
> modified.
>
> So I wonder what was the goal of these tests, especially dbench?!
Right, I wasn't actually aiming to test the performance of the uts
namespaces themselves (despite including those numbers), since they're
not on hot paths. I was mostly curious whether putting the utsns
pointer into the task_struct would affect performance at all, to know
whether to put that inside an #ifdef. Based on the results, I kept it
non-#ifdefed even if !CONFIG_UTS_NS, and that's what I was justifying
with those numbers.
These tests should be done again when we get 3 or 5 namespace pointers,
and perhaps there should still be some other tests included, ie mainly a
forkbomb perhaps. I just did my default set of tests that I usually
use.
thanks,
-serge
prev parent reply other threads:[~2006-04-11 14:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 18:36 [RFC][PATCH 0/5] uts namespaces: Introduction Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 5/5] uts namespaces: Enable UTS namespaces debugging Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 2/5] uts namespaces: Switch to using uts namespaces Serge E. Hallyn
2006-04-07 19:17 ` Sam Ravnborg
2006-04-07 19:25 ` Serge E. Hallyn
2006-04-11 12:26 ` Kirill Korotaev
2006-04-11 21:04 ` Sam Vilain
2006-04-12 5:01 ` Serge E. Hallyn
2006-04-12 6:00 ` Eric W. Biederman
2006-04-19 15:00 ` Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 3/5] uts namespaces: Use init uts_namespace when appropriate Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 4/5] utsname namespaces: sysctl hack Serge E. Hallyn
2006-04-19 15:17 ` Kirill Korotaev
2006-04-19 15:21 ` Serge E. Hallyn
2006-04-19 15:50 ` Kirill Korotaev
2006-04-19 16:54 ` Cedric Le Goater
2006-04-19 17:10 ` Eric W. Biederman
2006-04-19 17:10 ` Serge E. Hallyn
2006-04-19 15:52 ` Eric W. Biederman
2006-04-19 16:23 ` Dave Hansen
2006-04-19 16:52 ` Eric W. Biederman
2006-04-19 17:19 ` Dave Hansen
2006-04-19 17:37 ` Eric W. Biederman
2006-04-19 17:48 ` Eric W. Biederman
2006-04-19 15:29 ` Eric W. Biederman
2006-04-19 17:51 ` Serge E. Hallyn
2006-04-19 18:27 ` Eric W. Biederman
2006-04-19 20:24 ` Serge E. Hallyn
2006-04-19 21:44 ` Sam Vilain
2006-04-20 17:05 ` Serge E. Hallyn
2006-04-25 22:00 ` Serge E. Hallyn
2006-04-26 4:09 ` Sam Vilain
2006-04-26 10:28 ` Christoph Hellwig
2006-04-27 12:32 ` Eric W. Biederman
2006-04-07 18:36 ` [RFC][PATCH 1/5] uts namespaces: Implement utsname namespaces Serge E. Hallyn
2006-04-07 19:13 ` Sam Ravnborg
2006-04-07 19:20 ` Serge E. Hallyn
2006-04-07 19:39 ` Serge E. Hallyn
2006-04-07 20:47 ` James Morris
2006-04-07 22:13 ` Serge E. Hallyn
2006-04-08 13:44 ` Andi Kleen
2006-04-08 13:45 ` Andi Kleen
2006-04-08 20:28 ` Serge E. Hallyn
2006-04-09 6:00 ` Andi Kleen
2006-04-09 19:08 ` Eric W. Biederman
2006-04-07 19:06 ` [RFC][PATCH 0/5] uts namespaces: Introduction Eric W. Biederman
2006-04-07 19:28 ` Serge E. Hallyn
2006-04-07 19:39 ` Eric W. Biederman
2006-04-11 12:32 ` Kirill Korotaev
2006-04-11 14:01 ` Serge E. Hallyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060411140146.GB10610@sergelap.austin.ibm.com \
--to=serue@us.ibm.com \
--cc=dev@sw.ru \
--cc=ebiederm@xmission.com \
--cc=herbert@13thfloor.at \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@vilain.net \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).