From: Kirill Korotaev <dev@sw.ru>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, herbert@13thfloor.at,
devel@openvz.org, sam@vilain.net,
"Eric W. Biederman" <ebiederm@xmission.com>,
xemul@sw.ru, James Morris <jmorris@namei.org>
Subject: Re: [RFC][PATCH 0/5] uts namespaces: Introduction
Date: Tue, 11 Apr 2006 16:32:19 +0400 [thread overview]
Message-ID: <443BA1D3.1070200@sw.ru> (raw)
In-Reply-To: <20060407095132.455784000@sergelap>
Serge,
> This patchset is based on Kirill Korotaev's Mar 24 submission, taking
> comments (in particular from James Morris and Eric Biederman) into
> account.
thanks a lot for doing this!
> Some performance results are attached. I was mainly curious whether
> it would be worth putting the task_struct->uts_ns pointer inside
> a #ifdef CONFIG_UTS_NS. The result show that leaving it in when
> CONFIG_UTS_NS=n has negligable performance impact, so that is the
> approach this patch takes.
Serge, your testing approach looks really strange for me.
First of all, you selected the worst namespace to check performance
overhead on.
1) uts_ns is rarely used and never used on hot paths,
2) also all these test suites below doesn't test the code paths you
modified.
So I wonder what was the goal of these tests, especially dbench?!
Thanks,
Kirill
>
> -serge
>
> Performance testing was done on a 2-cpu hyperthreaded
> x86 box with 16G ram. The following tests were run:
> dbench (20 times, four clients, on reiser fs non-isolated partition)
> tbench (20 times, 5 connections)
> kernbench (20 times)
> reaim (20 times ranging from 1 to 15 users)
>
> They were run on 2.6.17-rc1:
> pristine
> patched, but with !CONFIG_UTS_NS ("disabled")
> patched with CONFIG_UTS_NS=y ("enabled")
>
> All results are presented as means +/- 95% confidence interval.
>
> Dbench results:
> pristine: 387.080727 +/- 9.344585
> patched disabled: 389.524364 +/- 9.574921
> patched enabled: 370.155600 +/- 30.127808
>
> Tbench results:
> pristine: 388.940100 +/- 18.095104
> patched disabled: 389.173700 +/- 23.658035
> patched enabled: 394.333200 +/- 25.813393
>
> Kernbench results:
> pristine: 70.317500 +/- 0.210833
> patched, disabled: 70.860000 +/- 0.179292
> patched, enabled: 70.346500 +/- 0.184784
>
> Reaim results:
> pristine:
> Nclients Mean 95% CI
> 1 106080.000000 11327.896029
> 3 236057.142000 18205.544810
> 5 247867.136000 23536.800062
> 7 265370.000000 21284.335743
> 9 262969.936000 18225.497529
> 11 278256.000000 6230.342816
> 13 284288.016000 8924.589388
> 15 286987.170000 7881.034658
>
> patched, disabled:
> Nclients Mean 95% CI
> 1 105400.000000 8739.978241
> 3 229500.000000 0.000000
> 5 252325.176667 16685.663423
> 7 265125.000000 6747.777319
> 9 271258.645000 11715.635212
> 11 280662.608333 7775.229351
> 13 277719.706667 8173.390359
> 15 278515.421667 10963.211450
>
> patched, enabled:
> Nclients Mean 95% CI
> 1 102000.000000 0.000000
> 3 224400.000000 14159.870036
> 5 242963.288000 40529.490781
> 7 255150.000000 8745.802081
> 9 270154.284000 8918.863136
> 11 283134.260000 12239.361252
> 13 288497.540000 11336.550964
> 15 280022.728000 8804.882369
>
>
next prev parent reply other threads:[~2006-04-11 12:27 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 18:36 [RFC][PATCH 0/5] uts namespaces: Introduction Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 5/5] uts namespaces: Enable UTS namespaces debugging Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 2/5] uts namespaces: Switch to using uts namespaces Serge E. Hallyn
2006-04-07 19:17 ` Sam Ravnborg
2006-04-07 19:25 ` Serge E. Hallyn
2006-04-11 12:26 ` Kirill Korotaev
2006-04-11 21:04 ` Sam Vilain
2006-04-12 5:01 ` Serge E. Hallyn
2006-04-12 6:00 ` Eric W. Biederman
2006-04-19 15:00 ` Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 3/5] uts namespaces: Use init uts_namespace when appropriate Serge E. Hallyn
2006-04-07 18:36 ` [RFC][PATCH 4/5] utsname namespaces: sysctl hack Serge E. Hallyn
2006-04-19 15:17 ` Kirill Korotaev
2006-04-19 15:21 ` Serge E. Hallyn
2006-04-19 15:50 ` Kirill Korotaev
2006-04-19 16:54 ` Cedric Le Goater
2006-04-19 17:10 ` Eric W. Biederman
2006-04-19 17:10 ` Serge E. Hallyn
2006-04-19 15:52 ` Eric W. Biederman
2006-04-19 16:23 ` Dave Hansen
2006-04-19 16:52 ` Eric W. Biederman
2006-04-19 17:19 ` Dave Hansen
2006-04-19 17:37 ` Eric W. Biederman
2006-04-19 17:48 ` Eric W. Biederman
2006-04-19 15:29 ` Eric W. Biederman
2006-04-19 17:51 ` Serge E. Hallyn
2006-04-19 18:27 ` Eric W. Biederman
2006-04-19 20:24 ` Serge E. Hallyn
2006-04-19 21:44 ` Sam Vilain
2006-04-20 17:05 ` Serge E. Hallyn
2006-04-25 22:00 ` Serge E. Hallyn
2006-04-26 4:09 ` Sam Vilain
2006-04-26 10:28 ` Christoph Hellwig
2006-04-27 12:32 ` Eric W. Biederman
2006-04-07 18:36 ` [RFC][PATCH 1/5] uts namespaces: Implement utsname namespaces Serge E. Hallyn
2006-04-07 19:13 ` Sam Ravnborg
2006-04-07 19:20 ` Serge E. Hallyn
2006-04-07 19:39 ` Serge E. Hallyn
2006-04-07 20:47 ` James Morris
2006-04-07 22:13 ` Serge E. Hallyn
2006-04-08 13:44 ` Andi Kleen
2006-04-08 13:45 ` Andi Kleen
2006-04-08 20:28 ` Serge E. Hallyn
2006-04-09 6:00 ` Andi Kleen
2006-04-09 19:08 ` Eric W. Biederman
2006-04-07 19:06 ` [RFC][PATCH 0/5] uts namespaces: Introduction Eric W. Biederman
2006-04-07 19:28 ` Serge E. Hallyn
2006-04-07 19:39 ` Eric W. Biederman
2006-04-11 12:32 ` Kirill Korotaev [this message]
2006-04-11 14:01 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443BA1D3.1070200@sw.ru \
--to=dev@sw.ru \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=herbert@13thfloor.at \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@vilain.net \
--cc=serue@us.ibm.com \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).