* [PATCH 2/2] headers_check: fix #include regexp
@ 2006-07-29 8:22 Alexey Dobriyan
2006-07-29 8:25 ` Russell King
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2006-07-29 8:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, David Woodhouse
Note it's [SPACE TAB]*
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/hdrcheck.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/scripts/hdrcheck.sh
+++ b/scripts/hdrcheck.sh
@@ -1,6 +1,6 @@
#!/bin/sh
-for FILE in `grep '^#include <' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
+for FILE in `grep '^[ ]*#[ ]*include[ ]*<' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
if [ ! -r $1/$FILE ]; then
echo $2 requires $FILE, which does not exist in exported headers
exit 1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] headers_check: fix #include regexp
2006-07-29 8:22 [PATCH 2/2] headers_check: fix #include regexp Alexey Dobriyan
@ 2006-07-29 8:25 ` Russell King
2006-07-29 8:42 ` Alexey Dobriyan
0 siblings, 1 reply; 4+ messages in thread
From: Russell King @ 2006-07-29 8:25 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel, David Woodhouse
On Sat, Jul 29, 2006 at 12:22:49PM +0400, Alexey Dobriyan wrote:
> Note it's [SPACE TAB]*
Why not use [[:space:]] rather than [ ] ? It's hard to see what black
characters on a black background are actually trying to do.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] headers_check: fix #include regexp
2006-07-29 8:25 ` Russell King
@ 2006-07-29 8:42 ` Alexey Dobriyan
[not found] ` <20060730122441.6db7bda2.akpm@osdl.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Dobriyan @ 2006-07-29 8:42 UTC (permalink / raw)
To: Russell King; +Cc: Andrew Morton, linux-kernel, David Woodhouse
On Sat, Jul 29, 2006 at 09:25:11AM +0100, Russell King wrote:
> On Sat, Jul 29, 2006 at 12:22:49PM +0400, Alexey Dobriyan wrote:
> > Note it's [SPACE TAB]*
>
> Why not use [[:space:]] rather than [ ] ? It's hard to see what black
> characters on a black background are actually trying to do.
Indeed. What about this? I assume nobody sane would use \n, \f or \v in
between ;-)
[PATCH] headers_check: fix #include regexp
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/hdrcheck.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/scripts/hdrcheck.sh
+++ b/scripts/hdrcheck.sh
@@ -1,6 +1,6 @@
#!/bin/sh
-for FILE in `grep '^#include <' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
+for FILE in `grep '^[ \t]*#[ \t]*include[ \t]*<' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
if [ ! -r $1/$FILE ]; then
echo $2 requires $FILE, which does not exist in exported headers
exit 1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/2] headers_check: improve #include regexp
[not found] ` <20060730122441.6db7bda2.akpm@osdl.org>
@ 2006-08-01 4:24 ` Alexey Dobriyan
0 siblings, 0 replies; 4+ messages in thread
From: Alexey Dobriyan @ 2006-08-01 4:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Instead of headers_check-fix-include-regexp.patch
-----------------------------------------------------
The following combinations of pp-tokens are used
#include
#include
# include
so, script'd better check for all of them.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
scripts/hdrcheck.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/scripts/hdrcheck.sh
+++ b/scripts/hdrcheck.sh
@@ -1,6 +1,6 @@
#!/bin/sh
-for FILE in `grep '^#include <' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
+for FILE in `grep '^[ \t]*#[ \t]*include[ \t]*<' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
if [ ! -r $1/$FILE ]; then
echo $2 requires $FILE, which does not exist in exported headers
exit 1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-01 4:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-07-29 8:22 [PATCH 2/2] headers_check: fix #include regexp Alexey Dobriyan
2006-07-29 8:25 ` Russell King
2006-07-29 8:42 ` Alexey Dobriyan
[not found] ` <20060730122441.6db7bda2.akpm@osdl.org>
2006-08-01 4:24 ` [PATCH 2/2] headers_check: improve " Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).