From: Oliver Neukum <oliver@neukum.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Oliver Neukum <oliver@neukum.name>,
Maneesh Soni <maneesh@in.ibm.com>,
Greg Kroah-Hartman <gregkh@suse.de>, Adrian Bunk <bunk@stusta.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.21-rc suspend regression: sysfs deadlock
Date: Tue, 6 Mar 2007 21:16:25 +0100 [thread overview]
Message-ID: <200703062116.26194.oliver@neukum.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703061914030.18144@blonde.wat.veritas.com>
Am Dienstag, 6. März 2007 20:20 schrieb Hugh Dickins:
> This comes from Oliver's commit 94bebf4d1b8e7719f0f3944c037a21cfd99a4af7
> Driver core: fix race in sysfs between sysfs_remove_file() and read()/write()
> in 2.6.21-rc1. It looks to me like sysfs_write_file downs buffer->sem
> while calling flush_write_buffer, and flushing that particular write
> buffer entails downing buffer->sem in orphan_all_buffers.
I had not thought about sysfs removing files in sysfs.
> Suspend no longer deadlocks with the following silly patch, but I expect
> this either pokes a small hole in your scheme, or renders it pointless.
The latter.
> Maybe that commit needs to be reverted, or maybe you can see how to fix
> it up for -rc3.
If you want a quick fix a work queue could be used, but it's a kludge.
Suggestions, anybody?
Regards
Oliver
next prev parent reply other threads:[~2007-03-06 20:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 19:20 2.6.21-rc suspend regression: sysfs deadlock Hugh Dickins
2007-03-06 20:16 ` Oliver Neukum [this message]
2007-03-07 1:56 ` Linus Torvalds
2007-03-07 14:38 ` Oliver Neukum
2007-03-07 15:56 ` Dmitry Torokhov
2007-03-07 16:52 ` Linus Torvalds
2007-03-07 16:59 ` Oliver Neukum
2007-03-07 18:02 ` Linus Torvalds
2007-03-07 18:16 ` Oliver Neukum
2007-03-10 20:44 Alan Stern
2007-03-12 21:31 refcounting drivers' data structures used in sysfs buffers Richard Purdie
2007-03-13 15:00 ` 2.6.21-rc suspend regression: sysfs deadlock Alan Stern
2007-03-13 18:42 ` Cornelia Huck
2007-03-13 21:20 ` Linus Torvalds
2007-03-14 16:12 ` Alan Stern
2007-03-14 18:43 ` Cornelia Huck
2007-03-14 19:23 ` Alan Stern
2007-03-15 10:27 ` Cornelia Huck
2007-03-15 12:31 ` Hugh Dickins
2007-03-15 13:02 ` Oliver Neukum
2007-03-15 13:22 ` Dmitry Torokhov
2007-03-15 13:59 ` Hugh Dickins
2007-03-15 14:27 ` Alan Stern
2007-03-15 15:32 ` Cornelia Huck
2007-03-15 16:29 ` Hugh Dickins
2007-03-15 16:51 ` Linus Torvalds
2007-03-13 19:00 ` Hugh Dickins
2007-03-13 20:09 ` Alan Stern
2007-03-13 20:55 ` Hugh Dickins
2007-03-13 21:08 ` Dmitry Torokhov
2007-03-13 21:20 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703062116.26194.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=oliver@neukum.name \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).