From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Hugh Dickins" <hugh@veritas.com>,
"Oliver Neukum" <oliver@neukum.name>,
"Maneesh Soni" <maneesh@in.ibm.com>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Adrian Bunk" <bunk@stusta.de>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.21-rc suspend regression: sysfs deadlock
Date: Wed, 7 Mar 2007 10:56:22 -0500 [thread overview]
Message-ID: <d120d5000703070756v4fe11a54u9009d3efd93faa9d@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703061735350.5963@woody.linux-foundation.org>
On 3/6/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> - removing the buffer is now just
>
> mutex_lock(&inode->i_mutex);
> buffer = inode->i_private;
> inode->i_private = NULL;
> mutex_unlock(&inode->i_mutex);
>
> put_sysfs_buffer(buffer);
>
> - everybody is happy!
>
... with the exception that it will again make data associated with
sysfs attributes accessible past the point of returning from
sysfs_remove_file. And that was the point so drivers would not have to
care about handling access to extra data (such as static strings) past
the driver unload.
I wonder if we should keep Oliver's change and require attribute
implementations to offload "delete me" kind of actions to workqueues.
--
Dmitry
next prev parent reply other threads:[~2007-03-07 15:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 19:20 2.6.21-rc suspend regression: sysfs deadlock Hugh Dickins
2007-03-06 20:16 ` Oliver Neukum
2007-03-07 1:56 ` Linus Torvalds
2007-03-07 14:38 ` Oliver Neukum
2007-03-07 15:56 ` Dmitry Torokhov [this message]
2007-03-07 16:52 ` Linus Torvalds
2007-03-07 16:59 ` Oliver Neukum
2007-03-07 18:02 ` Linus Torvalds
2007-03-07 18:16 ` Oliver Neukum
2007-03-10 20:44 Alan Stern
2007-03-12 21:31 refcounting drivers' data structures used in sysfs buffers Richard Purdie
2007-03-13 15:00 ` 2.6.21-rc suspend regression: sysfs deadlock Alan Stern
2007-03-13 18:42 ` Cornelia Huck
2007-03-13 21:20 ` Linus Torvalds
2007-03-14 16:12 ` Alan Stern
2007-03-14 18:43 ` Cornelia Huck
2007-03-14 19:23 ` Alan Stern
2007-03-15 10:27 ` Cornelia Huck
2007-03-15 12:31 ` Hugh Dickins
2007-03-15 13:02 ` Oliver Neukum
2007-03-15 13:22 ` Dmitry Torokhov
2007-03-15 13:59 ` Hugh Dickins
2007-03-15 14:27 ` Alan Stern
2007-03-15 15:32 ` Cornelia Huck
2007-03-15 16:29 ` Hugh Dickins
2007-03-15 16:51 ` Linus Torvalds
2007-03-13 19:00 ` Hugh Dickins
2007-03-13 20:09 ` Alan Stern
2007-03-13 20:55 ` Hugh Dickins
2007-03-13 21:08 ` Dmitry Torokhov
2007-03-13 21:20 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000703070756v4fe11a54u9009d3efd93faa9d@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=bunk@stusta.de \
--cc=gregkh@suse.de \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=oliver@neukum.name \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).