From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org,
Keika Kobayashi <kobayashi.kk@ncos.nec.co.jp>
Subject: Re: 2.6.29 -mm merge plans
Date: Tue, 6 Jan 2009 20:16:57 -0800 [thread overview]
Message-ID: <20090106201657.bf9faa38.akpm@linux-foundation.org> (raw)
In-Reply-To: <200901071405.51642.nickpiggin@yahoo.com.au>
On Wed, 7 Jan 2009 14:05:51 +1100 Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> On Wednesday 07 January 2009 13:16:47 Andrew Morton wrote:
> > On Wed, 7 Jan 2009 13:06:44 +1100 Nick Piggin <nickpiggin@yahoo.com.au>
> wrote:
> > > On Wednesday 07 January 2009 10:13:44 Andrew Morton wrote:
> > > > (cc added)
> > > >
> > > > On Tue, 6 Jan 2009 17:57:44 -0500
> > > >
> > > > Christoph Hellwig <hch@infradead.org> wrote:
> > > > > On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > > > > > softirq-introduce-statistics-for-softirq.patch
> > > > > > proc-export-statistics-for-softirq-to-proc.patch
> > > > > > proc-update-document-for-proc-softirqs-and-proc-stat.patch
> > > > >
> > > > > Why is this in procfs?
> > > >
> > > > softirq stuff in /proc seems appropriate? It's alongside
> > > > /proc/interrupts. We could put it in /trendy-fs-of-the-day, but what
> > > > would it gain us?
> > >
> > > Haven't we kind of agreed to use sysfs for things like this? A few years
> > > too late to be raising objections now ;)
> > >
> > > One problem I have with sysfs is that it (the directory structure, rather
> > > than the sysfs code itself) really needs to be policed and maintained
> > > by a central and coherent place/person with taste. Otherwise people put
> > > their own random crap with their own random naming schemes and becomes
> > > a crazy mess.
> > >
> > > softirqs are not hardware but purely kernel subsystem construct, as such
> > > they probably go under /sys/kernel/. People unfortunately have already
> > > added random crap to the /sys/kernel/ root directory, but future
> > > additions really should go into a good subdirectory structure (putting it
> > > into the root directory is equivalent to ditching all subdirectories from
> > > /proc/sys/).
> >
> > All sounds like pointless wank^Wbikeshed painting to me.
>
> Really? Our userspace ABI? You think it works bestter when there is as
> little thought as possible put into it and everybody just does what
> they feel is best?
If I thought that, I would say it.
>
> > > /sys/kernel/softirq/*, I suggest.
> >
> > What would that *improve*?
>
> It would be logically in the right place.
That's STILL not a *reason*. Nobody has provded a reason.
Here's a reason: look in /proc. It contains "interrupts", "irq",
"vmstat", "meminfo", etc. All simple files which provide realtime view
of core kernel activity. Which is precisely what /proc/softirq does!
So putting it in /proc/softirq is "logical", and yanking it out and
stuffing it in some random other place for reasons which nobody can
explain is illogical.
Plus the patch adds a summary line to the existing /proc/stat. Which
is also logical. Do we do that in debugfs too?
next prev parent reply other threads:[~2009-01-07 4:19 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 8:43 2.6.29 -mm merge plans Andrew Morton
2009-01-05 9:00 ` KOSAKI Motohiro
2009-01-05 9:07 ` Andrew Morton
2009-01-05 22:31 ` Ying Han
2009-01-05 22:34 ` Valdis.Kletnieks
2009-01-08 4:18 ` Ying Han
2009-01-08 4:41 ` KOSAKI Motohiro
2009-01-08 7:57 ` Ying Han
2009-01-08 8:31 ` KOSAKI Motohiro
2009-01-11 4:18 ` Valdis.Kletnieks
2009-01-12 4:18 ` Ying Han
2009-01-06 5:27 ` Valdis.Kletnieks
2009-01-06 5:41 ` Nick Piggin
2009-01-05 9:02 ` Sam Ravnborg
2009-01-05 9:12 ` Andrew Morton
2009-01-05 9:17 ` David Miller
2009-01-05 9:21 ` Ingo Molnar
2009-01-05 9:39 ` Sam Ravnborg
2009-01-05 10:10 ` Ingo Molnar
2009-01-05 10:36 ` David Miller
2009-01-05 12:32 ` Ingo Molnar
2009-01-05 10:11 ` Ingo Molnar
2009-01-05 10:37 ` David Miller
2009-01-05 9:40 ` Ryusuke Konishi
2009-01-06 13:30 ` Pekka Enberg
2009-01-07 3:26 ` Ryusuke Konishi
2009-01-07 7:58 ` Pekka Enberg
2009-01-07 14:17 ` Chris Mason
2009-01-05 11:34 ` Al Viro
2009-01-05 11:40 ` Stephen Rothwell
2008-10-06 6:14 ` Greg Ungerer
2009-01-05 12:17 ` Ingo Molnar
2009-01-05 17:38 ` KOSAKI Motohiro
2009-01-05 12:28 ` Nick Piggin
2009-01-12 22:06 ` Andrew Morton
2009-01-15 6:37 ` Nick Piggin
2009-01-06 9:46 ` Pavel Machek
2009-01-06 22:33 ` Folkert van Heusden
2009-01-06 22:38 ` Alan Cox
2009-01-06 22:57 ` Christoph Hellwig
2009-01-06 23:08 ` Andrew Morton
2009-01-07 1:05 ` Nick Piggin
2009-01-06 23:08 ` Andrew Morton
2009-01-06 23:22 ` Christoph Hellwig
2009-01-07 2:16 ` Dave Chinner
2009-01-08 15:50 ` Dmitri Monakhov
2009-01-06 23:11 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-07 1:14 ` Nick Piggin
2009-01-07 1:38 ` Andi Kleen
2009-01-07 1:49 ` Nick Piggin
2009-01-07 2:57 ` Andi Kleen
2009-01-07 3:28 ` Nick Piggin
2009-01-08 13:24 ` Pavel Machek
2009-01-10 15:07 ` Andi Kleen
2009-01-10 21:32 ` sync, reboot, and corrupting data [was Re: 2.6.29 -mm merge plans] Pavel Machek
2009-01-10 22:12 ` Andi Kleen
2009-01-10 22:26 ` Pavel Machek
2009-01-08 13:22 ` 2.6.29 -mm merge plans Pavel Machek
2009-01-06 23:13 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-06 23:38 ` Andrew Morton
2009-01-07 2:06 ` Nick Piggin
2009-01-07 2:16 ` Andrew Morton
2009-01-07 3:05 ` Nick Piggin
2009-01-07 4:16 ` Andrew Morton [this message]
2009-01-06 23:15 ` Andrew Morton
2009-01-06 23:25 ` Christoph Hellwig
2009-01-07 7:54 ` Christoph Hellwig
2009-01-07 7:59 ` Andrew Morton
2009-01-07 8:10 ` Christoph Hellwig
2009-01-06 23:17 ` Andrew Morton
2009-01-06 23:19 ` Christoph Hellwig
2009-01-06 23:26 ` Warren Turkal
2009-01-06 23:26 ` Warren Turkal
2009-01-12 3:19 ` Roman Zippel
2009-01-06 23:27 ` Diego E. 'Flameeyes' Pettenò
2009-01-06 23:31 ` Christoph Hellwig
2009-01-06 23:49 ` Harvey Harrison
2009-01-07 0:09 ` Diego E. 'Flameeyes' Pettenò
2009-01-07 0:16 ` Harvey Harrison
2009-01-12 4:21 ` Roman Zippel
2009-01-06 23:19 ` Andrew Morton
2009-01-08 19:11 ` Rodolfo Giometti
2009-01-12 20:23 ` Christoph Hellwig
2009-01-13 9:49 ` Rodolfo Giometti
2009-01-12 20:22 ` Christoph Hellwig
2009-01-13 9:47 ` Rodolfo Giometti
2009-01-06 23:21 ` Andrew Morton
2009-01-06 23:28 ` Andrew Morton
2009-01-07 2:21 ` Nick Piggin
2009-01-08 8:39 ` Miklos Szeredi
2009-01-15 6:45 ` Nick Piggin
2009-01-07 0:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106201657.bf9faa38.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kobayashi.kk@ncos.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).