From: "KOSAKI Motohiro" <kosaki.motohiro@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "Greg Ungerer" <gerg@snapgear.com>,
"Adrian Bunk" <bunk@kernel.org>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Subject: Re: 2.6.29 -mm merge plans
Date: Tue, 6 Jan 2009 02:38:55 +0900 [thread overview]
Message-ID: <2f11576a0901050938l2b30295ej80a068815ab2a49d@mail.gmail.com> (raw)
In-Reply-To: <20090105224007.20e60d02.sfr@canb.auug.org.au>
>> m68knommu-use-the-new-byteorder-headers.patch
>> m68knommu-set-no_dma.patch
>>
>> Architecture things. Will merge.
>
> I have an m68nommu tree as part of linux-next should these go there?
> (though the last - still outstanding - commit was in November).
I guess m68knommu-set-no_dma.patch isn't right and pci code in
m68knommu use DMA.
because ..
arch/m64knommu/include/asm/dma-mapping.h is
---------------------------------------------------
#ifndef _M68KNOMMU_DMA_MAPPING_H
#define _M68KNOMMU_DMA_MAPPING_H
#ifdef CONFIG_PCI
#include <asm-generic/dma-mapping.h>
#else
#include <asm-generic/dma-mapping-broken.h>
#endif
#endif /* _M68KNOMMU_DMA_MAPPING_H */
---------------------------------------------------
At least, original author think m68k pci driver use dma.
Recently, I propose following patch.
but nobody replay it ;)
but I also guess it doesn't matter because I guess nobody use m68knommu now ;-/
Subject: [PATCH for 2.6.28 stable] m68knommu: fix m68knommu defconfig
can't build
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Date: 2008/12/30 19:44
>I guess nobody don't test m68knommu at all last three month.
>Do we still need to maintain this architecture?
>
>
>==
>Currently, m68knommu defconfig can't build. it cause following error.
>
>net/built-in.o: In function `skb_dma_map':
>: undefined reference to `dma_mapping_error'
>net/built-in.o: In function `skb_dma_unmap':
>: undefined reference to `dma_unmap_single'
>net/built-in.o: In function `skb_dma_unmap':
>: undefined reference to `dma_unmap_page'
>net/built-in.o: In function `skb_dma_map':
>: undefined reference to `dma_map_single'
>net/built-in.o: In function `skb_dma_map':
>: undefined reference to `dma_map_page'
>net/built-in.o: In function `skb_dma_map':
>: undefined reference to `dma_unmap_page'
>net/built-in.o: In function `skb_dma_map':
>: undefined reference to `dma_unmap_single'
>
>because
> - CONFIG_DMA depend on !NO_DMA
> - m68knommu always doesn't turn on NO_DMA
> - if CONFIG_PCI=n, m68knommu/include/asm/dma-magging.h include
> asm-generic/dma-mapping-broken.h
> - dma-mapping-broken.h generate link time error.
> - m68knommu defconfig doesn't have CONFIG_PCI
> - On the other hand, net/core/skb_dma_map.c assume CONFIG_DMA=y mean
> dma related function is callable
>
>So, we want to turn on CONFIG_DMA if CONFIG_PCI=y only.
>
>
>CC: David S. Miller <davem@davemloft.net>
>CC: Geert Uytterhoeven <geert@linux-m68k.org>
>CC: Roman Zippel <zippel@linux-m68k.org>
>CC: Greg Ungerer <gerg@uclinux.org>
>CC: linux-m68k@lists.linux-m68k.org
>---
> arch/m68knommu/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
>Index: b/arch/m68knommu/Kconfig
>===================================================================
>--- a/arch/m68knommu/Kconfig 2008-12-25 08:26:37.000000000 +0900
>+++ b/arch/m68knommu/Kconfig 2008-12-28 21:09:58.000000000 +0900
>@@ -73,6 +73,9 @@ config GENERIC_CLOCKEVENTS
> config NO_IOPORT
> def_bool y
>
>+config NO_DMA
>+ def_bool !PCI
>+
> source "init/Kconfig"
>
> source "kernel/Kconfig.freezer"
next prev parent reply other threads:[~2009-01-05 17:39 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 8:43 2.6.29 -mm merge plans Andrew Morton
2009-01-05 9:00 ` KOSAKI Motohiro
2009-01-05 9:07 ` Andrew Morton
2009-01-05 22:31 ` Ying Han
2009-01-05 22:34 ` Valdis.Kletnieks
2009-01-08 4:18 ` Ying Han
2009-01-08 4:41 ` KOSAKI Motohiro
2009-01-08 7:57 ` Ying Han
2009-01-08 8:31 ` KOSAKI Motohiro
2009-01-11 4:18 ` Valdis.Kletnieks
2009-01-12 4:18 ` Ying Han
2009-01-06 5:27 ` Valdis.Kletnieks
2009-01-06 5:41 ` Nick Piggin
2009-01-05 9:02 ` Sam Ravnborg
2009-01-05 9:12 ` Andrew Morton
2009-01-05 9:17 ` David Miller
2009-01-05 9:21 ` Ingo Molnar
2009-01-05 9:39 ` Sam Ravnborg
2009-01-05 10:10 ` Ingo Molnar
2009-01-05 10:36 ` David Miller
2009-01-05 12:32 ` Ingo Molnar
2009-01-05 10:11 ` Ingo Molnar
2009-01-05 10:37 ` David Miller
2009-01-05 9:40 ` Ryusuke Konishi
2009-01-06 13:30 ` Pekka Enberg
2009-01-07 3:26 ` Ryusuke Konishi
2009-01-07 7:58 ` Pekka Enberg
2009-01-07 14:17 ` Chris Mason
2009-01-05 11:34 ` Al Viro
2009-01-05 11:40 ` Stephen Rothwell
2008-10-06 6:14 ` Greg Ungerer
2009-01-05 12:17 ` Ingo Molnar
2009-01-05 17:38 ` KOSAKI Motohiro [this message]
2009-01-05 12:28 ` Nick Piggin
2009-01-12 22:06 ` Andrew Morton
2009-01-15 6:37 ` Nick Piggin
2009-01-06 9:46 ` Pavel Machek
2009-01-06 22:33 ` Folkert van Heusden
2009-01-06 22:38 ` Alan Cox
2009-01-06 22:57 ` Christoph Hellwig
2009-01-06 23:08 ` Andrew Morton
2009-01-07 1:05 ` Nick Piggin
2009-01-06 23:08 ` Andrew Morton
2009-01-06 23:22 ` Christoph Hellwig
2009-01-07 2:16 ` Dave Chinner
2009-01-08 15:50 ` Dmitri Monakhov
2009-01-06 23:11 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-07 1:14 ` Nick Piggin
2009-01-07 1:38 ` Andi Kleen
2009-01-07 1:49 ` Nick Piggin
2009-01-07 2:57 ` Andi Kleen
2009-01-07 3:28 ` Nick Piggin
2009-01-08 13:24 ` Pavel Machek
2009-01-10 15:07 ` Andi Kleen
2009-01-10 21:32 ` sync, reboot, and corrupting data [was Re: 2.6.29 -mm merge plans] Pavel Machek
2009-01-10 22:12 ` Andi Kleen
2009-01-10 22:26 ` Pavel Machek
2009-01-08 13:22 ` 2.6.29 -mm merge plans Pavel Machek
2009-01-06 23:13 ` Andrew Morton
2009-01-06 23:24 ` Christoph Hellwig
2009-01-06 23:38 ` Andrew Morton
2009-01-07 2:06 ` Nick Piggin
2009-01-07 2:16 ` Andrew Morton
2009-01-07 3:05 ` Nick Piggin
2009-01-07 4:16 ` Andrew Morton
2009-01-06 23:15 ` Andrew Morton
2009-01-06 23:25 ` Christoph Hellwig
2009-01-07 7:54 ` Christoph Hellwig
2009-01-07 7:59 ` Andrew Morton
2009-01-07 8:10 ` Christoph Hellwig
2009-01-06 23:17 ` Andrew Morton
2009-01-06 23:19 ` Christoph Hellwig
2009-01-06 23:26 ` Warren Turkal
2009-01-06 23:26 ` Warren Turkal
2009-01-12 3:19 ` Roman Zippel
2009-01-06 23:27 ` Diego E. 'Flameeyes' Pettenò
2009-01-06 23:31 ` Christoph Hellwig
2009-01-06 23:49 ` Harvey Harrison
2009-01-07 0:09 ` Diego E. 'Flameeyes' Pettenò
2009-01-07 0:16 ` Harvey Harrison
2009-01-12 4:21 ` Roman Zippel
2009-01-06 23:19 ` Andrew Morton
2009-01-08 19:11 ` Rodolfo Giometti
2009-01-12 20:23 ` Christoph Hellwig
2009-01-13 9:49 ` Rodolfo Giometti
2009-01-12 20:22 ` Christoph Hellwig
2009-01-13 9:47 ` Rodolfo Giometti
2009-01-06 23:21 ` Andrew Morton
2009-01-06 23:28 ` Andrew Morton
2009-01-07 2:21 ` Nick Piggin
2009-01-08 8:39 ` Miklos Szeredi
2009-01-15 6:45 ` Nick Piggin
2009-01-07 0:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f11576a0901050938l2b30295ej80a068815ab2a49d@mail.gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).