linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nick Bowler <nbowler@elliptictech.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com, gregkh@suse.de
Subject: Re: [Regression, bisected] Transmit failure in et131x.
Date: Thu, 8 Oct 2009 22:32:02 +0100	[thread overview]
Message-ID: <20091008223202.6e1b1303@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20091008140805.GA21535@emergent.ellipticsemi.com>

> I bisected the problem to the following commit.  The WARN messages and
> bisection log are at the end of this email.
> 
> 356c74b401f6b05ae5d793e9d1a9ba8297b8e3ff is first bad commit
> commit 356c74b401f6b05ae5d793e9d1a9ba8297b8e3ff
> Author: Alan Cox <alan@linux.intel.com>
> Date:   Thu Aug 27 11:01:57 2009 +0100

Thanks. I'll go through that patch again see what I broke on your card.
Probably a wrapping bug with a long queue that my box for some reason
didn't manage to hit.

> Oct  5 23:37:53 aphrodite WARNING: at net/sched/sch_generic.c:261 dev_watchdog+0x13c/0x1fd()
> Oct  5 23:37:53 aphrodite Hardware name: System Product Name
> Oct  5 23:37:53 aphrodite NETDEV WATCHDOG: eth0 (et131x): transmit queue 0 timed out

That is the important bit. The rest is fall out from the fact the driver
doesn't recover properly when it fails.

Alan

  reply	other threads:[~2009-10-08 21:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-08 14:08 [Regression, bisected] Transmit failure in et131x Nick Bowler
2009-10-08 21:32 ` Alan Cox [this message]
2009-10-09 10:20 ` Alan Cox
2009-10-11 23:00   ` Nick Bowler
2009-10-12 10:36     ` Alan Cox
2009-10-12 14:19       ` Nick Bowler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091008223202.6e1b1303@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbowler@elliptictech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).