From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Nick Bowler <nbowler@draconx.ca>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Regression, bisected] Transmit failure in et131x.
Date: Mon, 12 Oct 2009 11:36:29 +0100 [thread overview]
Message-ID: <20091012113629.4ed8e7f4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <loom.20091012T004346-812@post.gmane.org>
> Thanks a lot for your help. Alas, this does not resolve the issue.
> Using tcpdump indicates that receive continues to work while transmit
> fails.
>
> I was using gigabit, but the problem persists when I run at 100mbit.
> The MTU setting remains at the default 1500 bytes.
et131x: Fix the add_10bit macro
From: Alan Cox <alan@linux.intel.com>
Duh.. we need to preserve the wrap bit when adding.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/staging/et131x/et1310_address_map.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/et131x/et1310_address_map.h b/drivers/staging/et131x/et1310_address_map.h
index 2273926..d71e04a 100644
--- a/drivers/staging/et131x/et1310_address_map.h
+++ b/drivers/staging/et131x/et1310_address_map.h
@@ -223,7 +223,7 @@ typedef union _TXDMA_PR_NUM_DES_t {
extern inline void add_10bit(u32 *v, int n)
{
- *v = INDEX10(*v + n);
+ *v = INDEX10(*v + n) | (*v & ET_DMA10_WRAP);
}
/*
next prev parent reply other threads:[~2009-10-12 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 14:08 [Regression, bisected] Transmit failure in et131x Nick Bowler
2009-10-08 21:32 ` Alan Cox
2009-10-09 10:20 ` Alan Cox
2009-10-11 23:00 ` Nick Bowler
2009-10-12 10:36 ` Alan Cox [this message]
2009-10-12 14:19 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012113629.4ed8e7f4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@draconx.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).