* linux-next: build warning after merge of the sound tree
@ 2010-02-23 5:07 Stephen Rothwell
2010-02-23 5:20 ` Luke Yelavich
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2010-02-23 5:07 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel, Luke Yelavich
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:
sound/pci/hda/patch_realtek.c:7016: warning: 'alc885_macmini3_ch2_init' defined but not used
sound/pci/hda/patch_realtek.c:7028: warning: 'alc885_macmini3_ch6_init' defined but not used
Introduced by commit e458b1fadf9239d1fdb165ff4c4ea0d807041bec ("ALSA: hda
- Add Macmini 3,1 support").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2010-02-23 5:07 linux-next: build warning after merge of the sound tree Stephen Rothwell
@ 2010-02-23 5:20 ` Luke Yelavich
2010-02-23 7:11 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Luke Yelavich @ 2010-02-23 5:20 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Takashi Iwai, linux-next, linux-kernel
On Tue, Feb 23, 2010 at 04:07:46PM EST, Stephen Rothwell wrote:
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
>
> sound/pci/hda/patch_realtek.c:7016: warning: 'alc885_macmini3_ch2_init' defined but not used
> sound/pci/hda/patch_realtek.c:7028: warning: 'alc885_macmini3_ch6_init' defined but not used
>
> Introduced by commit e458b1fadf9239d1fdb165ff4c4ea0d807041bec ("ALSA: hda
> - Add Macmini 3,1 support").
Whoops, thats my fault. I'll send a patch to the ALSA dev list to fix that right away.
Luke
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2010-02-23 5:20 ` Luke Yelavich
@ 2010-02-23 7:11 ` Takashi Iwai
0 siblings, 0 replies; 16+ messages in thread
From: Takashi Iwai @ 2010-02-23 7:11 UTC (permalink / raw)
To: Luke Yelavich; +Cc: Stephen Rothwell, linux-next, linux-kernel
At Tue, 23 Feb 2010 16:20:00 +1100,
Luke Yelavich wrote:
>
> On Tue, Feb 23, 2010 at 04:07:46PM EST, Stephen Rothwell wrote:
> > Hi Takashi,
> >
> > After merging the sound tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> >
> > sound/pci/hda/patch_realtek.c:7016: warning: 'alc885_macmini3_ch2_init' defined but not used
> > sound/pci/hda/patch_realtek.c:7028: warning: 'alc885_macmini3_ch6_init' defined but not used
> >
> > Introduced by commit e458b1fadf9239d1fdb165ff4c4ea0d807041bec ("ALSA: hda
> > - Add Macmini 3,1 support").
>
> Whoops, thats my fault. I'll send a patch to the ALSA dev list to fix that right away.
I already fixed differently (just cleaned up, it's identical with mb5
definition). At the next time, please add me to Cc so that I can pick
up more quickly.
thanks,
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the sound tree
@ 2010-03-30 3:48 Stephen Rothwell
2010-03-30 6:07 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2010-03-30 3:48 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
sound/pci/hda/patch_realtek.c: In function 'fillup_priv_adc_nids':
sound/pci/hda/patch_realtek.c:5120: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
sound/pci/hda/patch_realtek.c:5120: warning: too few arguments for format
Introduced by commit 6694635d3ae1b038d7a0e38b80637db867c7c8e2 ("ALSA: hda
- Fix ADC/MUX assignment of ALC269 codec").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2010-03-30 3:48 Stephen Rothwell
@ 2010-03-30 6:07 ` Takashi Iwai
0 siblings, 0 replies; 16+ messages in thread
From: Takashi Iwai @ 2010-03-30 6:07 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
At Tue, 30 Mar 2010 14:48:09 +1100,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> sound/pci/hda/patch_realtek.c: In function 'fillup_priv_adc_nids':
> sound/pci/hda/patch_realtek.c:5120: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
> sound/pci/hda/patch_realtek.c:5120: warning: too few arguments for format
>
> Introduced by commit 6694635d3ae1b038d7a0e38b80637db867c7c8e2 ("ALSA: hda
> - Fix ADC/MUX assignment of ALC269 codec").
Fixed now. Thanks!
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the sound tree
@ 2019-01-21 0:21 Stephen Rothwell
2019-01-21 8:13 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2019-01-21 0:21 UTC (permalink / raw)
To: Takashi Iwai
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jaroslav Kysela
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
Hi Takashi,
After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' [-Wunused-variable]
struct hda_pcm *pcm;
^~~
Introduced by commit
17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2019-01-21 0:21 Stephen Rothwell
@ 2019-01-21 8:13 ` Takashi Iwai
0 siblings, 0 replies; 16+ messages in thread
From: Takashi Iwai @ 2019-01-21 8:13 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Jaroslav Kysela
On Mon, 21 Jan 2019 01:21:48 +0100,
Stephen Rothwell wrote:
On Mon, 21 Jan 2019 01:21:48 +0100,
Stephen Rothwell wrote:
>
> Hi Takashi,
>
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
> sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' [-Wunused-variable]
> struct hda_pcm *pcm;
> ^~~
>
> Introduced by commit
>
> 17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")
Thanks, fixed now with the patch below.
Takashi
-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: hda - Fix unused variable warning
The unused variable was forgotten to be removed and now we get a
compiler warning:
sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm'
Fixes: 17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/hda/hda_codec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index ff6dbed4d3cd..e4704f5729d3 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2923,7 +2923,6 @@ static void hda_call_codec_resume(struct hda_codec *codec)
static int hda_codec_runtime_suspend(struct device *dev)
{
struct hda_codec *codec = dev_to_hda_codec(dev);
- struct hda_pcm *pcm;
unsigned int state;
cancel_delayed_work_sync(&codec->jackpoll_work);
--
2.16.4
^ permalink raw reply related [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the sound tree
@ 2019-12-12 0:28 Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2019-12-12 0:28 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 465 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
sound/pci/hda/hda_tegra.c:169:19: warning: unused variable 'bus' [-Wunused-variable]
169 | struct hdac_bus *bus = azx_bus(chip);
| ^~~
Introduced by commit
f36da9406e66 ("ALSA: hda: Support PCM sync_stop")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* linux-next: build warning after merge of the sound tree
@ 2020-05-01 4:03 Stephen Rothwell
2020-05-01 7:33 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2020-05-01 4:03 UTC (permalink / raw)
To: Takashi Iwai
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kai-Heng Feng
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
sound/pci/hda/patch_realtek.c: In function 'alc_fixup_hp_gpio_led':
sound/pci/hda/patch_realtek.c:4134:6: warning: unused variable 'err' [-Wunused-variable]
4134 | int err;
| ^~~
Introduced by commit
87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2020-05-01 4:03 Stephen Rothwell
@ 2020-05-01 7:33 ` Takashi Iwai
0 siblings, 0 replies; 16+ messages in thread
From: Takashi Iwai @ 2020-05-01 7:33 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kai-Heng Feng
On Fri, 01 May 2020 06:03:23 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> sound/pci/hda/patch_realtek.c: In function 'alc_fixup_hp_gpio_led':
> sound/pci/hda/patch_realtek.c:4134:6: warning: unused variable 'err' [-Wunused-variable]
> 4134 | int err;
> | ^~~
>
> Introduced by commit
>
> 87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")
I submitted the fix patch now and it will be included later:
https://lore.kernel.org/r/20200501072857.13720-1-tiwai@suse.de
thanks,
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the sound tree
@ 2021-08-23 10:00 Stephen Rothwell
2021-08-23 14:27 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2021-08-23 10:00 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/sound/alsa-configuration.rst:2258: WARNING: Unexpected indentation.
Introduced by commit
a39978ed6df1 ("ALSA: doc: Add the description of quirk_flags option for snd-usb-audio")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* linux-next: build warning after merge of the sound tree
@ 2023-02-08 23:48 Stephen Rothwell
2023-02-09 3:14 ` Stephen Rothwell
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2023-02-08 23:48 UTC (permalink / raw)
To: Takashi Iwai
Cc: Uwe Kleine-König, Jaroslav Kysela, Takashi Sakamoto,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
sound/ppc/snd_ps3.c: In function 'snd_ps3_driver_remove':
sound/ppc/snd_ps3.c:1049:13: warning: unused variable 'ret' [-Wunused-variable]
1049 | int ret;
| ^~~
Introduced by commit
25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2023-02-08 23:48 Stephen Rothwell
@ 2023-02-09 3:14 ` Stephen Rothwell
0 siblings, 0 replies; 16+ messages in thread
From: Stephen Rothwell @ 2023-02-09 3:14 UTC (permalink / raw)
To: Takashi Iwai
Cc: Uwe Kleine-König, Jaroslav Kysela, Takashi Sakamoto,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
Hi all,
On Thu, 9 Feb 2023 10:48:23 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> sound/ppc/snd_ps3.c: In function 'snd_ps3_driver_remove':
> sound/ppc/snd_ps3.c:1049:13: warning: unused variable 'ret' [-Wunused-variable]
> 1049 | int ret;
> | ^~~
>
> Introduced by commit
>
> 25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void")
This became a build failure in my powerpc allyesconfig build, so I
applied the supplied patch for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next: build warning after merge of the sound tree
@ 2023-08-25 5:29 Stephen Rothwell
2023-08-25 9:24 ` Takashi Iwai
0 siblings, 1 reply; 16+ messages in thread
From: Stephen Rothwell @ 2023-08-25 5:29 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
Hi all,
After merging the sound tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/sound/designs/midi-2.0.rst:517: WARNING: Inline interpreted text or phrase reference start-string without end-string.
Introduced by commit
e240cff9e6e9 ("ALSA: documentation: Add description for USB MIDI 2.0 gadget driver")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: linux-next: build warning after merge of the sound tree
2023-08-25 5:29 Stephen Rothwell
@ 2023-08-25 9:24 ` Takashi Iwai
0 siblings, 0 replies; 16+ messages in thread
From: Takashi Iwai @ 2023-08-25 9:24 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Takashi Iwai, Linux Kernel Mailing List, Linux Next Mailing List
On Fri, 25 Aug 2023 07:29:57 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/sound/designs/midi-2.0.rst:517: WARNING: Inline interpreted text or phrase reference start-string without end-string.
>
> Introduced by commit
>
> e240cff9e6e9 ("ALSA: documentation: Add description for USB MIDI 2.0 gadget driver")
It was a missing backquote. Now fixed.
Thanks!
Takashi
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2023-08-25 9:25 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-23 5:07 linux-next: build warning after merge of the sound tree Stephen Rothwell
2010-02-23 5:20 ` Luke Yelavich
2010-02-23 7:11 ` Takashi Iwai
2010-03-30 3:48 Stephen Rothwell
2010-03-30 6:07 ` Takashi Iwai
2019-01-21 0:21 Stephen Rothwell
2019-01-21 8:13 ` Takashi Iwai
2019-12-12 0:28 Stephen Rothwell
2020-05-01 4:03 Stephen Rothwell
2020-05-01 7:33 ` Takashi Iwai
2021-08-23 10:00 Stephen Rothwell
2021-08-23 14:27 ` Takashi Iwai
2023-02-08 23:48 Stephen Rothwell
2023-02-09 3:14 ` Stephen Rothwell
2023-08-25 5:29 Stephen Rothwell
2023-08-25 9:24 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).