From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Neil Brown <neilb@suse.de>
Subject: linux-next: build warning after merge of the rcu tree
Date: Mon, 6 Sep 2010 12:14:08 +1000 [thread overview]
Message-ID: <20100906121408.33946fbe.sfr@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
Hi Paul,
After merging the rcu tree, today's linux-next build
(powerpc ppc64_defconfig) produced this warning:
drivers/md/raid1.c: In function 'read_balance':
drivers/md/raid1.c:445: warning: operation on 'new_disk' may be undefined
I am picking on the rcu tree because the line above has not changed since
2005. The line is:
for (rdev = rcu_dereference(conf->mirrors[new_disk].rdev);
r1_bio->bios[new_disk] == IO_BLOCKED ||
!rdev || !test_bit(In_sync, &rdev->flags)
|| test_bit(WriteMostly, &rdev->flags);
rdev = rcu_dereference(conf->mirrors[++new_disk].rdev)) {
Where new_disk is being updated in the parameter to the last
rcu_dereference.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next reply other threads:[~2010-09-06 2:14 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 2:14 Stephen Rothwell [this message]
2010-09-06 2:32 ` linux-next: build warning after merge of the rcu tree Neil Brown
2010-09-06 3:02 ` Stephen Rothwell
2010-09-06 5:37 ` Paul E. McKenney
2011-03-25 5:05 Stephen Rothwell
2011-03-25 19:23 ` Paul E. McKenney
2011-08-24 4:23 Stephen Rothwell
2011-08-24 12:27 ` Paul E. McKenney
2011-08-25 0:46 ` Arnaud Lacombe
2011-08-25 5:04 ` Paul E. McKenney
2017-06-21 6:48 Stephen Rothwell
2017-06-21 13:30 ` Paul E. McKenney
2019-12-12 5:06 Stephen Rothwell
2019-12-12 6:02 ` Paul E. McKenney
2019-12-12 6:38 ` Eric Dumazet
2019-12-12 6:57 ` Eric Dumazet
2020-01-10 21:57 ` Paul E. McKenney
2020-01-15 16:42 ` Paul E. McKenney
2019-12-12 11:40 ` Stephen Rothwell
2019-12-13 1:31 ` Paul E. McKenney
2020-01-06 17:51 ` Olof Johansson
2020-01-06 18:10 ` Paul E. McKenney
2020-01-06 21:08 ` Olof Johansson
2020-01-06 21:43 ` Paul E. McKenney
2020-03-10 2:27 Stephen Rothwell
2020-03-10 2:49 ` Paul E. McKenney
2020-12-07 8:20 Stephen Rothwell
2020-12-07 16:47 ` Paul E. McKenney
2020-12-07 17:48 ` Jonathan Corbet
2020-12-07 18:53 ` Paul E. McKenney
2021-03-04 1:41 Stephen Rothwell
2021-03-04 1:48 ` Paul E. McKenney
2022-06-15 5:38 Stephen Rothwell
2022-06-15 13:55 ` Paul E. McKenney
2022-11-07 3:26 Stephen Rothwell
2022-11-07 5:02 ` Paul E. McKenney
2022-11-07 9:28 ` Akira Yokosawa
2023-03-21 2:50 Stephen Rothwell
2023-03-21 3:01 ` Boqun Feng
2023-04-06 4:43 Stephen Rothwell
2023-04-06 14:15 ` Paul E. McKenney
2023-07-26 2:32 Stephen Rothwell
2023-07-26 3:33 ` Paul E. McKenney
2023-07-26 3:48 ` Paul E. McKenney
2023-07-26 6:37 ` Stephen Rothwell
2024-01-25 3:33 Stephen Rothwell
2024-01-25 13:18 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100906121408.33946fbe.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).