From: "Paul E. McKenney" <paulmck@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the rcu tree
Date: Tue, 25 Jul 2023 20:48:13 -0700 [thread overview]
Message-ID: <adba817d-a02b-49fb-bf3d-a22779303764@paulmck-laptop> (raw)
In-Reply-To: <1c8c257e-55e3-4de9-b2c8-1421c11df664@paulmck-laptop>
On Tue, Jul 25, 2023 at 08:33:06PM -0700, Paul E. McKenney wrote:
> On Wed, Jul 26, 2023 at 12:32:30PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the rcu tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > WARNING: modpost: vmlinux: section mismatch in reference: cmdline_load_proc_show+0x22 (section: .text) -> boot_command_line (section: .init.data)
> >
> > Introduced by commit
> >
> > cf9eca90a339 ("fs/proc: Add /proc/cmdline_load for boot loader arguments")
>
> That __initdata needs to be __ro_after_init, doesn't it? Will fix,
> thank you!
Sigh. Hit "send" too soon. :-/
Does the following incremental diff (to be squashed into the original) help?
Thanx, Paul
------------------------------------------------------------------------
diff --git a/init/main.c b/init/main.c
index c946ab87783a..981170da0b1c 100644
--- a/init/main.c
+++ b/init/main.c
@@ -135,7 +135,7 @@ EXPORT_SYMBOL(system_state);
void (*__initdata late_time_init)(void);
/* Untouched command line saved by arch-specific code. */
-char __initdata boot_command_line[COMMAND_LINE_SIZE];
+char boot_command_line[COMMAND_LINE_SIZE] __ro_after_init;
/* Untouched saved command line (eg. for /proc) */
char *saved_command_line __ro_after_init;
unsigned int saved_command_line_len __ro_after_init;
next prev parent reply other threads:[~2023-07-26 3:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 2:32 linux-next: build warning after merge of the rcu tree Stephen Rothwell
2023-07-26 3:33 ` Paul E. McKenney
2023-07-26 3:48 ` Paul E. McKenney [this message]
2023-07-26 6:37 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-01-25 3:33 Stephen Rothwell
2024-01-25 13:18 ` Paul E. McKenney
2023-04-06 4:43 Stephen Rothwell
2023-04-06 14:15 ` Paul E. McKenney
2023-03-21 2:50 Stephen Rothwell
2023-03-21 3:01 ` Boqun Feng
2022-11-07 3:26 Stephen Rothwell
2022-11-07 5:02 ` Paul E. McKenney
2022-11-07 9:28 ` Akira Yokosawa
2022-06-15 5:38 Stephen Rothwell
2022-06-15 13:55 ` Paul E. McKenney
2021-03-04 1:41 Stephen Rothwell
2021-03-04 1:48 ` Paul E. McKenney
2020-12-07 8:20 Stephen Rothwell
2020-12-07 16:47 ` Paul E. McKenney
2020-12-07 17:48 ` Jonathan Corbet
2020-12-07 18:53 ` Paul E. McKenney
2020-03-10 2:27 Stephen Rothwell
2020-03-10 2:49 ` Paul E. McKenney
2019-12-12 5:06 Stephen Rothwell
2019-12-12 6:02 ` Paul E. McKenney
2019-12-12 6:38 ` Eric Dumazet
2019-12-12 6:57 ` Eric Dumazet
2020-01-10 21:57 ` Paul E. McKenney
2020-01-15 16:42 ` Paul E. McKenney
2019-12-12 11:40 ` Stephen Rothwell
2019-12-13 1:31 ` Paul E. McKenney
2020-01-06 17:51 ` Olof Johansson
2020-01-06 18:10 ` Paul E. McKenney
2020-01-06 21:08 ` Olof Johansson
2020-01-06 21:43 ` Paul E. McKenney
2017-06-21 6:48 Stephen Rothwell
2017-06-21 13:30 ` Paul E. McKenney
2011-08-24 4:23 Stephen Rothwell
2011-08-24 12:27 ` Paul E. McKenney
2011-08-25 0:46 ` Arnaud Lacombe
2011-08-25 5:04 ` Paul E. McKenney
2011-03-25 5:05 Stephen Rothwell
2011-03-25 19:23 ` Paul E. McKenney
2010-09-06 2:14 Stephen Rothwell
2010-09-06 2:32 ` Neil Brown
2010-09-06 3:02 ` Stephen Rothwell
2010-09-06 5:37 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adba817d-a02b-49fb-bf3d-a22779303764@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).