linux-next: build warning after merge of the final tree (driver-core tree related)

linux-next: build warning after merge of the final tree (driver-core tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Hi Greg,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) produced this warning:

kernel/params.c: In function 'parse_args':
kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes

Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
Debug: Introduce global fake module param module.ddebug") which added a
1024 byte array to the stack ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Greg KH]

On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) produced this warning:
> 
> kernel/params.c: In function 'parse_args':
> kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> 
> Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> Debug: Introduce global fake module param module.ddebug") which added a
> 1024 byte array to the stack ...

Wierd, why didn't this show up yesterday?  The patch was in that tree
then, right?

Thomas, care to fix this up?

thanks,

greg k-h

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

Hi Greg,

On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH <greg@kroah.com> wrote:
>
> Wierd, why didn't this show up yesterday?  The patch was in that tree
> then, right?

It may have ... there are lots of warnings and I don't always notice new ones.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Randy Dunlap]

On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:

> On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > After merging the final tree, today's linux-next build (powerpc
> > allnoconfig) produced this warning:
> > 
> > kernel/params.c: In function 'parse_args':
> > kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> > 
> > Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> > Debug: Introduce global fake module param module.ddebug") which added a
> > 1024 byte array to the stack ...
> 
> Wierd, why didn't this show up yesterday?  The patch was in that tree
> then, right?
> 
> Thomas, care to fix this up?


ping.  Is Thomas around??

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Thomas Renninger]

On Monday 13 September 2010 17:51:55 Randy Dunlap wrote:
> On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:
> 
> > On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > After merging the final tree, today's linux-next build (powerpc
> > > allnoconfig) produced this warning:
> > > 
> > > kernel/params.c: In function 'parse_args':
> > > kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> > > 
> > > Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> > > Debug: Introduce global fake module param module.ddebug") which added a
> > > 1024 byte array to the stack ...
> > 
> > Wierd, why didn't this show up yesterday?  The patch was in that tree
> > then, right?
> > 
> > Thomas, care to fix this up?
>  
> ping.  Is Thomas around??
Yep, sorry for not responding.

I tried to reproduce this on ppc64, but above file compiled without
warning with dynamic debug set. Thus I thought this still came from the
old patch.

I have another solution for that, please drop above patch.
Jason pointed out that kernel boot params for compiled-in modules are
not recognized correctly. I fiddled with that for quite some time last week...

I should be able to send something tomorrow.
I will include lkml as it touches several files, would be great if Greg
can pick them up again if feedback is positive.

Thanks,

    Thomas

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Greg KH]

On Mon, Sep 13, 2010 at 09:26:13PM +0200, Thomas Renninger wrote:
> On Monday 13 September 2010 17:51:55 Randy Dunlap wrote:
> > On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:
> > 
> > > On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> > > > Hi Greg,
> > > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allnoconfig) produced this warning:
> > > > 
> > > > kernel/params.c: In function 'parse_args':
> > > > kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> > > > 
> > > > Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> > > > Debug: Introduce global fake module param module.ddebug") which added a
> > > > 1024 byte array to the stack ...
> > > 
> > > Wierd, why didn't this show up yesterday?  The patch was in that tree
> > > then, right?
> > > 
> > > Thomas, care to fix this up?
> >  
> > ping.  Is Thomas around??
> Yep, sorry for not responding.
> 
> I tried to reproduce this on ppc64, but above file compiled without
> warning with dynamic debug set. Thus I thought this still came from the
> old patch.
> 
> I have another solution for that, please drop above patch.
> Jason pointed out that kernel boot params for compiled-in modules are
> not recognized correctly. I fiddled with that for quite some time last week...
> 
> I should be able to send something tomorrow.
> I will include lkml as it touches several files, would be great if Greg
> can pick them up again if feedback is positive.

Ok, which exact patch do you want me to drop, the "Introduce global fake
module param..." one?

thanks,

greg k-h

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Thomas Renninger]

On Monday 13 September 2010 22:57:12 Greg KH wrote:
> On Mon, Sep 13, 2010 at 09:26:13PM +0200, Thomas Renninger wrote:
> > On Monday 13 September 2010 17:51:55 Randy Dunlap wrote:
> > > On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:
> > > 
> > > > On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > After merging the final tree, today's linux-next build (powerpc
> > > > > allnoconfig) produced this warning:
> > > > > 
> > > > > kernel/params.c: In function 'parse_args':
> > > > > kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> > > > > 
> > > > > Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> > > > > Debug: Introduce global fake module param module.ddebug") which added a
> > > > > 1024 byte array to the stack ...
> > > > 
> > > > Wierd, why didn't this show up yesterday?  The patch was in that tree
> > > > then, right?
> > > > 
> > > > Thomas, care to fix this up?
> > >  
> > > ping.  Is Thomas around??
> > Yep, sorry for not responding.
> > 
> > I tried to reproduce this on ppc64, but above file compiled without
> > warning with dynamic debug set. Thus I thought this still came from the
> > old patch.
> > 
> > I have another solution for that, please drop above patch.
> > Jason pointed out that kernel boot params for compiled-in modules are
> > not recognized correctly. I fiddled with that for quite some time last week...
> > 
> > I should be able to send something tomorrow.
> > I will include lkml as it touches several files, would be great if Greg
> > can pick them up again if feedback is positive.
> 
> Ok, which exact patch do you want me to drop, the "Introduce global fake
> module param..." one?
Yes, please.

Thanks,

       Thomas

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Greg KH]

On Tue, Sep 14, 2010 at 09:22:51AM +0200, Thomas Renninger wrote:
> On Monday 13 September 2010 22:57:12 Greg KH wrote:
> > On Mon, Sep 13, 2010 at 09:26:13PM +0200, Thomas Renninger wrote:
> > > On Monday 13 September 2010 17:51:55 Randy Dunlap wrote:
> > > > On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:
> > > > 
> > > > > On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> > > > > > Hi Greg,
> > > > > > 
> > > > > > After merging the final tree, today's linux-next build (powerpc
> > > > > > allnoconfig) produced this warning:
> > > > > > 
> > > > > > kernel/params.c: In function 'parse_args':
> > > > > > kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> > > > > > 
> > > > > > Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> > > > > > Debug: Introduce global fake module param module.ddebug") which added a
> > > > > > 1024 byte array to the stack ...
> > > > > 
> > > > > Wierd, why didn't this show up yesterday?  The patch was in that tree
> > > > > then, right?
> > > > > 
> > > > > Thomas, care to fix this up?
> > > >  
> > > > ping.  Is Thomas around??
> > > Yep, sorry for not responding.
> > > 
> > > I tried to reproduce this on ppc64, but above file compiled without
> > > warning with dynamic debug set. Thus I thought this still came from the
> > > old patch.
> > > 
> > > I have another solution for that, please drop above patch.
> > > Jason pointed out that kernel boot params for compiled-in modules are
> > > not recognized correctly. I fiddled with that for quite some time last week...
> > > 
> > > I should be able to send something tomorrow.
> > > I will include lkml as it touches several files, would be great if Greg
> > > can pick them up again if feedback is positive.
> > 
> > Ok, which exact patch do you want me to drop, the "Introduce global fake
> > module param..." one?
> Yes, please.

Now dropped.

thanks,

greg k-h

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

Hi Thomas,

On Mon, 13 Sep 2010 21:26:13 +0200 Thomas Renninger <trenn@suse.de> wrote:
>
> On Monday 13 September 2010 17:51:55 Randy Dunlap wrote:
> > On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:
> > 
> > > On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
> > > > 
> > > > After merging the final tree, today's linux-next build (powerpc
> > > > allnoconfig) produced this warning:
> > > > 
> > > > kernel/params.c: In function 'parse_args':
> > > > kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
> > > > 
> > > > Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
> > > > Debug: Introduce global fake module param module.ddebug") which added a
> > > > 1024 byte array to the stack ...
> > > 
> > > Wierd, why didn't this show up yesterday?  The patch was in that tree
> > > then, right?
> > > 
> > > Thomas, care to fix this up?
> >  
> > ping.  Is Thomas around??
> Yep, sorry for not responding.
> 
> I tried to reproduce this on ppc64, but above file compiled without
> warning with dynamic debug set. Thus I thought this still came from the
> old patch.

The report is for a powerpc allnoconfig build (see above) i.e. ppc32.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Randy Dunlap]

On 09/13/10 21:31, Stephen Rothwell wrote:
> Hi Thomas,
> 
> On Mon, 13 Sep 2010 21:26:13 +0200 Thomas Renninger <trenn@suse.de> wrote:
>>
>> On Monday 13 September 2010 17:51:55 Randy Dunlap wrote:
>>> On Mon, 6 Sep 2010 19:34:04 -0700 Greg KH wrote:
>>>
>>>> On Tue, Sep 07, 2010 at 11:54:26AM +1000, Stephen Rothwell wrote:
>>>>>
>>>>> After merging the final tree, today's linux-next build (powerpc
>>>>> allnoconfig) produced this warning:
>>>>>
>>>>> kernel/params.c: In function 'parse_args':
>>>>> kernel/params.c:233: warning: the frame size of 1032 bytes is larger than 1024 bytes
>>>>>
>>>>> Introduced by commit 32e6407e9361cd1aac39ff6b744cad48d1802a08 ("Dynamic
>>>>> Debug: Introduce global fake module param module.ddebug") which added a
>>>>> 1024 byte array to the stack ...
>>>>
>>>> Wierd, why didn't this show up yesterday?  The patch was in that tree
>>>> then, right?
>>>>
>>>> Thomas, care to fix this up?
>>>  
>>> ping.  Is Thomas around??
>> Yep, sorry for not responding.
>>
>> I tried to reproduce this on ppc64, but above file compiled without
>> warning with dynamic debug set. Thus I thought this still came from the
>> old patch.
> 
> The report is for a powerpc allnoconfig build (see above) i.e. ppc32.


It also happens on x86_32 (i386).

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

linux-next: build warning after merge of the final tree (driver-core tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi all,

After merging the final tree, today's linux-next build (sparc32 defconfig)
produced this warning:

drivers/base/firmware_class.c:921:13: warning: 'kill_requests_without_uevent' defined but not used [-Wunused-function]

Introduced by commit ddf1f0648e8c ("firmware loader: fix build failure
with !CONFIG_FW_LOADER_USER_HELPER").  This build does no have
CONFIG_PM_SLEEP defined.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Ming Lei]

On Thu, Jun 6, 2013 at 3:32 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (sparc32 defconfig)
> produced this warning:
>
> drivers/base/firmware_class.c:921:13: warning: 'kill_requests_without_uevent' defined but not used [-Wunused-function]

Hmm, miss test with !CONFIG_PM_SLEEP.

I will post a patch to fix the warning, sorry for introducing these things.

Thanks,
--
Ming Lei

linux-next: build warning after merge of the final tree (driver-core tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig among others) produced these warnings:

drivers/base/firmware_class.c:1254:12: warning: 'cache_firmware' defined but not used [-Wunused-function]
 static int cache_firmware(const char *fw_name)
            ^
drivers/base/firmware_class.c:1281:12: warning: 'uncache_firmware' defined but not used [-Wunused-function]
 static int uncache_firmware(const char *fw_name)
            ^

Revealed by commit 93232e46b209 ("firmware loader: don't export
cache_firmware and uncache_firmware") from the driver-core tree.  These
are only used if CONFIG_PM_SLEEP is set.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Greg KH]

On Wed, Jun 19, 2013 at 06:00:27PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig among others) produced these warnings:
> 
> drivers/base/firmware_class.c:1254:12: warning: 'cache_firmware' defined but not used [-Wunused-function]
>  static int cache_firmware(const char *fw_name)
>             ^
> drivers/base/firmware_class.c:1281:12: warning: 'uncache_firmware' defined but not used [-Wunused-function]
>  static int uncache_firmware(const char *fw_name)
>             ^
> 
> Revealed by commit 93232e46b209 ("firmware loader: don't export
> cache_firmware and uncache_firmware") from the driver-core tree.  These
> are only used if CONFIG_PM_SLEEP is set.

Odd.  Ming, can you send me a patch for this?

thanks,

greg k-h

Re: linux-next: build warning after merge of the final tree (driver-core tree related)

[Ming Lei]

On Wed, Jun 19, 2013 at 10:38 PM, Greg KH <greg@kroah.com> wrote:
> On Wed, Jun 19, 2013 at 06:00:27PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the final tree, today's linux-next build (powerpc
>> allnoconfig among others) produced these warnings:
>>
>> drivers/base/firmware_class.c:1254:12: warning: 'cache_firmware' defined but not used [-Wunused-function]
>>  static int cache_firmware(const char *fw_name)
>>             ^
>> drivers/base/firmware_class.c:1281:12: warning: 'uncache_firmware' defined but not used [-Wunused-function]
>>  static int uncache_firmware(const char *fw_name)
>>             ^
>>
>> Revealed by commit 93232e46b209 ("firmware loader: don't export
>> cache_firmware and uncache_firmware") from the driver-core tree.  These
>> are only used if CONFIG_PM_SLEEP is set.
>
> Odd.  Ming, can you send me a patch for this?

No problem, will send you a patch together with the merge patch.

thanks,
--
Ming Lei