From: Ingo Molnar <mingo@elte.hu>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Randy Dunlap <randy.dunlap@oracle.com>,
Zeng Zhaoming <b32542@freescale.com>
Subject: Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
Date: Mon, 21 Mar 2011 17:11:02 +0100 [thread overview]
Message-ID: <20110321161102.GB23614@elte.hu> (raw)
In-Reply-To: <20110321155836.GE2570@opensource.wolfsonmicro.com>
* Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Mar 21, 2011 at 04:37:19PM +0100, Ingo Molnar wrote:
>
> > has been pushed upstream - although the build breakage was reported against
> > linux-next two weeks ago, with fix provided, in this lkml thread:
> >
> > [PATCH -next] soc: sgtl5000 uses regulator interfaces
>
> Zheng, you said you'd provide a better patch for this but I've heard
> nothing since? It's a trivial change you need to make...
>
> > Please do not push known-broken code upstream.
>
> That seems like an overreaction, it'll only show up in fairly unrealstic
> randconfigs [...]
I've seen it trigger with a likelyhood of about 20%, that's not unrealistic.
> [...] and can be trivially avoided by anyone who actually needs the driver -
> core things like all*config won't be affected, and right now it'll only come
> up at all if you enable SND_SOC_ALL_CODECS which is purely about build
> coverage.
>
> > Randy's fix below resolved the bug for me.
>
> As indicated that's not a good fix since the affected code is all runtime
> conditional already. [...]
Well, AFAICS Randy's patch correctly expresses current infrastructure
dependencies the driver has.
If it's undesirable to disable the driver in the (unlikely but possible)
SND_SOC_ALL_CODECS=y but !REGULATOR case, i.e. if it's desirable to have the
driver build more widely, then that can be enhanced further - but first please
get things to build.
> [...] It'd be more likely to impede than help the sort of build coverage
> tests where one would encounter it.
It's an invariant mostly - both Randy's and my testing will find breakages
regardless of how restrictively enabled this driver is.
Thanks,
Ingo
next prev parent reply other threads:[~2011-03-21 16:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 14:05 [GIT PULL] sound updates for 2.6.39-rc1 Takashi Iwai
2011-03-21 15:37 ` [build failure] " Ingo Molnar
2011-03-21 15:42 ` Randy Dunlap
2011-03-21 15:56 ` Takashi Iwai
2011-03-21 15:58 ` Mark Brown
2011-03-21 16:11 ` Ingo Molnar [this message]
2011-03-21 16:38 ` Mark Brown
2011-03-21 16:49 ` Ingo Molnar
2011-03-21 16:58 ` Mark Brown
2011-03-22 12:24 ` Mark Brown
2011-03-22 15:38 ` Randy Dunlap
2011-03-22 15:50 ` Mark Brown
2011-03-22 15:51 ` Takashi Iwai
2011-03-22 15:57 ` Randy Dunlap
2011-03-22 16:00 ` Ingo Molnar
2011-03-22 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321161102.GB23614@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=b32542@freescale.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=perex@perex.cz \
--cc=randy.dunlap@oracle.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).