From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Takashi Iwai <tiwai@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jaroslav Kysela <perex@perex.cz>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
Date: Mon, 21 Mar 2011 08:42:13 -0700 [thread overview]
Message-ID: <4D8771D5.40600@oracle.com> (raw)
In-Reply-To: <20110321153719.GA12325@elte.hu>
On 03/21/11 08:37, Ingo Molnar wrote:
>
> * Takashi Iwai <tiwai@suse.de> wrote:
>
>> Linus,
>>
>> please pull sound updates for v2.6.39-rc1 from:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git for-linus
>
> This build failure:
>
> sound/built-in.o: In function `ldo_regulator_remove':
> sgtl5000.c:(.text+0x82678): undefined reference to `regulator_unregister'
> sound/built-in.o: In function `ldo_regulator_is_enabled':
> sgtl5000.c:(.text+0x826c5): undefined reference to `rdev_get_drvdata'
> sound/built-in.o: In function `ldo_regulator_disable':
> sgtl5000.c:(.text+0x826ef): undefined reference to `rdev_get_drvdata'
> sound/built-in.o: In function `ldo_regulator_enable':
> sgtl5000.c:(.text+0x82756): undefined reference to `rdev_get_drvdata'
> sound/built-in.o: In function `ldo_regulator_get_voltage':
> sgtl5000.c:(.text+0x82815): undefined reference to `rdev_get_drvdata'
> sound/built-in.o: In function `sgtl5000_probe':
>
> has been pushed upstream - although the build breakage was reported against
> linux-next two weeks ago, with fix provided, in this lkml thread:
>
> [PATCH -next] soc: sgtl5000 uses regulator interfaces
>
> Please do not push known-broken code upstream.
>
> Randy's fix below resolved the bug for me.
The driver author did promise a different fix, but I haven't seen it.
> Thanks,
>
> Ingo
>
> --------------------->
> From 8c7c9a0622d5b1955628961ae193c12d948c1871 Mon Sep 17 00:00:00 2001
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Fri, 4 Mar 2011 17:33:57 -0800
> Subject: [PATCH] soc: Sgtl5000 uses regulator interfaces
>
> sgtl5000 uses regulator interfaces, so make selecting it depend
> on REGULATOR.
>
> sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister'
> sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata'
> sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: alsa-devel@alsa-project.org
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Zeng Zhaoming <zhaoming.zeng@freescale.com>
> LKML-Reference: <20110304173357.23d36116.randy.dunlap@oracle.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> sound/soc/codecs/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index d63c175..84818f5 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -36,7 +36,7 @@ config SND_SOC_ALL_CODECS
> select SND_SOC_MAX9850 if I2C
> select SND_SOC_MAX9877 if I2C
> select SND_SOC_PCM3008
> - select SND_SOC_SGTL5000 if I2C
> + select SND_SOC_SGTL5000 if I2C && REGULATOR
> select SND_SOC_SN95031 if INTEL_SCU_IPC
> select SND_SOC_SPDIF
> select SND_SOC_SSM2602 if I2C
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-03-21 15:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 14:05 [GIT PULL] sound updates for 2.6.39-rc1 Takashi Iwai
2011-03-21 15:37 ` [build failure] " Ingo Molnar
2011-03-21 15:42 ` Randy Dunlap [this message]
2011-03-21 15:56 ` Takashi Iwai
2011-03-21 15:58 ` Mark Brown
2011-03-21 16:11 ` Ingo Molnar
2011-03-21 16:38 ` Mark Brown
2011-03-21 16:49 ` Ingo Molnar
2011-03-21 16:58 ` Mark Brown
2011-03-22 12:24 ` Mark Brown
2011-03-22 15:38 ` Randy Dunlap
2011-03-22 15:50 ` Mark Brown
2011-03-22 15:51 ` Takashi Iwai
2011-03-22 15:57 ` Randy Dunlap
2011-03-22 16:00 ` Ingo Molnar
2011-03-22 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D8771D5.40600@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mingo@elte.hu \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).