From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Takashi Iwai <tiwai@suse.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Zeng Zhaoming <b32542@freescale.com>
Subject: Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
Date: Tue, 22 Mar 2011 16:41:28 +0000 [thread overview]
Message-ID: <20110322164128.GE22583@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110322160055.GA22128@elte.hu>
On Tue, Mar 22, 2011 at 05:00:55PM +0100, Ingo Molnar wrote:
> Btw., ldo_regulator_remove() returns an int, but none of the call sites make
> use of the return value. Also, ldo_regulator_remove() can only ever return 0.
Yup, the return value is a complete waste of time. But that's a
separate issue and a separate patch if someone wants to spend the time
on the driver.
> More importantly, it would be cleaner to wrap the !regulator case by making
> sgtl5000->ldo NULL (this should already be the case) and making
> regulator_unregister() available in the !REGULATOR case as well, as an inline
> stub.
Yeah, though I'm a bit ambivalent on stubbing only one half of the pair
it'd not be a real problem. And obviously there's a trivial text size
saving from compling out the unregistration code entirely. Separate
patch again, though.
prev parent reply other threads:[~2011-03-22 16:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 14:05 [GIT PULL] sound updates for 2.6.39-rc1 Takashi Iwai
2011-03-21 15:37 ` [build failure] " Ingo Molnar
2011-03-21 15:42 ` Randy Dunlap
2011-03-21 15:56 ` Takashi Iwai
2011-03-21 15:58 ` Mark Brown
2011-03-21 16:11 ` Ingo Molnar
2011-03-21 16:38 ` Mark Brown
2011-03-21 16:49 ` Ingo Molnar
2011-03-21 16:58 ` Mark Brown
2011-03-22 12:24 ` Mark Brown
2011-03-22 15:38 ` Randy Dunlap
2011-03-22 15:50 ` Mark Brown
2011-03-22 15:51 ` Takashi Iwai
2011-03-22 15:57 ` Randy Dunlap
2011-03-22 16:00 ` Ingo Molnar
2011-03-22 16:41 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322164128.GE22583@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=b32542@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=mingo@elte.hu \
--cc=perex@perex.cz \
--cc=randy.dunlap@oracle.com \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).