[PATCH] Fix loopback devices to emit uevent on auto release

[PATCH] Fix loopback devices to emit uevent on auto release

[Phillip Susi]

[-- Attachment #1.1: Type: text/plain, Size: 0 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: fixloop.patch --]
[-- Type: text/x-patch; name="fixloop.patch", Size: 839 bytes --]

commit 4d5498b2b400ee4781b25fa9fa219eadf11c1ef5
Author: Phillip Susi <psusi@cfl.rr.com>
Date:   Mon Jun 27 18:55:00 2011 -0400

    Fixed loopback device to emit uevent on auto release
    
    The loopback driver failed to emit the change uevent
    when auto releasing the device.  Fixed lo_release()
    to pass the bdev to loop_clr_fd() so it can emit
    the event.

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index dbf31ec..ba915ce 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1522,7 +1522,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
 		 * In autoclear mode, stop the loop thread
 		 * and remove configuration after last close.
 		 */
-		err = loop_clr_fd(lo, NULL);
+		err = loop_clr_fd(lo, lo->lo_device);
 		if (!err)
 			goto out_unlocked;
 	} else {

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH] Fix loopback devices to emit uevent on auto release

[Andrew Morton]

On Mon, 27 Jun 2011 19:30:49 -0400
Phillip Susi <psusi@cfl.rr.com> wrote:

> commit 4d5498b2b400ee4781b25fa9fa219eadf11c1ef5
> Author: Phillip Susi <psusi@cfl.rr.com>
> Date:   Mon Jun 27 18:55:00 2011 -0400
> 
>     Fixed loopback device to emit uevent on auto release
>     
>     The loopback driver failed to emit the change uevent
>     when auto releasing the device.  Fixed lo_release()
>     to pass the bdev to loop_clr_fd() so it can emit
>     the event.
> 
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index dbf31ec..ba915ce 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1522,7 +1522,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
>  		 * In autoclear mode, stop the loop thread
>  		 * and remove configuration after last close.
>  		 */
> -		err = loop_clr_fd(lo, NULL);
> +		err = loop_clr_fd(lo, lo->lo_device);
>  		if (!err)
>  			goto out_unlocked;
>  	} else {

The patch is missing your Signed-off-by:.  Please review
Documentation/SubmittingPatches section 12 to see what this means. 
Then, if agreeable, please send us that Signed-off-by:, thanks.

Re: [PATCH] Fix loopback devices to emit uevent on auto release

[Phillip Susi]

On 7/6/2011 6:45 PM, Andrew Morton wrote:
> The patch is missing your Signed-off-by:.  Please review
> Documentation/SubmittingPatches section 12 to see what this means.
> Then, if agreeable, please send us that Signed-off-by:, thanks.

Oops, yes of course.  Please add it, or do you need me to resubmit the 
whole patch?

Re: [PATCH] Fix loopback devices to emit uevent on auto release

[Andrew Morton]

On Thu, 07 Jul 2011 14:56:57 -0400
Phillip Susi <psusi@cfl.rr.com> wrote:

> On 7/6/2011 6:45 PM, Andrew Morton wrote:
> > The patch is missing your Signed-off-by:.  Please review
> > Documentation/SubmittingPatches section 12 to see what this means.
> > Then, if agreeable, please send us that Signed-off-by:, thanks.
> 
> Oops, yes of course.  Please add it, 

I added it it my copy, thanks.

> or do you need me to resubmit the whole patch?

That's OK, I'll scoot it along to Jens later on.