From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dong Aisheng-B29396 <B29396@freescale.com>,
Liam Girdwood <lrg@ti.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap
Date: Tue, 24 Jan 2012 20:22:03 +0000 [thread overview]
Message-ID: <20120124202203.GD1135@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1201241828480.1779@localhost6.localdomain6>
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
On Tue, Jan 24, 2012 at 06:29:13PM +0100, Julia Lawall wrote:
> if (IS_ERR(saif->clk)) {
> - ret = PTR_ERR(saif->clk);
> dev_err(&pdev->dev, "Cannot get the clock: %d\n",
> ret);
> - goto failed_clk;
> + return PTR_ERR(saif->clk);
Looks like the transformation is overly enthusiastic here - the
assignment to ret is removed but ret is used in the log message.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-24 20:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 9:55 [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Julia Lawall
2012-01-12 10:45 ` Felipe Balbi
2012-01-13 6:25 ` Dong Aisheng-B29396
2012-01-13 6:32 ` Julia Lawall
2012-01-24 17:29 ` Julia Lawall
2012-01-24 20:22 ` Mark Brown [this message]
2012-01-24 20:36 ` Julia Lawall
2012-01-24 20:45 ` Julia Lawall
2012-01-26 10:53 ` Mark Brown
2012-01-26 11:24 ` Julia Lawall
2012-01-26 11:27 ` Mark Brown
2012-01-26 11:05 ` [alsa-devel] " Wolfram Sang
2012-01-26 11:21 ` Julia Lawall
2012-01-26 11:22 ` Mark Brown
2012-01-26 13:40 ` Julia Lawall
2012-01-26 13:51 ` Wolfram Sang
2012-01-26 14:07 ` Julia Lawall
2012-01-28 8:26 ` Wolfram Sang
2012-01-28 8:51 ` Julia Lawall
2012-02-04 18:25 ` devm_request_and_ioremap Julia Lawall
2012-02-04 18:46 ` devm_request_and_ioremap Mark Brown
2012-02-04 22:08 ` devm_request_and_ioremap Julia Lawall
2012-02-06 16:21 ` devm_request_and_ioremap Mark Brown
2012-01-28 7:03 ` [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Julia Lawall
2012-01-28 8:29 ` Wolfram Sang
2012-02-06 16:20 ` Mark Brown
2012-02-08 10:18 ` Dong Aisheng
2012-02-08 12:39 ` Julia Lawall
2012-01-26 11:25 ` Wolfram Sang
2012-01-26 11:28 ` Julia Lawall
2012-01-26 11:57 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124202203.GD1135@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=B29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).