From: Dong Aisheng-B29396 <B29396@freescale.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>, Liam Girdwood <lrg@ti.com>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap
Date: Fri, 13 Jan 2012 06:25:26 +0000 [thread overview]
Message-ID: <7FE21149F4667147B645348EC605788508FBDB@039-SN2MPN1-013.039d.mgd.msft.net> (raw)
In-Reply-To: <1326362117-29371-1-git-send-email-Julia.Lawall@lip6.fr>
> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Julia Lawall
> Sent: Thursday, January 12, 2012 5:55 PM
> To: Liam Girdwood
> Cc: kernel-janitors@vger.kernel.org; Mark Brown; Jaroslav Kysela; Takashi Iwai;
> alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap
>
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Add missing iounmap in error handling code, in a case where the function already
> preforms iounmap on some other execution path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e;
> statement S,S1;
> int ret;
> @@
> e = \(ioremap\|ioremap_nocache\)(...)
> ... when != iounmap(e)
> if (<+...e...+>) S
> ... when any
> when != iounmap(e)
> *if (...)
> { ... when != iounmap(e)
> return ...; }
> ... when any
> iounmap(e);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> sound/soc/mxs/mxs-saif.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c index
> 049e543..5ee0adb 100644
> --- a/sound/soc/mxs/mxs-saif.c
> +++ b/sound/soc/mxs/mxs-saif.c
> @@ -680,7 +680,7 @@ static int mxs_saif_probe(struct platform_device *pdev)
> ret = -ENODEV;
> dev_err(&pdev->dev, "failed to get dma resource: %d\n",
> ret);
> - goto failed_ioremap;
> + goto failed_get_resource;
> }
> saif->dma_param.chan_num = dmares->start;
>
> @@ -739,6 +739,7 @@ failed_register:
> failed_get_irq2:
> free_irq(saif->irq, saif);
> failed_get_irq1:
> +failed_get_resource:
There's already a 'failed_get_resource' there, wouldn't your change break
The original code?
BTW, I guess a better way is that you can submit a patch to change the driver
To use devm_alloc_* and it's friend routines, then we do not need to fix
Such things any more.
Regards
Dong Aisheng
> iounmap(saif->base);
> failed_ioremap:
> release_mem_region(iores->start, resource_size(iores));
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-01-13 6:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 9:55 [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Julia Lawall
2012-01-12 10:45 ` Felipe Balbi
2012-01-13 6:25 ` Dong Aisheng-B29396 [this message]
2012-01-13 6:32 ` Julia Lawall
2012-01-24 17:29 ` Julia Lawall
2012-01-24 20:22 ` Mark Brown
2012-01-24 20:36 ` Julia Lawall
2012-01-24 20:45 ` Julia Lawall
2012-01-26 10:53 ` Mark Brown
2012-01-26 11:24 ` Julia Lawall
2012-01-26 11:27 ` Mark Brown
2012-01-26 11:05 ` [alsa-devel] " Wolfram Sang
2012-01-26 11:21 ` Julia Lawall
2012-01-26 11:22 ` Mark Brown
2012-01-26 13:40 ` Julia Lawall
2012-01-26 13:51 ` Wolfram Sang
2012-01-26 14:07 ` Julia Lawall
2012-01-28 8:26 ` Wolfram Sang
2012-01-28 8:51 ` Julia Lawall
2012-02-04 18:25 ` devm_request_and_ioremap Julia Lawall
2012-02-04 18:46 ` devm_request_and_ioremap Mark Brown
2012-02-04 22:08 ` devm_request_and_ioremap Julia Lawall
2012-02-06 16:21 ` devm_request_and_ioremap Mark Brown
2012-01-28 7:03 ` [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Julia Lawall
2012-01-28 8:29 ` Wolfram Sang
2012-02-06 16:20 ` Mark Brown
2012-02-08 10:18 ` Dong Aisheng
2012-02-08 12:39 ` Julia Lawall
2012-01-26 11:25 ` Wolfram Sang
2012-01-26 11:28 ` Julia Lawall
2012-01-26 11:57 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7FE21149F4667147B645348EC605788508FBDB@039-SN2MPN1-013.039d.mgd.msft.net \
--to=b29396@freescale.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).