From: Julia Lawall <julia.lawall@lip6.fr>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dong Aisheng-B29396 <B29396@freescale.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap
Date: Thu, 26 Jan 2012 12:21:35 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.02.1201261220460.1851@localhost6.localdomain6> (raw)
In-Reply-To: <20120126110506.GB2611@pengutronix.de>
On Thu, 26 Jan 2012, Wolfram Sang wrote:
>> @@ -666,18 +666,19 @@ static int mxs_saif_probe(struct platform_device *pdev)
>> goto failed_get_resource;
>> }
>>
>> - if (!request_mem_region(iores->start, resource_size(iores),
>> - "mxs-saif")) {
>> + if (!devm_request_mem_region(&pdev->dev, iores->start,
>> + resource_size(iores), "mxs-saif")) {
>> dev_err(&pdev->dev, "request_mem_region failed\n");
>> ret = -EBUSY;
>> goto failed_get_resource;
>> }
>>
>> - saif->base = ioremap(iores->start, resource_size(iores));
>> + saif->base = devm_ioremap(&pdev->dev, iores->start,
>> + resource_size(iores));
>
> devm_request_and_ioremap() to save even more code?
I didn't do that because apparently it is not yet in a release? I have
another for introducing those...
julia
next prev parent reply other threads:[~2012-01-26 11:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 9:55 [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Julia Lawall
2012-01-12 10:45 ` Felipe Balbi
2012-01-13 6:25 ` Dong Aisheng-B29396
2012-01-13 6:32 ` Julia Lawall
2012-01-24 17:29 ` Julia Lawall
2012-01-24 20:22 ` Mark Brown
2012-01-24 20:36 ` Julia Lawall
2012-01-24 20:45 ` Julia Lawall
2012-01-26 10:53 ` Mark Brown
2012-01-26 11:24 ` Julia Lawall
2012-01-26 11:27 ` Mark Brown
2012-01-26 11:05 ` [alsa-devel] " Wolfram Sang
2012-01-26 11:21 ` Julia Lawall [this message]
2012-01-26 11:22 ` Mark Brown
2012-01-26 13:40 ` Julia Lawall
2012-01-26 13:51 ` Wolfram Sang
2012-01-26 14:07 ` Julia Lawall
2012-01-28 8:26 ` Wolfram Sang
2012-01-28 8:51 ` Julia Lawall
2012-02-04 18:25 ` devm_request_and_ioremap Julia Lawall
2012-02-04 18:46 ` devm_request_and_ioremap Mark Brown
2012-02-04 22:08 ` devm_request_and_ioremap Julia Lawall
2012-02-06 16:21 ` devm_request_and_ioremap Mark Brown
2012-01-28 7:03 ` [alsa-devel] [PATCH 1/15] sound/soc/mxs/mxs-saif.c: add missing iounmap Julia Lawall
2012-01-28 8:29 ` Wolfram Sang
2012-02-06 16:20 ` Mark Brown
2012-02-08 10:18 ` Dong Aisheng
2012-02-08 12:39 ` Julia Lawall
2012-01-26 11:25 ` Wolfram Sang
2012-01-26 11:28 ` Julia Lawall
2012-01-26 11:57 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1201261220460.1851@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=B29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).