linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Shaohua Li <shaohua.li@intel.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>, Jens Axboe <axboe@kernel.dk>,
	Herbert Poetzl <herbert@13thfloor.at>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Wu Fengguang <wfg@linux.intel.com>
Subject: Re: [PATCH] fix readahead pipeline break caused by block plug
Date: Wed, 1 Feb 2012 04:18:07 -0500	[thread overview]
Message-ID: <20120201091807.GA7451@infradead.org> (raw)
In-Reply-To: <20120201033653.GA12092@redhat.com>

On Tue, Jan 31, 2012 at 10:36:53PM -0500, Vivek Goyal wrote:
> I still see that IO is being submitted one page at a time. The only
> real difference seems to be that queue unplug happening at random times
> and many a times we are submitting much smaller requests (40 sectors, 48
> sectors etc).

This is expected given that the block device node uses
block_read_full_page, and not mpage_readpage(s).

  parent reply	other threads:[~2012-02-01  9:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-31  7:59 [PATCH] fix readahead pipeline break caused by block plug Shaohua Li
2012-01-31  8:36 ` Christoph Hellwig
2012-01-31  8:48 ` Eric Dumazet
2012-01-31  8:50   ` Herbert Poetzl
2012-01-31  8:53   ` Shaohua Li
2012-01-31  9:17     ` Eric Dumazet
2012-01-31 10:20 ` Wu Fengguang
2012-01-31 10:34 ` Wu Fengguang
2012-01-31 10:46   ` Christoph Hellwig
2012-01-31 10:57     ` Wu Fengguang
2012-01-31 11:34       ` Christoph Hellwig
2012-01-31 11:42         ` Wu Fengguang
2012-01-31 11:57           ` Christoph Hellwig
2012-01-31 12:20             ` Wu Fengguang
2012-02-01  2:25   ` Shaohua Li
2012-01-31 14:47 ` Vivek Goyal
2012-01-31 20:23   ` Vivek Goyal
2012-01-31 22:03 ` Vivek Goyal
2012-01-31 22:13   ` Andrew Morton
2012-01-31 22:22     ` Vivek Goyal
2012-02-01  3:36       ` Vivek Goyal
2012-02-01  7:10         ` Wu Fengguang
2012-02-01 16:01           ` Vivek Goyal
2012-02-01  9:18         ` Christoph Hellwig [this message]
2012-02-01 20:10           ` Vivek Goyal
2012-02-01 20:13             ` Jeff Moyer
2012-02-01 20:22             ` Andrew Morton
2012-02-01  7:02   ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120201091807.GA7451@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@13thfloor.at \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shaohua.li@intel.com \
    --cc=vgoyal@redhat.com \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).