linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: Bryan Freed <bfreed@chromium.org>,
	John Stultz <john.stultz@linaro.org>,
	linux-kernel@vger.kernel.org, keescook@chromium.org,
	sboyd@codeaurora.org, gregkh@linuxfoundation.org,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.
Date: Sat, 8 Sep 2012 01:06:09 -0700	[thread overview]
Message-ID: <20120908080607.GA22071@lizard> (raw)
In-Reply-To: <504AF27C.9090601@gmail.com>

On Sat, Sep 08, 2012 at 09:23:40AM +0200, Marco Stornelli wrote: [...]
> >>+	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> >>+   if (pdata == NULL)
> >
> >I wonder why people prefer to not write !pdata, which is more natural
> >when reading the code.. :-)
> 
> I think it's the same for sizeof, it's much more readable
> sizeof(struct ramoops_platform_data).

Well, sizeof(struct...) is against Linux coding style.  And there are
good reasons for this rule, it's all in the CodingStyle file. Thus,
it's not about personal preferences. But speaking of personal
preferences, I don't find sizeof(struct...) more readable. :-)

Thanks!
Anton.

  reply	other threads:[~2012-09-08  8:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 18:29 [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree Bryan Freed
2012-09-08  5:29 ` Anton Vorontsov
2012-09-08  7:23   ` Marco Stornelli
2012-09-08  8:06     ` Anton Vorontsov [this message]
2012-09-08  8:27       ` Marco Stornelli
2012-09-17  6:23   ` Anton Vorontsov
2013-04-05  2:03     ` Rob Herring
2013-04-07 17:43       ` Anton Vorontsov
2013-04-08 19:54         ` Bryan Freed
2013-04-08 22:43           ` Rob Herring
2013-04-14 14:24           ` Anton Vorontsov
2016-01-06  1:04             ` Kees Cook
2016-01-06  1:06               ` Kees Cook
2016-01-06  1:42                 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120908080607.GA22071@lizard \
    --to=cbouatmailru@gmail.com \
    --cc=bfreed@chromium.org \
    --cc=ccross@android.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.stornelli@gmail.com \
    --cc=sboyd@codeaurora.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).