linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Anton Vorontsov <anton@enomsg.org>
Cc: Bryan Freed <bfreed@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Rob Herring <robherring2@gmail.com>,
	Tony Luck <tony.luck@intel.com>,
	Marco Stornelli <marco.stornelli@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	John Stultz <john.stultz@linaro.org>,
	Colin Cross <ccross@android.com>,
	Olof Johansson <olofj@google.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.
Date: Tue, 5 Jan 2016 17:06:17 -0800	[thread overview]
Message-ID: <CAGXu5jKpfN5VycKgGJhxC1DuRkC8D1D2putTGz4MaB9MLpaiNg@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jJVmz+tZWEAqEezPDEA7i4Tcp7OfZtux9rs0bpQCCxDfw@mail.gmail.com>

[fixing devicetree mailing list]

On Tue, Jan 5, 2016 at 5:04 PM, Kees Cook <keescook@chromium.org> wrote:
> [thread necromancy, if you don't have the thread locally, it's here:
> https://patchwork.kernel.org/patch/1426261/]
>
> We still need to solve this, and John pinged me about it today. Where
> does this stand?
>
> -Kees
>
>
> On Sun, Apr 14, 2013 at 7:24 AM, Anton Vorontsov <anton@enomsg.org> wrote:
>> On Mon, Apr 08, 2013 at 12:54:01PM -0700, Bryan Freed wrote:
>> [...]
>>> And as a more general question, why should we try not to put
>>> configuration in the device tree?  It seems like a great (and
>>> portable) place to put this stuff.
>>> It certainly seems better to have it there than hardwired in the
>>> kernel or tacked onto the kernel command line.
>>
>> But then we have two in-kernel APIs to pass kernel parameters? So we'll
>> have to maintain two ways of passing the options for each driver. That is
>> hardly a good solution.
>>
>> If you would like to see a convenient way to pass kernel/module options
>> via the device tree, I would suggest implementing something like this:
>>
>> chosen {
>>         kernel-options {
>>                 linux,pstore.record-size = 123;
>>                 linux,foo = "bar";
>>         };
>> };
>>
>> And then let the kernel translate all these to module_param_*().
>>
>> I am still not sure about placing the options along with devices layout,
>> but if we go this route, then that is also viable:
>>
>> pstore-node {
>>         linux,pstore.record-size = 123;
>> };
>>
>> And translate "linux,*" this to module_param_*().
>>
>> How does that sound?
>>
>> Thanks,
>> Anton
>
>
>
> --
> Kees Cook
> Chrome OS & Brillo Security



-- 
Kees Cook
Chrome OS & Brillo Security

  reply	other threads:[~2016-01-06  1:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 18:29 [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree Bryan Freed
2012-09-08  5:29 ` Anton Vorontsov
2012-09-08  7:23   ` Marco Stornelli
2012-09-08  8:06     ` Anton Vorontsov
2012-09-08  8:27       ` Marco Stornelli
2012-09-17  6:23   ` Anton Vorontsov
2013-04-05  2:03     ` Rob Herring
2013-04-07 17:43       ` Anton Vorontsov
2013-04-08 19:54         ` Bryan Freed
2013-04-08 22:43           ` Rob Herring
2013-04-14 14:24           ` Anton Vorontsov
2016-01-06  1:04             ` Kees Cook
2016-01-06  1:06               ` Kees Cook [this message]
2016-01-06  1:42                 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5jKpfN5VycKgGJhxC1DuRkC8D1D2putTGz4MaB9MLpaiNg@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=anton@enomsg.org \
    --cc=arnd@arndb.de \
    --cc=bfreed@chromium.org \
    --cc=ccross@android.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.stornelli@gmail.com \
    --cc=olofj@google.com \
    --cc=robherring2@gmail.com \
    --cc=sboyd@codeaurora.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).