[PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Aaron Lu]

commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
devices which have _PRx, if a device does not have _PRx, a warning
message will be printed.

This commit is for ZPODD on Intel's platform, on AMD's platform, there
is no _PRx to support ZPODD, we use _PSx.

So instead of printing a useless warning message on AMD's platform,
changing the print level to DEBUG to suppress this message.

Reported-by: Borislav Petkov <borislav.petkov@amd.com>
Cc: <stable@vger.kernel.org> 3.5+
Signed-off-by: Aaron Lu <aaron.lu@amd.com>
---
 drivers/acpi/power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index 215ecd0..e5e01d9 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
 	return ret;
 
 no_power_resource:
-	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
+	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
 	return -ENODEV;
 }
 EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
-- 
1.7.11.3

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Borislav Petkov]

On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> devices which have _PRx, if a device does not have _PRx, a warning
> message will be printed.
> 
> This commit is for ZPODD on Intel's platform, on AMD's platform, there
> is no _PRx to support ZPODD, we use _PSx.
> 
> So instead of printing a useless warning message on AMD's platform,
> changing the print level to DEBUG to suppress this message.
> 
> Reported-by: Borislav Petkov <borislav.petkov@amd.com>
> Cc: <stable@vger.kernel.org> 3.5+
> Signed-off-by: Aaron Lu <aaron.lu@amd.com>

Ping?

Can we get this applied pls - I still see it on -rc3.

Thanks.

> ---
>  drivers/acpi/power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 215ecd0..e5e01d9 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
>  	return ret;
>  
>  no_power_resource:
> -	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
>  	return -ENODEV;
>  }
>  EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
> -- 
> 1.7.11.3
> 

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Joe Perches]

On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote:
> On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> > devices which have _PRx, if a device does not have _PRx, a warning
> > message will be printed.
> > 
> > This commit is for ZPODD on Intel's platform, on AMD's platform, there
> > is no _PRx to support ZPODD, we use _PSx.
> > 
> > So instead of printing a useless warning message on AMD's platform,
> > changing the print level to DEBUG to suppress this message.
[]
> > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
[]
> > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> >  	return ret;
> >  
> >  no_power_resource:
> > -	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> > +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");

Perhaps add something like:
	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
		printk(etc...)
instead?

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Aaron Lu]

On Fri, Aug 24, 2012 at 03:36:21PM -0700, Joe Perches wrote:
> On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote:
> > On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> > > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> > > devices which have _PRx, if a device does not have _PRx, a warning
> > > message will be printed.
> > > 
> > > This commit is for ZPODD on Intel's platform, on AMD's platform, there
> > > is no _PRx to support ZPODD, we use _PSx.
> > > 
> > > So instead of printing a useless warning message on AMD's platform,
> > > changing the print level to DEBUG to suppress this message.
> []
> > > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> []
> > > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> > >  	return ret;
> > >  
> > >  no_power_resource:
> > > -	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> > > +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> 
> Perhaps add something like:
> 	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
> 		printk(etc...)
> instead?

Sorry for not describing this problem clear, this would also occur on
Intel platforms as long as that device we are calling this register
function on does not have any power resource attached to it.

So the problem is actually, does the acpi_power_resource_register_device
function expect such input devices that they do not have any power
resource attached? If yes, then it shouldn't complain with a warning
message; if no, then we should probably check these conditions before
making such a call.

Looking at the function itself, I think it expects such devices so a
warning message here is not appropriate.

-Aaron

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Borislav Petkov]

On Wed, Aug 29, 2012 at 10:01:36AM +0800, Aaron Lu wrote:
> On Fri, Aug 24, 2012 at 03:36:21PM -0700, Joe Perches wrote:
> > On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote:
> > > On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> > > > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> > > > devices which have _PRx, if a device does not have _PRx, a warning
> > > > message will be printed.
> > > > 
> > > > This commit is for ZPODD on Intel's platform, on AMD's platform, there
> > > > is no _PRx to support ZPODD, we use _PSx.
> > > > 
> > > > So instead of printing a useless warning message on AMD's platform,
> > > > changing the print level to DEBUG to suppress this message.
> > []
> > > > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> > []
> > > > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> > > >  	return ret;
> > > >  
> > > >  no_power_resource:
> > > > -	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> > > > +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> > 
> > Perhaps add something like:
> > 	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
> > 		printk(etc...)
> > instead?
> 
> Sorry for not describing this problem clear, this would also occur on
> Intel platforms as long as that device we are calling this register
> function on does not have any power resource attached to it.
> 
> So the problem is actually, does the acpi_power_resource_register_device
> function expect such input devices that they do not have any power
> resource attached? If yes, then it shouldn't complain with a warning
> message; if no, then we should probably check these conditions before
> making such a call.
> 
> Looking at the function itself, I think it expects such devices so a
> warning message here is not appropriate.

This is still present in -rc5.

Linus, this message obviously warns for no good reason. Can you please
pick up the patch at http://marc.info/?l=linux-kernel&m=134456468110431
since ACPI people don't seem to react here.

Btw, Aaron, the stable tag should be covering 3.4 too because the patch
that added the message actually is 0090def6c37c8:

$ git tag --contains 0090def6c37c8
v3.4
v3.4-rc1
v3.4-rc2
v3.4-rc3
v3.4-rc4
v3.4-rc5
v3.4-rc6
v3.4-rc7
v3.4.1
v3.4.2
v3.4.3
v3.4.4
v3.4.5
v3.4.6
v3.4.7
v3.5
v3.5-rc1
v3.5-rc2
v3.5-rc3
v3.5-rc4
v3.5-rc5
v3.5-rc6
v3.5-rc7
v3.6-rc1
v3.6-rc2
v3.6-rc3
v3.6-rc4
v3.6-rc5

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Rafael J. Wysocki]

On Thursday, September 13, 2012, Borislav Petkov wrote:
> On Wed, Aug 29, 2012 at 10:01:36AM +0800, Aaron Lu wrote:
> > On Fri, Aug 24, 2012 at 03:36:21PM -0700, Joe Perches wrote:
> > > On Thu, 2012-08-23 at 15:26 +0200, Borislav Petkov wrote:
> > > > On Fri, Aug 10, 2012 at 10:05:53AM +0800, Aaron Lu wrote:
> > > > > commit a606dac368eed5696fb38e16b1394f1d049c09e9 adds support to link
> > > > > devices which have _PRx, if a device does not have _PRx, a warning
> > > > > message will be printed.
> > > > > 
> > > > > This commit is for ZPODD on Intel's platform, on AMD's platform, there
> > > > > is no _PRx to support ZPODD, we use _PSx.
> > > > > 
> > > > > So instead of printing a useless warning message on AMD's platform,
> > > > > changing the print level to DEBUG to suppress this message.
> > > []
> > > > > diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> > > []
> > > > > @@ -460,7 +460,7 @@ int acpi_power_resource_register_device(struct device *dev, acpi_handle handle)
> > > > >  	return ret;
> > > > >  
> > > > >  no_power_resource:
> > > > > -	printk(KERN_WARNING PREFIX "Invalid Power Resource to register!");
> > > > > +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> > > 
> > > Perhaps add something like:
> > > 	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
> > > 		printk(etc...)
> > > instead?
> > 
> > Sorry for not describing this problem clear, this would also occur on
> > Intel platforms as long as that device we are calling this register
> > function on does not have any power resource attached to it.
> > 
> > So the problem is actually, does the acpi_power_resource_register_device
> > function expect such input devices that they do not have any power
> > resource attached? If yes, then it shouldn't complain with a warning
> > message; if no, then we should probably check these conditions before
> > making such a call.
> > 
> > Looking at the function itself, I think it expects such devices so a
> > warning message here is not appropriate.
> 
> This is still present in -rc5.
> 
> Linus, this message obviously warns for no good reason. Can you please
> pick up the patch at http://marc.info/?l=linux-kernel&m=134456468110431
> since ACPI people don't seem to react here.

I'll take it.  There are two more ACPI PM patches that would be good to have
in v3.6 IMO.

Thanks,
Rafael

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Borislav Petkov]

On Thu, Sep 13, 2012 at 11:17:32PM +0200, Rafael J. Wysocki wrote:
> I'll take it. There are two more ACPI PM patches that would be good to
> have in v3.6 IMO.

Ok, cool. Can you pls adjust the stable tag to include 3.4 too?

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551

Re: [PATCH] ACPI: power: Use KERN_DEBUG when no power resources are found

[Rafael J. Wysocki]

On Friday, September 14, 2012, Borislav Petkov wrote:
> On Thu, Sep 13, 2012 at 11:17:32PM +0200, Rafael J. Wysocki wrote:
> > I'll take it. There are two more ACPI PM patches that would be good to
> > have in v3.6 IMO.
> 
> Ok, cool. Can you pls adjust the stable tag to include 3.4 too?

I'll just use <stable@vger.kernel.org> I think.

Thanks,
Rafael