From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tejun Heo <tj@kernel.org>, Neil Horman <nhorman@tuxdriver.com>,
"Serge E. Hallyn" <serue@us.ibm.com>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.cz>,
Paul Mackerras <paulus@samba.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Johannes Weiner <hannes@cmpxchg.org>, Thomas Graf <tgraf@suug.ch>,
cgroups@vger.kernel.org, Paul Turner <pjt@google.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [RFC] cgroup TODOs
Date: Fri, 14 Sep 2012 13:54:27 +0100 [thread overview]
Message-ID: <20120914125427.GW6819@redhat.com> (raw)
In-Reply-To: <1347621302.7172.22.camel@twins>
On Fri, Sep 14, 2012 at 01:15:02PM +0200, Peter Zijlstra wrote:
> On Thu, 2012-09-13 at 13:58 -0700, Tejun Heo wrote:
> > The cpu ones handle nesting correctly - parent's accounting includes
> > children's, parent's configuration affects children's unless
> > explicitly overridden, and children's limits nest inside parent's.
>
> The implementation has some issues with fixed point math limitations on
> deep hierarchies/large cpu count, but yes.
>
> Doing soft-float/bignum just isn't going to be popular I guess ;-)
>
> People also don't seem to understand that each extra cgroup carries a
> cost and that nested cgroups are more expensive still, even if the
> intermediate levels are mostly empty (libvirt is a good example of how
> not to do things).
>
> Anyway, I guess what I'm saying is that we need to work on the awareness
> of cost associated with all this cgroup nonsense, people seem to think
> its all good and free -- or not think at all, which, while depressing,
> seem the more likely option.
In defense of what libvirt is doing, I'll point out that the kernel
docs on cgroups make little to no mention of these performance / cost
implications, and the examples of usage given arguably encourage use
of deep hierarchies.
Given what we've now learnt about the kernel's lack of scalability
wrt cgroup hierarchies, we'll be changing the way libvirt deals with
cgroups, to flatten it out to only use 1 level by default. If the
kernel docs had clearly expressed the limitations & made better
recommendations on app usage we would never have picked the approach
we originally chose.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2012-09-14 12:55 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 20:58 [RFC] cgroup TODOs Tejun Heo
2012-09-14 9:04 ` Mike Galbraith
2012-09-14 17:17 ` Tejun Heo
2012-09-14 9:10 ` Daniel P. Berrange
2012-09-14 13:58 ` Vivek Goyal
2012-09-14 19:29 ` Tejun Heo
2012-09-14 21:51 ` Kay Sievers
[not found] ` <5052E7DF.7040000@parallels.com>
2012-09-14 9:12 ` Li Zefan
2012-09-14 11:22 ` Peter Zijlstra
2012-09-14 17:59 ` Tejun Heo
2012-09-14 18:23 ` Peter Zijlstra
2012-09-14 18:33 ` Tejun Heo
2012-09-14 17:43 ` Tejun Heo
2012-09-17 8:50 ` Glauber Costa
2012-09-17 17:21 ` Tejun Heo
2012-09-14 11:15 ` Peter Zijlstra
2012-09-14 12:54 ` Daniel P. Berrange [this message]
2012-09-14 17:53 ` Tejun Heo
2012-09-14 14:25 ` Vivek Goyal
2012-09-14 14:53 ` Peter Zijlstra
2012-09-14 15:14 ` Vivek Goyal
2012-09-14 21:57 ` Tejun Heo
2012-09-17 15:27 ` Vivek Goyal
2012-09-18 18:08 ` Vivek Goyal
2012-09-14 21:39 ` Tejun Heo
2012-09-17 15:05 ` Vivek Goyal
2012-09-17 16:40 ` Tejun Heo
2012-09-14 15:03 ` Michal Hocko
2012-09-19 14:02 ` Michal Hocko
2012-09-19 14:03 ` [PATCH 2.6.32] memcg: warn on deeper hierarchies with use_hierarchy==0 Michal Hocko
2012-09-19 19:38 ` David Rientjes
2012-09-20 13:24 ` Michal Hocko
2012-09-20 22:33 ` David Rientjes
2012-09-21 7:16 ` Michal Hocko
2012-09-19 14:03 ` [PATCH 3.0] " Michal Hocko
2012-09-19 14:05 ` [PATCH 3.2+] " Michal Hocko
2012-09-14 18:07 ` [RFC] cgroup TODOs Vivek Goyal
2012-09-14 18:53 ` Tejun Heo
2012-09-14 19:28 ` Vivek Goyal
2012-09-14 19:44 ` Tejun Heo
2012-09-14 19:49 ` Tejun Heo
2012-09-14 20:39 ` Tejun Heo
2012-09-17 8:40 ` Glauber Costa
2012-09-17 17:30 ` Tejun Heo
2012-09-17 14:37 ` Vivek Goyal
2012-09-14 18:36 ` Aristeu Rozanski
2012-09-14 18:54 ` Tejun Heo
2012-09-15 2:20 ` Serge E. Hallyn
2012-09-15 9:27 ` Controlling devices and device namespaces Eric W. Biederman
2012-09-15 22:05 ` Serge E. Hallyn
2012-09-16 0:24 ` Eric W. Biederman
2012-09-16 3:31 ` Serge E. Hallyn
2012-09-16 11:21 ` Alan Cox
2012-09-16 11:56 ` Eric W. Biederman
2012-09-16 12:17 ` Eric W. Biederman
2012-09-16 13:32 ` Serge Hallyn
2012-09-16 14:23 ` Eric W. Biederman
2012-09-16 16:13 ` Alan Cox
2012-09-16 17:49 ` Eric W. Biederman
2012-09-16 16:15 ` Serge Hallyn
2012-09-16 16:53 ` Eric W. Biederman
2012-09-16 8:19 ` [RFC] cgroup TODOs James Bottomley
2012-09-16 14:41 ` Eric W. Biederman
2012-09-17 13:21 ` Aristeu Rozanski
2012-09-14 22:03 ` Dhaval Giani
2012-09-14 22:06 ` Tejun Heo
2012-09-20 1:33 ` Andy Lutomirski
2012-09-20 18:26 ` Tejun Heo
2012-09-20 18:39 ` Andy Lutomirski
2012-09-21 21:40 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120914125427.GW6819@redhat.com \
--to=berrange@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mingo@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=serue@us.ibm.com \
--cc=tgraf@suug.ch \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).