From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Tejun Heo <tj@kernel.org>,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
Glauber Costa <glommer@parallels.com>,
Peter Zijlstra <peterz@infradead.org>,
Paul Turner <pjt@google.com>,
Johannes Weiner <hannes@cmpxchg.org>, Thomas Graf <tgraf@suug.ch>,
"Serge E. Hallyn" <serue@us.ibm.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Neil Horman <nhorman@tuxdriver.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Dave Jones <davej@redhat.com>,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH 2.6.32] memcg: warn on deeper hierarchies with use_hierarchy==0
Date: Wed, 19 Sep 2012 12:38:18 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1209191237020.749@chino.kir.corp.google.com> (raw)
In-Reply-To: <20120919140308.GB5398@dhcp22.suse.cz>
On Wed, 19 Sep 2012, Michal Hocko wrote:
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index f99f599..b61c34b 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3106,6 +3106,11 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
> } else {
> parent = mem_cgroup_from_cont(cont->parent);
> mem->use_hierarchy = parent->use_hierarchy;
> + WARN_ONCE(!mem->use_hierarchy && parent != root_mem_cgroup,
> + "Creating hierarchies with use_hierarchy==0 "
> + "(flat hierarchy) is considered deprecated. "
> + "If you believe that your setup is correct, "
> + "we kindly ask you to contact linux-mm@kvack.org and let us know");
When I deprecated /proc/pid/oom_adj (now removed), we did a WARN_ONCE()
and others complained that this unnecessarily alters userspace scripts
that a serious issue has occurred and Linus agreed that we shouldn't do
deprecation in this way. The alternative is to use printk_once() instead.
This applies to all three patches for this one, 3.0, and 3.2+.
next prev parent reply other threads:[~2012-09-19 19:38 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 20:58 [RFC] cgroup TODOs Tejun Heo
2012-09-14 9:04 ` Mike Galbraith
2012-09-14 17:17 ` Tejun Heo
2012-09-14 9:10 ` Daniel P. Berrange
2012-09-14 13:58 ` Vivek Goyal
2012-09-14 19:29 ` Tejun Heo
2012-09-14 21:51 ` Kay Sievers
[not found] ` <5052E7DF.7040000@parallels.com>
2012-09-14 9:12 ` Li Zefan
2012-09-14 11:22 ` Peter Zijlstra
2012-09-14 17:59 ` Tejun Heo
2012-09-14 18:23 ` Peter Zijlstra
2012-09-14 18:33 ` Tejun Heo
2012-09-14 17:43 ` Tejun Heo
2012-09-17 8:50 ` Glauber Costa
2012-09-17 17:21 ` Tejun Heo
2012-09-14 11:15 ` Peter Zijlstra
2012-09-14 12:54 ` Daniel P. Berrange
2012-09-14 17:53 ` Tejun Heo
2012-09-14 14:25 ` Vivek Goyal
2012-09-14 14:53 ` Peter Zijlstra
2012-09-14 15:14 ` Vivek Goyal
2012-09-14 21:57 ` Tejun Heo
2012-09-17 15:27 ` Vivek Goyal
2012-09-18 18:08 ` Vivek Goyal
2012-09-14 21:39 ` Tejun Heo
2012-09-17 15:05 ` Vivek Goyal
2012-09-17 16:40 ` Tejun Heo
2012-09-14 15:03 ` Michal Hocko
2012-09-19 14:02 ` Michal Hocko
2012-09-19 14:03 ` [PATCH 2.6.32] memcg: warn on deeper hierarchies with use_hierarchy==0 Michal Hocko
2012-09-19 19:38 ` David Rientjes [this message]
2012-09-20 13:24 ` Michal Hocko
2012-09-20 22:33 ` David Rientjes
2012-09-21 7:16 ` Michal Hocko
2012-09-19 14:03 ` [PATCH 3.0] " Michal Hocko
2012-09-19 14:05 ` [PATCH 3.2+] " Michal Hocko
2012-09-14 18:07 ` [RFC] cgroup TODOs Vivek Goyal
2012-09-14 18:53 ` Tejun Heo
2012-09-14 19:28 ` Vivek Goyal
2012-09-14 19:44 ` Tejun Heo
2012-09-14 19:49 ` Tejun Heo
2012-09-14 20:39 ` Tejun Heo
2012-09-17 8:40 ` Glauber Costa
2012-09-17 17:30 ` Tejun Heo
2012-09-17 14:37 ` Vivek Goyal
2012-09-14 18:36 ` Aristeu Rozanski
2012-09-14 18:54 ` Tejun Heo
2012-09-15 2:20 ` Serge E. Hallyn
2012-09-15 9:27 ` Controlling devices and device namespaces Eric W. Biederman
2012-09-15 22:05 ` Serge E. Hallyn
2012-09-16 0:24 ` Eric W. Biederman
2012-09-16 3:31 ` Serge E. Hallyn
2012-09-16 11:21 ` Alan Cox
2012-09-16 11:56 ` Eric W. Biederman
2012-09-16 12:17 ` Eric W. Biederman
2012-09-16 13:32 ` Serge Hallyn
2012-09-16 14:23 ` Eric W. Biederman
2012-09-16 16:13 ` Alan Cox
2012-09-16 17:49 ` Eric W. Biederman
2012-09-16 16:15 ` Serge Hallyn
2012-09-16 16:53 ` Eric W. Biederman
2012-09-16 8:19 ` [RFC] cgroup TODOs James Bottomley
2012-09-16 14:41 ` Eric W. Biederman
2012-09-17 13:21 ` Aristeu Rozanski
2012-09-14 22:03 ` Dhaval Giani
2012-09-14 22:06 ` Tejun Heo
2012-09-20 1:33 ` Andy Lutomirski
2012-09-20 18:26 ` Tejun Heo
2012-09-20 18:39 ` Andy Lutomirski
2012-09-21 21:40 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1209191237020.749@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=acme@ghostprotocols.net \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=ben@decadent.org.uk \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=davej@redhat.com \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=mingo@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=serue@us.ibm.com \
--cc=tgraf@suug.ch \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).